Remove leading orphan separators from the context menu - #836
Open
loliri wants to merge 1 commit into
Open
Conversation
When modify rules move or hide system items, the separators that grouped them can be left orphaned at the very top of the menu. Trailing orphan separators are already cleaned up; this mirrors that cleanup for the leading ones and clears the Top flag of the first remaining item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
modifyrules move system items to another menu (menu=...) or hide them (vis=vis.remove), the separators that used to group those items can be left orphaned at the very top of the context menu — a stray separator as the first line.Trailing orphan separators are already cleaned up by the existing
// remove duplicate separatorsloop inContextMenu.cpp, but leading ones are not handled at all.Fix
Mirror the existing trailing cleanup: strip leading separator items from the assembled item list and clear the
Separator::Topflag of the first remaining item.Repro
Right-click a
.lnkfile → the first line of the menu is an orphan separator (verified on zh-CN Windows 11, v1.9.18).