fix(28): unbreak fast-suite CI (google-cloud dev deps + R2/satellite test guards)#97
Merged
Merged
Conversation
…ps; guard R2/satellite tests PR #96 added services/earnings/jobs tests that need the Cloud Run deploy deps, but the CI fast-suite runs `uv sync --all-packages` (no optional extras), so they errored (ModuleNotFoundError: google / boto3) and reddened main. Root cause: those deploy deps aren't installed in the base workspace. Fixes (verified against the exact CI env — boto3 pruned, google.cloud present: 3925 passed, 466 skipped, 0 failed): - Add google-cloud-pubsub + google-cloud-storage to the workspace dev group (same pattern as fastapi in Phase 27) so the capture/STT/handoff job tests import the `google.cloud` namespace (clients are still faked). - Do NOT add boto3: it is the [satellite]-extra marker several satellite tests key their skip-guard on (test_satellite_leakage), so adding it would make those guards falsely fire and crash on the still-absent s3fs/xarray. - Guard the serving R2-read tests (test_serving_r2_read) on boto3 — they exercise the S3-compat botocore error paths, so they run in the satellite/deploy lanes. - Guard test_roster's station-resolution test (imports satellite/_backfill → _goes_s3 → boto3/s3fs/xarray) on the [satellite] extra, like test_cli_roster. - Fold in the batch.tf GOES-footprint note that missed the merge commit (staging race). Recovery from an admin-merge of #96 whose CI hadn't finished (my error) — this time verified green in a CI-mimicking venv before pushing.
|
Parity ticket gate: PASSED See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for main — PR #96 was admin-merged before CI finished and reddened the fast-suite: the new
services/earnings/jobstests need Cloud Run deploy deps thatuv sync --all-packagesdoesn't install (ModuleNotFoundError: google/boto3).Fix (verified in a CI-mimicking venv: 3925 passed, 466 skipped, 0 failed):
google-cloud-pubsub+google-cloud-storageto the workspace dev group (same pattern as fastapi) so capture/STT/handoff job tests import thegoogle.cloudnamespace.[satellite]-extra marker several satellite tests key their skip-guard on; adding it would make them falsely run and crash on absents3fs/xarray.🤖 Generated with Claude Code