fix(28-21): drop non-existent google_batch_job resource; keep fleet spec as docs#94
Merged
Merged
Conversation
…pec as docs google_batch_job is not a real resource type in the hashicorp/google or google-beta provider (verified vs pinned 6.50.0) — Cloud Batch is submit-only, so `tofu -chdir=infra validate` failed with "provider hashicorp/google-beta does not support resource type google_batch_job", blocking any Phase 28 apply. Pre-existing (merged in #92), independent of the phase28/deploy-runtime-layer branch. Remove the phantom resource and preserve the shard/Spot/duration/secret/ marker-bucket spec as a reviewable comment. run-weather-backfill.yml is the real submit path (`gcloud batch jobs submit --config`). Document task_count=65 (Kalshi∪Polymarket roster minus non-satellite HKO) to match the workflow's TASK_COUNT=65 — the committed file had drifted to 66. The durable progress bucket + its IAM binding stay as standing resources. Eliminates the batch.tf validate error; the remaining cloud_run.tf max_instance_count errors are a separate task. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Parity ticket gate: PASSED See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
infra/batch.tfdeclaredresource "google_batch_job" "weather_backfill", butgoogle_batch_jobis not a real resource type in thehashicorp/googleorhashicorp/google-betaprovider (verified against the pinned 6.50.0 binary — it hasgoogle_storage_batch_operations_jobandgoogle_dataproc_batch, but nogoogle_batch_job). GCP Cloud Batch is submit-only and has no first-class Terraform resource.So
tofu -chdir=infra validatefailed with:…blocking any apply of the Phase 28 platform. Pre-existing (merged in #92), independent of the
phase28/deploy-runtime-layerbranch.Fix (option a — the workflow is already the submit path)
google_batch_jobresource.run-weather-backfill.yml→gcloud batch jobs submit --config(the correct API for submit-only Cloud Batch).task_count = 65(Kalshi∪Polymarket roster of 66 minus the non-satellite HKO) to match the workflow'sTASK_COUNT=65. The committed file had drifted to66.google_storage_bucket.backfill_progress+ its..._iam_member.backfill_progress_rw— those are real standing resources.Verification
Offline:
tofu -chdir=infra init -backend=false+tofu -chdir=infra validate(providerhashicorp/google 6.50.0).batch.tf:72(google_batch_job) + threecloud_run.tfmax_instance_count.batch.tferrors = 0.tofu fmt -checkdoes not flagbatch.tf.tofu validateis not yet fully green: the only remaining errors are the threecloud_run.tftop-levelscaling { max_instance_count }misplacements — a separate task, intentionally not touched here to avoid conflicting with that work. Once both land, validate goes green.🤖 Generated with Claude Code