Diffuser bug fixes; fix truncation of leading zeros in returned binary secrets.

[lellis1936]

The diffuser was not handling padding in a manner compatible with ssss-split; in some cases shares were produced SecretSplitter that could not be used to recover the secret (about .4% probability).

When binary secrets with leading nulls were recovered, those leading nulls were not present.

These problems are fixed in this commit, but some older shares, when used with this version, might not recover the correct secret. I've made some comments about this in the compatibility.txt file. But in truth I believe the newer program will successfully handle more shares correctly than the old program.

[kdaveid]

Hi @lellis1936

Thanks for your comment!
It's a fairly old PR. Do you have tried to connect with @moserware yet? Why is it still pending?

In the case there are proven bugs we would like to support here. Otherwise we have to look around for another implementation.

Kind regards,
David

[lellis1936]

@kdaveid,

I'd say this library was originally done more or less as an educational project and is no longer being maintained.

The original author is aware of the pull requests.

I'd suggest seeking an actively maintained crypto library that supports Shamir's secret sharing. Offhand I don't know of one that is written in .Net, unfortunately (not to say that one does not exist). For example, the widely-used Bouncy.Net does not appear to include it.

Were you writing in C++, you might consider the prominent Crypto++ library by Wei Dei (which does include it).

Good luck.