modular lltvs#993
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2c7b83de6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// | ||
| /// ROLES | ||
| /// @dev The role setter can set the role setter, fee setter, fee claimer, and tick spacing setter. | ||
| /// @dev The role setter can set the role setter, fee setter, fee claimer, and tick spacing setter, and add LLTV tiers. |
There was a problem hiding this comment.
should we rename roleSetter? eg configurator
There was a problem hiding this comment.
or should it set a LLTV setter ? Maybe not so useful since we don't have it in Blue
There was a problem hiding this comment.
agree that it's not useful
| /// | ||
| /// ROLES | ||
| /// @dev The role setter can set the role setter, fee setter, fee claimer, and tick spacing setter. | ||
| /// @dev The role setter can set the role setter, fee setter, fee claimer, and tick spacing setter, and add LLTV tiers. |
There was a problem hiding this comment.
or should it set a LLTV setter ? Maybe not so useful since we don't have it in Blue
3 participants
#992 will add useful bounds (after having added modular LIFs)