Repository navigation
fix: a scene pad marks a lost mask, and the flash names its readback - #203
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 799f281ff8bb4b3680efa5b087740c0895a8d2ff
No blocking findings. Walking the effective filters of visible items catches mask-only dependencies without adding a separate scene traversal. The regression covers a visible layer that would not have been flagged by its own source; the existing nested and hidden assertions still apply.
Small README nit at line 1716: “up to a quarter of a second and a frame or two” still sounds like a hard limit. The sample interval is bounded, but asynchronous GPU readback can take longer under load; “up to a quarter second, plus GPU readback time” states the distinction.
Reviewed by inspection; I did not run just ci.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the single commit on fix/lost-mask-readback.
- Mask-aware
draws_lost— also checks each drawn layer'sFilter::Masksources viaCollection::filters(the source's filters, then the layer's), so a scene whose layer is masked by a lost camera gets its pad badge.Collection::filtershas a matching signature. - Regression test —
a_pad_marks_what_it_drawsgains aMaskedscene and asserts it is marked. - README wording — the flash duration now says "up to a quarter of a second and a frame or two", matching the GPU readback delay.
claude-sonnet-5-5 | 𝕏
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the prior review, one docs commit landed.
- README flash wording: reworded the flash duration to "a quarter second, plus GPU readback time".
claude-sonnet-5-5 | 𝕏

Follows moq-dev/studio#192, which merged at a81b4d9 before these two fixes for CodeRabbit's last findings on it landed.
Problem
Engine::placedincludes masks), but its scene pad and multiview scene tile showed no badge:ui::dark::draws_lostonly checked each layer's own source (finding).Approach
draws_lostalso checks the mask sources of each drawn layer's filters (Collection::filters, the source's then the layer's), asEngine::placeddoes.Impact
No API, file format, or wire change. Scene pads and multiview scene tiles now badge a scene whose layer is masked by a lost picture.
Alternatives
Exporting
Engine::placed's mask walk for the UI to share: it works on capture names for whole live sets, while the pad asks one scene with the UI's own predicate, so a three-line filter besidedrawnis simpler.Follow-ups
None.
Validation
ui::dark::tests::a_pad_marks_what_it_drawsadds a sceneMaskedwhose color layer is masked by the lost camera, and checks its pad is marked.just cipasses (423 tests).Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, XS, arm A)
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 618e825
Base: origin/main at 5ed00c3
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e986-15a8-7010-9452-7fc75d4125bc, round 2Score: 9/10,
The only new change clarifies GPU readback latency in the README and introduces no actionable defects; the prior review remains applicable, with tests not run as instructed.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1e986-15a8-7db0-9e25-aaad90d36ff7Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0