Skip to content

fix: a scene pad marks a lost mask, and the flash names its readback - #203

Merged
kixelated merged 2 commits into
mainfrom
fix/lost-mask-readback
Nov 17, 2026
Merged

kixelated merged 2 commits into
mainfrom
fix/lost-mask-readback

Conversation

@kixelated

@kixelated kixelated commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Follows moq-dev/studio#192, which merged at a81b4d9 before these two fixes for CodeRabbit's last findings on it landed.

Problem

  • A scene whose visible layer reads a dark or stalled camera through a mask filter counts in Health (Engine::placed includes masks), but its scene pad and multiview scene tile showed no badge: ui::dark::draws_lost only checked each layer's own source (finding).
  • README said a moment of black shows "up to a quarter of a second", but the read that catches it also has to come back from the GPU before a later render can hold the last good picture (finding).

Approach

  • draws_lost also checks the mask sources of each drawn layer's filters (Collection::filters, the source's then the layer's), as Engine::placed does.
  • README: "until its picture is next read and that read comes back from the GPU, up to a quarter of a second and a frame or two".

Impact

No API, file format, or wire change. Scene pads and multiview scene tiles now badge a scene whose layer is masked by a lost picture.

Alternatives

Exporting Engine::placed's mask walk for the UI to share: it works on capture names for whole live sets, while the pad asks one scene with the UI's own predicate, so a three-line filter beside drawn is simpler.

Follow-ups

None.

Validation

  • ui::dark::tests::a_pad_marks_what_it_draws adds a scene Masked whose color layer is masked by the lost camera, and checks its pad is marked.
  • just ci passes (423 tests).

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, XS, arm A)

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 618e825

  • Base: origin/main at 5ed00c3

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e986-15a8-7010-9452-7fc75d4125bc, round 2

  • Score: 9/10, The only new change clarifies GPU readback latency in the README and introduces no actionable defects; the prior review remains applicable, with tests not run as instructed.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1e986-15a8-7db0-9e25-aaad90d36ff7

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 17, 2026 12:41
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 52cfb78c-2e10-4619-b51b-cc1fa64e87d4
Commits

Reviewing files that changed from the base of the PR and between 5ed00c3 and 618e825.

Files selected for processing: 2

  • README.md
  • rs/moq-studio/src/ui/dark.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 799f281ff8bb4b3680efa5b087740c0895a8d2ff

No blocking findings. Walking the effective filters of visible items catches mask-only dependencies without adding a separate scene traversal. The regression covers a visible layer that would not have been flagged by its own source; the existing nested and hidden assertions still apply.

Small README nit at line 1716: “up to a quarter of a second and a frame or two” still sounds like a hard limit. The sample interval is bounded, but asynchronous GPU readback can take longer under load; “up to a quarter second, plus GPU readback time” states the distinction.

Reviewed by inspection; I did not run just ci.

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 17, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the single commit on fix/lost-mask-readback.

  • Mask-aware draws_lost — also checks each drawn layer's Filter::Mask sources via Collection::filters (the source's filters, then the layer's), so a scene whose layer is masked by a lost camera gets its pad badge. Collection::filters has a matching signature.
  • Regression test — a_pad_marks_what_it_draws gains a Masked scene and asserts it is marked.
  • README wording — the flash duration now says "up to a quarter of a second and a frame or two", matching the GPU readback delay.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Since the prior review, one docs commit landed.

  • README flash wording: reworded the flash duration to "a quarter second, plus GPU readback time".

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated merged commit 7e75078 into main Nov 17, 2026
3 checks passed
@kixelated
kixelated deleted the fix/lost-mask-readback branch November 17, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant