Repository navigation
feat: a capture that went black says so #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
52ca58a
chore(quest): claim quest/m1/capture-health.md
kixelated 4d8a4a0
feat: a capture that went black says so
kixelated c956596
fix: a mouse pointer over a black capture leaves it dark
kixelated d67afa8
chore: views for the PR body
kixelated 39aaf81
chore: drop the PR body's views
kixelated 9d06caf
feat: a camera or broadcast that stopped sending pictures says so
kixelated bba33e2
chore: views for the PR body
kixelated 0276d76
chore: drop the PR body's views
kixelated 96cdd44
fix: a lost picture is reported once, held only while watched, and ba…
kixelated efcbc5c
docs: a moment of black shows until the next read
kixelated 736a435
fix: a clear forgets the last good picture
kixelated 5d55372
fix: a reopened capture holds nothing from before, and a picked windo…
kixelated 92c36ad
fix: a feed started again holds nothing from the one before
kixelated b6b3711
fix: a feed started again never reads the picture from before
kixelated d519f94
docs: picking or opening a capture again keeps its last picture until…
kixelated 38bb245
Merge origin/main into quest/m1/capture-health
kixelated a2c126d
fix: a lost picture's pill stays inside its layer or tile
kixelated a57db47
chore: views for the PR body
kixelated 5b13540
chore: drop the PR body's views
kixelated 357b74f
fix: CodeRabbit's findings on the lost-picture badge
kixelated 627b11b
Merge branch 'main' into quest/m1/capture-health
kixelated a81b4d9
Merge branch 'main' into quest/m1/capture-health
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the GPU readback time in the flash duration.
If black arrives just after a probe read, the next read can wait nearly 250 ms. Black then remains visible until the asynchronous readback completes and a later render judges it. The quarter-second limit is therefore not guaranteed. Describe the readback delay as additional time. (raw.githubusercontent.com)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid. This PR merged at a81b4d9 before the fix landed, so it is in #203: the README now says the black shows until the next read comes back from the GPU, up to a quarter of a second and a frame or two.
(Written by Claude Opus 5.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 27586
@kixelatedThanks.#203adds the GPU readback delay, but “up to … a frame or two” still implies a fixed upper bound. The readback is asynchronous, andProbe::stepdoes not guarantee that it completes within two frames.Could the README describe a quarter-second sampling interval plus GPU readback and render delay, without a maximum? I’m not marking the finding as addressed yet.
Learnings added
You are interacting with an AI system.