Repository navigation
feat: scenes that lay themselves out, by slots and roles #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ab0fec5
chore(quest): claim quest/m1/auto-layout.md
kixelated da270de
feat(scene): slots, roles, and a reflow that glides
kixelated d52f1be
feat(studio): slots on BUILD, roles, and guests that appear on their own
kixelated 838767d
chore(quest): finish auto-layout, leaving its human check
kixelated d857dd3
chore: the slot views, for the PR body (deleted next)
kixelated b5829c5
chore: drop the slot views, hosted for the PR body
kixelated 750ca0f
test(studio): a guest joining through the room appears in the next tile
kixelated 5e785d3
fix: slots and roles through removal, copy, duplication, crop, and In…
kixelated 4ed7c83
fix: a slot crops from what it shows, and a page takes input mid-glide
kixelated f3a5e12
fix(studio): a guest who left frees their place among the four
kixelated 88056f8
fix: an appearance once per link, free layers outside the glide
kixelated f55a8b0
fix(studio): keep who appeared on their own beside the room key
kixelated 5aba1c4
fix(studio): save the appearance latch before the guest goes on
kixelated 93d7ec1
fix(studio): a returning guest makes no fifth tile
kixelated 05d6b1c
fix(studio): take only a departed guest's camera tile, and only their…
kixelated c572ddf
docs: the reflow key's comment, and the latch kept across restarts
kixelated 7e9ccee
fix(studio): mark the tiles the studio places, and take only those
kixelated 6569079
fix(studio): a guest taking a tile gets one of their own
kixelated 15effe1
Merge origin/main: drop and paste anything on the picture (#193)
kixelated b2fe89d
fix(studio): one broadcast under two names, a stuck latch, an unfille…
kixelated ac6d4a2
fix(studio): an unfilled role offers no copy of its own
kixelated ffd00c6
Merge origin/main: a multiview window (#195)
kixelated 83a856e
fix: scenes swapping names keep their slots, and an appearance lets g…
kixelated f7465f2
fix(studio): a row dropped after a guest appears moves nothing
kixelated a221231
Merge origin/main: bump quest to v0.17.2 (#196, #197)
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # [XS] Watch the slots reflow with real guests | ||
|
|
||
| ## Goal | ||
|
|
||
| The maintainer has seen a scene laid out by slots reflow on a real show, with | ||
| guests joining and leaving mid-stream, and it reads as a deliberate glide | ||
| rather than a glitch. If it does not, the reflow's length, easing, or what | ||
| closes a slot changes until it does. | ||
|
|
||
| ## Plan | ||
|
|
||
| The geometry, the glide's frames on the program clock, and a guest taking a | ||
| tile are tested in moq-scene and the studio, and BUILD's views show the | ||
| slots. Whether the motion reads well is a judgment no test makes, so it waits | ||
| on a person watching. | ||
|
|
||
| ## Waiting | ||
|
|
||
| - Maintainer: run a show with a scene laid out by slots on program and | ||
| **Appear on their own** on (Settings, Guests), have two guests join from | ||
| the join page and one leave, and watch the program and a recording. An | ||
| agent cannot judge how motion reads to a viewer; the GPU tests already | ||
| check the frames. Done when the glide reads as intended, or the change it | ||
| needs is written into this Plan. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.