Repository navigation
Conversation
Quest-Claim: b64d41df3c92d367
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
No configured credential can serve this run. Your Claude subscription has hit its usage limit, which resets at 2026-11-18 06:00 UTC. Re-trigger after it resets, or add an API key for this provider, which Pullfrog falls back to automatically. The providers' responses
|
1 similar comment
|
No configured credential can serve this run. Your Claude subscription has hit its usage limit, which resets at 2026-11-18 06:00 UTC. Re-trigger after it resets, or add an API key for this provider, which Pullfrog falls back to automatically. The providers' responses
|
|
@pullfrog review this PR's head. (Written by Claude Opus 5.5 with high effort) |
|
No configured credential can serve this run. Your Claude subscription has hit its usage limit, which resets at 2026-11-18 06:00 UTC. Re-trigger after it resets, or add an API key for this provider, which Pullfrog falls back to automatically. The providers' responses
|

Finishes quest/m0/github-quota/installation-token.md.
A person with a Kixel Quest token now reads GitHub on a read-only App installation token Kixel Quest mints per repository, so those reads draw on the installation's rate limit, not their 5,000 an hour. Writes stay on their own token.
Summary
POST /installation-tokenclient (KixelQuest.installation,src/cli/forge.ts), andliveFor: the forge for reads that must come from GitHub itself. It backsHosting.live()(quest start,quest review's record,quest pr list) andquest pr view. Where Kixel Quest serves the repository the index answers everything else, so those are the reads that reach GitHub.$XDG_CACHE_HOME/quest/installation(files 0600, directory 0700) until 5 minutes beforeexpiresAt, so a host mints about once per repository an hour. A lock file per token (created exclusively, owned by its holder, taken over after 30 seconds; a holder gets 20 seconds to mint, so a live one is never taken over) makes parallel agents on a cold or expiring cache mint once between them.QUEST_FORGE=github. A 429 (with itsRetry-After), 401/403, 5xx, a malformed answer, a token for another repository, one too close to expiry, or an unusable cache directory fails the command namingQUEST_FORGE=github; none quietly spends the person's quota.quest waittakes the person from the mint'slogin, throughGitHubForge's existingviewerargument, so the person's own replies, reactions, labels, and edits do not wake it thoughvieweron the token is the App.GitHubReader(GET and GraphQL queries, built fromGitHubReadDependencieswith areadToken) andGitHub extends GitHubReader(built fromGitHubDependencieswith the person'stoken; adds other methods and mutations). Every read module insrc/githubtakes aGitHubReader; a write on a read token has no constructor to go through, and a mutation sent to a reader throws.README.mddocuments the mint.Public API and wire
Breaking for
quest/githubconsumers, so!:GitHubForge,pullRequestStatus,readHoldStatus, andwatchPulltakeGitHubReadDependencies(readTokenin place oftoken); read helpers (openPullRequests,pullView,held,requirements, ...) take aGitHubReaderinstead of aGitHub. To migrate, passreading(deps)for a person'sGitHubDependencies, or aGitHubReader/GitHubwhere a client is taken.GitHubandGitHubDependenciesare unchanged.GitHubReader,GitHubReadDependencies,reading.ClaimDependenciesgainslive(repository), andHosting.live()is async.POST /installation-token(kixel-ai/kixel.quest#51, merged and deployed: it answers 401 with no token)./forgeis unchanged.Decisions
QUEST_FORGE=githubis named as the way out.Upstream.github.client, whichquest start,quest usage, andquest evaluse to probe the repository, its fork, and its parent, stays on the person's token: those probes reach repositories the installation may not cover (a private fork), and the ETag cache already makes their repeats free.flock, which macOS lacks; two waiters that take over a stale lock at once may mint twice, one more of the cap.live()use.Validation
just checkandjust testpass.test/installation.test.tsruns a fake Kixel Quest and a fake GitHub that record each request's token: a read goes out on the minted token and a write (GitHubWrites.close) on the person's; one mint is reused across runs and replaced within 5 minutes of expiry, per repository and per Kixel Quest token; eight parallel agents on a cold cache mint once (a plain write instead of the exclusive create fails it); a stale lock is taken over and a held one waited for until the deadline; a 404 reads on the person's token, and a 429, 502, 503, 401, a malformed mint, and an unwritable cache fail namingQUEST_FORGE=githubwith no GitHub request made; andquest waiton a minted token (viewer answering the App) still ignores the person's own reply, reaction, label, and edit. Dropping the mint'sloginfromliveForfails that test. The@ts-expect-errorlines in it failtscif a read client gains a write or a write accepts read dependencies.Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (arm B)
🤖 Generated with Claude Code
(Written by Sonnet 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 466689d
Base: origin/main at 80cd2c8
Risk: high,
The change alters quest/github’s public dependency contracts and GitHub credential handling, which can break Kixel Code integrations or expose cached repository tokens; reverting restores the code but cannot undo credential exposure or actions taken using incorrect reads.Classified: high by Codex, gpt-6.1-sol, low effort, session
01a1ebd2-ab82-7860-8692-12611cc31500Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1ebcd-38b5-7992-a6ca-31ee1a145fe2, round 3Score: 10/10,
The bounded mint request and ownership-aware lock release resolve the outstanding finding; code review found no new issues, and builds and tests were not run as instructed.Rounds: 3; first round 1 (medium 1); findings 1 (medium 1): fixed 1, refuted 0, open 0
Findings: none
The last round's findings, at 549fcac:
src/cli/installation.ts:127:Preserve lock ownership during slow token mints;exclusive passes a 20-second deadline to the mint request, enforced through AbortSignal.timeout before the 30-second takeover threshold, and cleanup checks the lock's owner ID before removing it.Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1ebcd-38b9-7b12-a0fd-086bf640908f, round 3Score: 10/10,
The bounded mint deadline and ownership-aware lock release address the remaining finding, with no new blocking issues found in the incremental changes.Rounds: 3; first round 1 (medium 1); findings 2 (medium 2): fixed 2, refuted 0, open 0
Findings: none
The last round's findings, at 549fcac:
src/cli/installation.ts:127:Keep the lock valid while its holder is still minting;exclusive now bounds minting to 20 seconds, below the 30-second takeover threshold, and releases the lock only when its owner identifier still matches.