Repository navigation
feat(status): report quests another open PR also adds - #762
Conversation
Quest-Claim: 4bd930cba12f919e
quest status prints a duplicate line for each quest an open PR adds that another open PR adds at the same path or under the same title, and the guide's Creation section has agents search open PRs' quest files before adding a follow-up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI) · 6b3a245cd4379c2580086b6fddf22e5719a846ce
- The pre-creation check misses older open PRs. The guide's
gh pr list --json number,url,filesexample defaults to 30 PRs. The validation used a repo with 45 open PRs, so following the example drops 15 from the very search meant to find their quests before creation. Document a paginated command or an explicit limit checked against the open count. The laterquest statuswarning is useful, but doesn't prevent the wasted creation work. - Keep duplicate findings tied to the reported head.
pullRequestStatuschecks the signals' head against its initial read, thenduplicateQuestsindependently fetches the current head for the same PR. A push between those calls can return a status for one revision with duplicate paths from another, which the review skill asks the agent to resolve. Pass the expected head into that scan and retry on mismatch, with a head-changing fixture.
Static review only; I did not run the tests.
There was a problem hiding this comment.
ℹ️ No critical issues. One gap in the guide's search command is noted inline.
Reviewed changes
I reviewed the whole PR: the new duplicate detection behind quest status, plus the guide, skill, README, and help text that point agents to it.
duplicateQuestsinsrc/github/duplicates.ts: It pages every open PR's addedquest/**files over GraphQL and falls back to REST for any PR with more than 100 files. It reads titles at each head in batchedobject(expression:)queries, and only when the PR itself adds a quest. It matches quests by path or bytitleKey.Status.duplicatesand theduplicateline: These are computed only for an open PR, after the signal head check. The only caller isquest status.- Guide and
/quest-review: Creation now also searches open PRs' quest files and adds nothing when another PR owns the work. Eachduplicateline has to be resolved before the PR is marked ready or picked. - Tests: They cover a path match, a title match across size, case, and spacing, the REST fallback, ignoring
MODIFIEDfiles andAGENTS.md, skipping the title read when the PR adds no quests, and a closed PR.
claude-opus-5-5 | 𝕏
gh pr list stops at 30 PRs without --limit and gh's files field at 100 per PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI) · e93233166c73c7864be4e9bd882fc649fdca0fed
The guide now covers the observed 45-PR case and calls out the per-PR file cap. My other finding still stands: the duplicate scan can use a newer head than the status record it is attached to. I’d still pass the expected head and reject a mismatch before using the paths to resolve a duplicate. Static re-review only.
Main's #753 moved the status types to quest/core behind a strict forge wire parser, so `Duplicate` and `Status.duplicates` move there with a parser entry, and the duplicate fakes move into test/status-fakes.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Changes since the prior Pullfrog review at 6b3a245.
- Guide search fixed:
assets/AGENTS.mdnow passes--limit 1000togh pr listand documentsgh api --paginatefor PRs over 100 files, which addresses the earlier thread. - Merged main:
DuplicateandStatus.duplicatesnow live insrc/core/forge.tswith a strict parser entry.src/github/status.tsand the tests were adapted to match.
claude-sonnet-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI) · 71ae435c99529d113cd2ef82e38989b034e00799
P2: This makes the status field a breaking forge wire change. The merge moved duplicates into src/core/forge.ts as a required field in an exact shape. A new CLI rejects an existing Kixel Quest response without it (value.duplicates); an old CLI rejects the extra field once the server starts sending it. Since indexed reads fail rather than silently fall back, a normal staggered upgrade can break quest status. Version or negotiate the response shape, or retain the old wire shape and attach duplicate detection on a compatible path. Test the new CLI against an old status reply and protect old clients from the additive field. The prior mixed-head duplicate scan issue is still open separately. Static re-review only.

Agents kept adding a follow-up quest that main or another open PR already had (rind's
/quest-runadded the FIPS fork-test hang five times and the dart-ios hang three times). Each one cost the maintainer a pick round and a manualquest rm. This PR finishes quest/m0/follow-up-duplicates.md and deletes it.Changes
quest status <pr>now prints aduplicate <path> <other-pr-url> <other-path>line for each quest an open PR adds that another open PR also adds. A match is either the same path or the same title, ignoring the[size]tag, case, and spacing.--jsongets a matchingduplicatesarray. It's a warning in the status output, not an error, because two PRs can legitimately touch one quest. New code is insrc/github/duplicates.ts. It reads every open PR's added files in one paged GraphQL query (50 PRs per page), falls back to REST for any PR with more than 100 files, and reads the added quests' titles at each PR's head in batched blob queries. The title query only runs when the PR itself adds a quest. A closed or merged PR reads nothing extra.assets/AGENTS.md, Creation):gh pr list --json number,url,files). Before, they only searched the tree and git history. The guide notes that searching PR titles and bodies alone misses PRs that never name the subject.--limit 1000, sincegh pr liststops at 30 PRs otherwise. It also says how to page past gh's 100-file cap per PR.src/github/duplicates.tsalready pages through every open PR and switches to REST past 100 files, so it needed no change.duplicateline has to be resolved before the PR is marked ready or picked./quest-reviewresolvesduplicatelines after its push and before it marks the PR ready.quest status --helpdescribe the new line.Choices made without asking (listed for review):
quest statusand not inquest check.quest checkruns offline (nix flake check, the merge driver,quest merge's pre-queue check) and would need a token and network access.quest statusis already online, and/quest-review,/quest-merge, and/quest-runread it at every step where a duplicate can still be dropped.quest mv) or an edit to an existing quest isn't a new follow-up.Merging main's #753, which moved the status types into
quest/corebehind a strict forge wire parser:DuplicateandStatus.duplicatesnow live insrc/core/forge.ts, with a parser entry, so a Kixel Quest answer must carryduplicates. Kixel Quest doesn't serve/forgeyet and builds its answers withquest/github's reader, so it gets the field when it updates. The README's--jsonfield list namesduplicates.Public API
New
duplicateline inquest statusand a newduplicatesfield in its JSON output. No breaking changes. Each status read of an open PR now costs at least one more GraphQL query. If the PR adds quests, it costs one more per 100 added quest files across the open PRs.Validation
just checkandjust testpass (1424 tests) after merging main at ae12957.test/status.test.tscover: a path match, a title match that differs only in size, case, and spacing, the REST fallback for large PRs, ignoringMODIFIEDfiles andquest/AGENTS.md, a PR that adds no quests (no title read), and a closed PR (no read).quest statuson quest: plan a Cursor CLI reviewer and quota fallthrough for quest review #761, feat(forge)!: read PR, claim, and wait state through a forge with a Kixel Quest backend #753, and feat(records): record what each session gated and the CPU its shell calls used #747 printed noduplicateline. The blob title query returned quest: plan a Cursor CLI reviewer and quota fallthrough for quest review #761's quest titles from GitHub.quest/**.mdfiles over REST (gh api pulls/N/files) for moq-dev/quest and for all 45 open kixel-ai/rind PRs, then looked for repeated paths. There were none. RunningduplicateQuestson each of those rind PRs also returned none, so the two methods agree. Neither repository has a live duplicate right now, so the positive case is only covered by the unit tests.Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, medium effort (arm A)
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, XS, arm A)
Review
Rewritten by
quest reviewafter each round. Round 3's record was written by hand:quest reviewcouldn't write it because GitHub's REST quota was spent.Head: 71ae435
Base: origin/main at ae12957
Risk: high,
The required Status.duplicates field and new status output can break Kixel Code and scripts that consume status, while shipped agent rules change follow-up handling across repositories; reverting restores the code but cannot undo actions agents already took.Classified: high by Codex, gpt-6.1-sol, low effort, session
01a1e8c1-35ee-7af0-a0c8-520bcc48ff39Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e899-8ccb-7561-b4dc-f490bd983ed2, round 3Score: 9/10,
The merge correctly carries duplicate status records into the shared types, strict parser, and test fixtures; no actionable defects were found, with builds and tests not run as instructed.Rounds: 3; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1e899-8cb6-7232-ab57-7aebe056e8d4Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0