Repository navigation
Conversation
Quest-Claim: 9cf9a7f91381fd02
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is selected Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Approach: Sound. The check is tied to the crate selection rather than to a separate path-scoped module. So a dependency change that reshapes the cbindgen header also triggers it, and the full link-and-run path stays in Nightly.
Reviewed changes
I reviewed all 3 commits. That covers the new --syntax mode, where it hooks into the gate, and the scope and test updates.
sh/rs/c-tests.sh --syntax: Runscargo checkinstead ofcargo build --features openh264, so it never builds the staticlib. It finds the header through thebuild-script-executedout_dir, whichcargo checkalso reports. It reuses the doc-sample checks, then runs-fsyntax-onlyon each fixture and exits before the link, run, and CMake probes.sh/rs/select.sh: Only thelintaction runs it, and only when libmoq is selected. The new seeds mapsh/rs/c-tests.sh,doc/lib/c/*, anddoc/lib/samples.shto libmoq. The Windows and macOSplatformaction doesn't reach this branch, so no non-Unixccis involved.sh/dispatch.sh: The rs scope picks up the C doc inputs, and the tools list addscc, soCI_STRICTfails up front when no compiler is installed.rs/justfile:c-testsnow passes its arguments through via[positional-arguments].sh/rs/select.test.py: The existing send-depth test now leaves out the new call, since moq-net, kio, andCargo.locknow select libmoq. The new test checks the trigger paths, that the check runs only in lint, and that moq-auth doesn't trigger it.
claude-opus-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe C test script now supports a syntax-only mode that checks C documentation samples and fixture sources against the generated header. The existing build, link, and execution path remains available without that option. Rust lint selection now includes relevant libmoq C inputs and invokes the syntax-only check. Selection tests cover the new routing behavior. The document describing a proposed C-fixture merge gate was removed. Merge Risk:
|

Summary
The merge gate now compiles libmoq's C fixtures (
rs/libmoq/c-tests/*.c) and the C doc samples against the generatedmoq.hwhenever the Rust selection includes libmoq. A PR that changes a libmoq C signature therefore fails the gate if a fixture still uses the old shape, instead of the break first turning up in Nightly.sh/rs/c-tests.sh --syntax: runscargo check -p libmoq(build.rs writes the header, so there is no codegen and no staticlib), asks cargo where the header landed, then runs the doc-sample checks it already had andcc -fsyntax-only -Werror=implicit-function-declarationon each fixture. It skips the link, the run, and the CMake probes.sh/rs/select.sh: thelintaction runsjust rs c-tests --syntaxwhen libmoq is selected. That covers libmoq itself, any crate libmoq depends on, andALL. It also addssh/rs/c-tests.sh,doc/lib/c/, anddoc/lib/samples.shas libmoq seeds.sh/dispatch.sh: thersmodule's scope addsdoc/lib/c/anddoc/lib/samples.sh, and its tools addcc. UnderCI_STRICT, a missing compiler now errors up front instead of failing partway through.rs/justfile:c-testspasses its arguments through.quest/m0/ci/c-fixtures-gate.md.test/smoke/clients/c/subscribe.cstays out of this, as the quest planned: it builds against the published package on purpose. The full link-and-runjust rs c-testsstill runs in Nightly and in OBS.Decisions
These were taken without the maintainer, and a review can undo any of them:
lintphase, keyed on the crate selection. A separate dispatch module scoped tors/libmoq/was the other option. Keying on the selection also catches a change in a dependency that alters the generated header, and it reuses the target directory the lint'scargo dochas already warmed.--syntaxalready compiles them against the same header, so they come for free.ccto the rs module's required tools. A Rust build already needs a C linker, so local runs lose nothing in practice.Validation
bash sh/rs/c-tests.sh --syntaxon this branch passes. On a warm cache it takes about 1s of CPU (Finished ... in 0.32s, plus the compiler).abort-unwanted.c:211to the 3-argumentmoq_consume_catalogcall from the 11-17 Nightly break. The script then fails witherror: too few arguments to function 'moq_consume_catalog'; expected 4, have 3.just rs lint-changedon a diff ofsh/rs/c-tests.sh. It selected libmoq, ran the libmoq lint, and ended with the new syntax check, all passing.just checkpassed on this branch. It ran every module (54 passed, none skipped) becausesh/dispatch.shchanged, and the workspace lint ran the new syntax check.python3 sh/rs/select.test.pypasses (26 tests). The newtest_gate_compiles_c_callers_against_libmoqchecks which paths trigger the check, that it runs once and only in lint, and that an unrelated crate (moq-auth) does not trigger it.Gate cost: about a second when libmoq is selected (
cargo check -p libmoqreuses the lint's build, then 5-fsyntax-onlycompiles). Nothing changes when libmoq isn't selected.Impact
Public API: none. Wire: none.
Caused by
Follow-ups
None.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, medium effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with medium)
Review
Rewritten by
quest reviewafter each round.Head: 9f560d1
Base: origin/main at a245f60
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1f157-f222-7192-97f7-684ffdd44b5d, round 1Score: 9/10,
The syntax-only check integrates into change selection and preserves the full fixture runner, with no actionable defects found by source inspection; builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none