Skip to content

quest: plan the 11-18 nightly triage's remaining causes - #9125

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/nightly-1118
Nov 18, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/nightly-1118

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the causes from the 11-17 and 11-18 Nightly, Interop and TS triage that no open PR fixes, and adds a moq-net rule.

Quests

Quest Size Milestone Why there
m0/nightly/js-resume-window.md M m0 JS resume-model red since #9027; WIP on fix/js-resume-window-wip
m0/nightly/audio-quality-p50.md S m0 Audio quality red on a 1.3 ms ceiling
m0/nightly/publisher-drop-cost.md L m0 publisher wake/8192 times out Rust bench targets (#8638)
m0/nightly/resume-mutants.md M m0 mutants shards red
m0/lite07-stale-reset.md L m0 TS validation red since #8908; standalone since TS is its own workflow
m0/ci/c-fixtures-gate.md XS m0 C fixtures broke on a stale merge; a 1 s gate check catches it
m0/interop-green/media-resume-delay.md L m0 Interop media and Nightly firefox player red since 11-12
m2/cluster-routes/dead-instance-flip.md M m2 design follow-up to #9108, not a red run

rs/moq-net/AGENTS.md gains: never finish a stream or producer and forget it; something must abort it eventually.

Decisions

  • Scope: one quest per unowned cause, placed as above. ✅ as proposed (rejected: drop the gate check; route flip into m0).
  • lite-07 stale groups: ✅ reset them again as lite-06 did, plus audit moq-net for finish-and-forget and add the rule (rejected: moq-quic priority past a full window; measure both first).
  • Audio p50 ceiling: ✅ the ±5 ms window now, tighten from runner data later (rejected: a week of runner data first).
  • Publisher drop cost: ✅ no bench stopgap (rejected: batching drops in the fixture).

Public API: none. Wire: none in this PR.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 32fa433

  • Base: origin/main at 4c8af4c

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f0d2-a585-70c2-9195-d7dd8fdc3535, round 1

  • Score: 9/10, The documentation-only change adds quest plans and a lifecycle instruction, with no executable changes or actionable defects identified.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Eight quests for the failures no open PR fixes, and a moq-net rule that a
finished stream or producer is always aborted eventually.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 18, 2026 22:42
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f75e2e9-f72b-4333-aa2f-471b26d93d54
Commits

Reviewing files that changed from the base of the PR and between 4c8af4c and 32fa433.

Files selected for processing: 10

  • quest/m0/ci/c-fixtures-gate.md
  • quest/m0/interop-green/media-resume-delay.md
  • quest/m0/lite07-stale-reset.md
  • quest/m0/nightly/README.md
  • quest/m0/nightly/audio-quality-p50.md
  • quest/m0/nightly/js-resume-window.md
  • quest/m0/nightly/publisher-drop-cost.md
  • quest/m0/nightly/resume-mutants.md
  • quest/m2/cluster-routes/dead-instance-flip.md
  • rs/moq-net/AGENTS.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 18, 2026 22:42

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — one quest per unowned nightly cause, plus a moq-net rule, with no executable changes.

Reviewed changes

  • New quests: eight quest files across m0 and m2 (JS resume window, audio p50, publisher drop cost, resume mutants, lite-07 stale reset, C fixtures gate, media resume delay, dead-instance flip), with relative links to audio-playout and mutants-modelled that resolve.
  • Nightly README: adds the 11-18 triage note and ownership list.
  • rs/moq-net/AGENTS.md: adds the rule never to finish a stream or producer and forget it.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 8c2f024 Nov 18, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/nightly-1118 branch November 18, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant