Repository navigation
Conversation
Quest-Claim: 0c62b287adb01df2
Deleted the one retained nightly-size-history artifact (run 44127032469, cd9a8e9), which still named the moq-c-<target> and moq-c-generated-<target> keys, so the next Nightly starts a fresh history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
Important
The restart also permanently stops measuring the four moq-c-generated-<target> archives, which still ship. #8941 replaced the moq-c-* glob in sh/size/release.py with libmoq-*, and that old glob was what matched the generated C package's artifacts that release-c.yml keeps publishing on c-v* tags. Fresh history means report.py's "missing or renamed" refusal can never name them again, so this is the cheapest moment to restore the pattern.
Approach: sound — the history can't follow a rename by design, and deleting the retained artifact is the documented restart in sh/size/README.md, backed by a local simulation instead of a wasted red run. The gap is that the same restart silently retires a series that is still shipping.
Reviewed changes
- Quest file deleted —
quest/m2/libmoq-size-history.mdrecorded the merged plan and its waiting state; nothing else in the repo links to it, so removing it finishes the quest. - CI artifact deleted (outside the diff, verified) —
actions/artifacts?name=nightly-size-historynow returnstotal_count: 0, andsh/size/nightly.shtherefore passes no--history, so the next Nightly writes a one-row history as described. - Rename coverage checked —
libmoq.ymluploadslibmoq-${{ matrix.target }}andsh/size/release.pycollectslibmoq-*, matching the post-#8941 upload names.
⚠️ The restart drops the moq-c-generated-* series, which is still a shipping artifact
Last night's report (run 44127032469, bench-size artifact) carries 8 C keys: four size/release/moq-c-<target>/… and four size/release/moq-c-generated-<target>/…. The second four were only ever collected because moq-c-* matched them, and no pattern in ARTIFACTS matches them now, while release-c.yml still publishes the c/moq package on c-v* tags. Restarting the history is what makes that loss unobservable: compare() refuses removed keys, but only keys the retained history knows about.
Technical details
# Generated C package's size series disappears with the restart
## Affected sites
- `sh/size/release.py:13` — `ARTIFACTS` has no pattern matching `moq-c-generated-*`; `libmoq-*` replaced the `moq-c-*` glob that used to match both the hand-written and generated uploads.
- `.github/workflows/release-c.yml:124` — still uploads `moq-c-generated-${{ matrix.target }}`, and its `release` job publishes those archives on `c-v*` tags.
- `.github/workflows/nightly.yml:778` — the `sizes` job downloads artifacts from `release-c` but does not list it in `needs`.
- `sh/size/report.py:40` — the "artifacts missing or renamed" refusal only compares against keys the history contains; with an empty history it cannot report a dropped series.
## Required outcome
- Either the four `moq-c-generated-<target>` archives come back under comparison, or the PR records that the generated package is deliberately no longer size-tracked (including that it still ships).
- The choice must be made before the fresh history is written, because a pattern added after tonight's run starts the series from that later night.
## Suggested approach (optional)
- Add `"moq-c-generated-*"` to `ARTIFACTS` so the first fresh report records it alongside `libmoq-*`; `sizes()` already keys on the artifact directory, so there is no duplicate-key clash with `libmoq-*`.
- Adding `release-c` to the `sizes` job's `needs` would remove the reliance on that job happening to finish before the download, which currently works only by timing.
## Open questions for the human (optional)
- Is dropping the generated package's measurement intended, given `quest/m2/README.md` keeps "the generated C line" for after the cut?
deepseek-v4.1-flash | 𝕏

Restarts Nightly's size history now that moq-dev/moq#8941 renamed the hand-written C archives from
moq-c-<target>tolibmoq-<target>and stopped matchingmoq-c-generated-<target>. Finishesquest/m2/libmoq-size-history.md.Changes
nightly-size-historyartifact (id 14356087495, from Nightly run 44127032469 at cd9a8e9, which predates feat(c): the hand-written C API ships as libmoq, its final line #8941's merge), with the command insh/size/README.md. Zero such artifacts remain, so tonight's Nightly reports without--historyand starts one fresh history.The restart drops every series' 30-day baseline: for the next 30 days each night compares only against the previous night.
Decisions
Collect and compare sizesstep fails, the cause is something else, not the rename.Validation
history.jsonkeys namerelease/moq-c-<target>/…andrelease/moq-c-generated-<target>/….sizes.jsoninto the post-feat(c): the hand-written C API ships as libmoq, its final line #8941 shape (moq-c-*becamelibmoq-*,moq-c-generated-*dropped) and ransh/size/report.pyon it:--historyset to the retained history: exit 1,artifacts missing or renamed: release/moq-c-…(all 8 old keys), which is the failure the quest predicted.release/libmoq-<target>/…keys recorded.gh api …/actions/artifacts?name=nightly-size-historynow returnstotal_count: 0.libmoq.ymluploadslibmoq-${{ matrix.target }}andsh/size/release.pycollectslibmoq-*.Collect and compare sizes.Impact
No public API or wire change. CI state only: Nightly's size baseline restarts.
Caused by
Follow-ups
None.
Review
Skipped on 6ffcc68: the diff only deletes the finished quest file, and the work itself (deleting one CI artifact) has no code to review; its evidence is under Validation.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm B)
(Written by Opus 5.5)