Repository navigation
quest: moq-c-rate-thread is done on main by #8964 - #9062
Conversation
Quest-Claim: e1c18df230a016fa
A follower retuning an encoder blocks on the codec and on the encoder lock a caller holds for a whole encode. On the shared current-thread runtime that stalled every session's I/O, timers, and callbacks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he caller's thread The follower task this branch moved off the runtime no longer exists, so take main's libmoq and drop the now-unused Background::thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — the quest's goal already holds on main after #8964, so deleting it is correct. I confirmed follow_reservation, spawn_follow, and Background::thread no longer exist in rs/, and rs/moq-video/src/encode/producer.rs:280 calls self.follow().await as the PR describes.
Reviewed changes
- Quest file removed — deletes
quest/m1/precut-fixes/moq-c-rate-thread.md, the only file changed.
claude-sonnet-5-5 | 𝕏

Summary
This PR now only deletes the quest
quest/m1/precut-fixes/moq-c-rate-thread.md, becausemainalready meets its goal.The quest: libmoq's video rate follower (
follow_reservation) ran as a task on the shared current-threadRUNTIMEand blocked it on the encoder lock and on codec round trips. Its retunes, rung flushes, and encoder reopens therefore stalled every session's I/O, timers, and callbacks.moq-dev/moq#8964 landed on
mainwhile this PR was open. It removed libmoq's follower task entirely:moq_video::encode::Producer::writenow applies the grant itself, before each encode (self.follow().await,rs/moq-video/src/encode/producer.rs:280). libmoq calls that frommoq_encode_video_frameon the C caller's thread throughpollster. Nothing rate-related is spawned onRUNTIMEanymore. A retune now stalls only that caller's encode, which is what the quest's Goal asked for.This branch first fixed the old code by moving the follower onto its own
libmoq-ratethread through a newffi::Background::thread(head827fc19d3d, reviewed 9/10 by Codex with no findings). After #8964 that code had nothing left to apply to. The merge ofmain(head3c7f9e13b7) takes main's libmoq unchanged and drops the unused helper.Decisions
For review:
main(see Validation), and its Plan's mechanism (a follower task, moq-ffi'sspawn_follow) no longer exists in either crate.mainnothing on the runtime takes the encoder lock, so the test would only pin an absence.Validation
encode_video_follower_never_stalls_the_runtime, which goes through the C API: it publishes a video encoder that follows an allocator, holds its encoder lock as a caller's encode does, moves the bandwidth estimate, and spawns a probe task onRUNTIME.the runtime stalled behind the rate follower: Timeout). This reproduces the quest's finding.main's libmoq, added temporarily and then removed:cargo nextest run -p libmoq --lib -E 'test(encode_video_follower_never_stalls_the_runtime)'passed in 0.020 s.quest check --base origin/main: ok. The diff frommainis the quest file only.Impact
Public API: none. Wire: none. This deletes a quest file only.
Caused by
No code change, so no culprit to name. For the record, the quest's original culprit was moq-dev/moq#6781, and moq-dev/moq#8964 removed that defect.
Follow-ups
None.
Review
827fc19d3dhad one Codex round (gpt-6.1-sol, medium): 9/10, no findings.Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)