Skip to content

docs(quest): moq's FFI wheels and XCFramework ship from rust2's release template - #9036

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/ffi-release-template
Nov 17, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/ffi-release-template

Conversation

@kixelated

@kixelated kixelated commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the moq follow-up of kixel-ai/rust2#852, which added rust2's shared binding release builder and template, as an edit to the exporter switch (quest/m3/ffi-exporter.md).

Summary

At the switch, moq-ffi's Python wheels and Swift XCFramework come from rust2's credential-free bindings.yml builder and a release.yml that package.py init writes into moq, published on the moq-ffi-v* tags moq already cuts. release-py-ffi.yml, release-swift-ffi.yml, sh/swift/{package,verify,publish}-ffi.sh, and the maturin config go. The hand-written wrappers' packaging stays and repoints at the new FFI package.

Structure: an edit to the switch, not a new quest. The switch retires the UniFFI output today's FFI release workflows package, so the two land together. The switch stays [L] in m3: rust2's builder carries the packaging, leaving moq to run init, register the publisher, and delete.

Overlap searched: moq's quest tree, its git history, and every open PR's quest files. moq-dev/moq#8941 (libmoq's C release) touches swift/ffi/Package.swift.template but not the Python or Swift FFI release.

Decisions

Settled with the maintainer on 2026-11-17, in kixel-ai/rust2#852's merge pick and this plan's interview:

  • Keep the follow-up: ✅ keep (rejected: drop).
  • Goal: ✅ as recorded in the quest's "Python and Swift FFI releases" bullet, with the wrappers' packaging and Kotlin, Dart, and C++ untouched (rejected: adjust).
  • Swift FFI packaging scripts: ✅ delete the ones the template replaces (rejected: keep them).
  • Swift names: ✅ accept MoqFfi, listed in MIGRATE.md (rejected: keep MoqFFI).
  • Mirror credentials: ✅ a new swift-mirror environment with moq-bot's App credentials, deployable only from moq-ffi-v* tags. The maintainer left the choice to the planner; this one keeps moq's release.yml exactly what init writes (rejected: hand-edit moq's copy to bot; rename the template's environment in rust2).
  • Floors (decided on feat(ffi): release templates with shared binding package builders kixel-ai/rust2#852 earlier the same day): ✅ Python 3.11, macOS 13, Swift 6.2, no sdist.

Validation

Quest text only: quest check passes.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 3d042ee

  • Base: origin/main at 2caa851

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1eb6f-2cb8-74c2-b941-e945a5073911, round 1

  • Score: 10/10, The planning-only change records future release-packaging decisions without changing executable code, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

…se template at the switch

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 17, 2026 21:35
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 05075a6e-74c0-405f-9cd6-c67603348661
Commits

Reviewing files that changed from the base of the PR and between 2caa851 and 3d042ee.

Files selected for processing: 1

  • quest/m3/ffi-exporter.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 17, 2026 21:35

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. It folds the FFI release change into the existing exporter switch quest, so it doesn't add a new quest.

Reviewed changes

The one changed file is quest/m3/ffi-exporter.md.

  • Python and Swift FFI releases bullet: moq-ffi's wheels and XCFramework come from rust2's shared builder and release.yml. The old workflows, scripts and maturin config are deleted, and the wrapper packaging stays.
  • Decisions: the floors, the script deletion, the MoqFfi rename and the swift-mirror environment, each with its rejected alternatives.
  • Public API note: the breaking changes (Swift module name, Python 3.11, macOS 13, Swift 6.2, no sdist) are added to the list that goes in the PR.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 2a280d7 Nov 17, 2026
7 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/ffi-release-template branch November 17, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant