Repository navigation
docs(quest): moq's FFI wheels and XCFramework ship from rust2's release template - #9036
Merged
Merged
Conversation
…se template at the switch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 17, 2026 21:35
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 17, 2026 21:35
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It folds the FFI release change into the existing exporter switch quest, so it doesn't add a new quest.
Reviewed changes
The one changed file is quest/m3/ffi-exporter.md.
- Python and Swift FFI releases bullet: moq-ffi's wheels and XCFramework come from rust2's shared builder and
release.yml. The old workflows, scripts and maturin config are deleted, and the wrapper packaging stays. - Decisions: the floors, the script deletion, the
MoqFfirename and theswift-mirrorenvironment, each with its rejected alternatives. - Public API note: the breaking changes (Swift module name, Python 3.11, macOS 13, Swift 6.2, no sdist) are added to the list that goes in the PR.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Plans the moq follow-up of kixel-ai/rust2#852, which added rust2's shared binding release builder and template, as an edit to the exporter switch (quest/m3/ffi-exporter.md).
Summary
At the switch, moq-ffi's Python wheels and Swift XCFramework come from rust2's credential-free
bindings.ymlbuilder and arelease.ymlthatpackage.py initwrites into moq, published on themoq-ffi-v*tags moq already cuts.release-py-ffi.yml,release-swift-ffi.yml,sh/swift/{package,verify,publish}-ffi.sh, and the maturin config go. The hand-written wrappers' packaging stays and repoints at the new FFI package.Structure: an edit to the switch, not a new quest. The switch retires the UniFFI output today's FFI release workflows package, so the two land together. The switch stays [L] in m3: rust2's builder carries the packaging, leaving moq to run
init, register the publisher, and delete.Overlap searched: moq's quest tree, its git history, and every open PR's quest files. moq-dev/moq#8941 (libmoq's C release) touches
swift/ffi/Package.swift.templatebut not the Python or Swift FFI release.Decisions
Settled with the maintainer on 2026-11-17, in kixel-ai/rust2#852's merge pick and this plan's interview:
MoqFfi, listed inMIGRATE.md(rejected: keepMoqFFI).swift-mirrorenvironment with moq-bot's App credentials, deployable only frommoq-ffi-v*tags. The maintainer left the choice to the planner; this one keeps moq'srelease.ymlexactly whatinitwrites (rejected: hand-edit moq's copy tobot; rename the template's environment in rust2).Validation
Quest text only:
quest checkpasses.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 3d042ee
Base: origin/main at 2caa851
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1eb6f-2cb8-74c2-b941-e945a5073911, round 1Score: 10/10,
The planning-only change records future release-packaging decisions without changing executable code, and no actionable defects were found.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none