Skip to content

moq-net's last pub items with a single container-reader caller go private - #9030

Merged
kixelated merged 3 commits into
mainfrom
quest/m2/unused-api/net
Nov 17, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m2/unused-api/net

Conversation

@kixelated

@kixelated kixelated commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Claims quest/m2/unused-api/net.md, and lands only a rewrite of it: no code changes.

Reading the code showed the quest's plan was far larger than [S] and changes behavior. The maintainer picked option B, so the quest is now [L], requires the hole wait quest (#8984), and its Plan is: design the container reader's hole policy on track::Ordered first (including whether Ordered takes the wall-time wait Delay::min now means), then make the methods crate-private. The findings (every caller of is_skipped and with_range, and why Ordered can't carry the reader's hole rules today) are recorded in the quest's Plan.

Decisions

  • ✅ B: rewrite as [L] with quest/m2/delay-hole-wait.md as Required, Plan led by the Ordered hole-policy design (rejected: A, delete the quest and keep the methods public; C, only make with_range crate-private). Maintainer, decision comment.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, default effort (iterate, XS, arm B)

Review

Rewritten by quest review after each round.

  • Head: 8653f53

  • Base: origin/main at 6b4ad91

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1eb54-c89b-7e03-9b01-582cf229203d, round 1

  • Score: 10/10, The plan records supported caller inventory, dependencies, and reader migration decisions without changing runtime behavior.

  • Rounds: 5; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1eb54-c89b-7df0-9100-f19b31ce9529, round 1

  • Score: 9/10, The change only revises a quest plan to document broader migration scope and prerequisite hole-wait work, with no executable behavior changes or actionable findings.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Quest-Claim: 2325b8fb360f8ef3
@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision (2026-11-17, asked in the /quest-run m0/m1/m2 coordinating session):

✅ B: rewrite quest/m2/unused-api/net.md as [L], with quest/m2/delay-hole-wait.md (moq-dev/moq#8984) as Required. Its Plan becomes: design the container reader's hole policy on track::Ordered first, including whether Ordered takes the wall-time wait Delay::min now means, then make next_in_range, is_skipped, poll_start, and if possible with_range crate-private (rejected: A, delete the quest and keep the methods public; C, shrink it to with_range alone). This PR lands only that rewrite and releases the claim.

(Written by Claude Opus 5.5 with high)

@kixelated
kixelated marked this pull request as ready for review November 17, 2026 21:06
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 30cb26c7-5959-4438-b9b4-0e807c08aedf
Commits

Reviewing files that changed from the base of the PR and between 6b4ad91 and 8653f53.

Files selected for processing: 1

  • quest/m2/unused-api/net.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. The PR only rewrites the quest plan, and the plan now matches the scope the code showed.

Reviewed changes

  • Quest resized: quest/m2/unused-api/net.md goes from [S] to [L] and records the findings on the container reader's hole rules versus track::Ordered.
  • Dependency added: the new Required link to quest/m2/delay-hole-wait.md resolves to a file that exists.
  • Steps rewritten: they start with the Ordered hole-policy design, then move the reader and callers, then make the methods crate-private.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 2caa851 Nov 17, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m2/unused-api/net branch November 17, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant