Repository navigation
Conversation
A session its peer closes before moq-ffi's 1s healthy bar now ends the client rather than redialing (#8817), so the OBS tests that dropped a freshly live session saw the stream fail instead of reconnect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the single commit adding a healthy-bar wait to the OBS reconnect tests.
OutlastHealthy()helper: a 1 s real-clock sleep inmoq-test-relay.h.<thread>and<chrono>are already included.- Output and source tests:
moq-output-test.cpp(3 sites) andmoq-source-test.cpp(1 site) call it after the session is seen live and before the drop, so the drop lands past moq-ffi's healthy bar and the client redials.
claude-sonnet-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 2e3dba76b6599eeccbf809f7c1a9b9ff687c2bea
No blocker. Each hard drop waits after the client has shown a live session (or received both video and audio), rather than sleeping from the dial or server accept. Rust's reconnect policy uses tenure >= healthy, so a one-second wait from those observations is sufficient at the current default. This preserves the reconnect assertions without adding a public FFI knob just for tests. As a separate CI follow-up, consider having reconnect-policy changes trigger the OBS test lane, so the next cross-layer mismatch is caught before nightly. Static review; I did not rerun OBS or TSan.
|
Maintainer decision (2026-11-17): ✅ redesign the healthy signal so a session counts as established on an explicit signal instead of 1 s of uptime (rejected: keep the real 1 s waits in the OBS tests; expose (Written by Claude Opus 5.5) |

Problem
Nightly OBS and OBS TSan fail in
test/moq-output-test.cpp(lines 526, 999-1003, 1020-1021): after the test relay drops a session, the output never reconnects and OBS gets a stop signal.Since moq-dev/moq#8817, a session its peer closes before the 1 s healthy bar ends the client instead of redialing, the way a refused session does. The OBS tests dropped the session as soon as it went live, so they now hit the fail-fast path. The tests are out of date, not the product: a relay that closes a session within a second of accepting it looks like a refusal, and OBS still gets
OBS_OUTPUT_DISCONNECTED, which lets its own reconnect retry.Approach
A new
OutlastHealthy()helper inmoq-test-relay.hwaits out moq-ffi's healthy bar after the test has seen the session go live. Because the client went live before the test observed it, waiting 1 s from that point always gets past the bar. The three output-test drops and the source test's "follows a session reconnect" call it before closing the session. moq-ffi doesn't let a caller set the healthy bar, so the wait has to be on the real clock. #8817 already did the same in the Go, Python, and moq-c tests and missed OBS, because the PR gate's OBS filter doesn't watchrs/moq-net.Impact
moq-output-testtakes about 3 s longer, andmoq-source-testabout 1 s longer. Both run nightly, and injust obs ciwhen OBS paths change.Alternatives
healthyinMoqBackoffso the test could set a 10 ms bar. That adds API to every binding just for this test, and the test would still have to wait out the bar.Follow-ups
moq-source-test.cpp:1903"destroy mid-stream". It is not addressed here.Caused by
Validation
nix develop -c bash sh/obs/unit.sh plainreproduced the failures at lines 526 and 999-1003.sh/obs/unit.sh plainandsh/obs/test.sh(ThreadSanitizer, the same as nightly OBS TSan) both pass every test binary, includingmoq-source-test's "follows a session reconnect", which never ran before becauseunit.shstops at the first failing binary.just obs checkandjust cipass.Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 2e3dba7
Base: origin/main at bc66d3e
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1ea8e-5ae4-7c30-af1e-5200040c0099, round 1Score: 9/10,
The narrowly scoped waits match the reconnect policy by letting real-QUIC sessions reach the one-second healthy threshold; no actionable defects were found, but builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none