Skip to content

quest: browser audio takes its holes from the ordered reader - #8989

Merged
kixelated merged 1 commit into
mainfrom
quest/audio-hole-ordered
Nov 17, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/audio-hole-ordered

Conversation

@kixelated

@kixelated kixelated commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Rewrites quest/m2/audio-playout/browser-audio-hole-skip.md after a maintainer decision made during /quest-run. Browser audio will read its track through @moq/net's ordered reader. The reader's budget is the amount of audio the ring holds, and each Gap the reader reports is played as a hole. The audio container consumer then drops its own hole wait and stops taking playhead. Video keeps the playhead.

This replaces the quest's previous plan, which was to measure the playhead rule and then hand-write a wait in the container consumer.

The quest now includes mirroring Item/Gap in @moq/net. #8910's own follow-up list deferred that until a consumer needs it, and browser audio is that consumer. The quest waits on #8910 merging. quest/m2/delay-hole-wait.md's Related line was updated to match.

Decisions

  • ✅ The transport decides an audio hole, through an ordered reader whose budget is the ring's size (maintainer, 2026-11-16).
    • Rejected: measuring first, then keeping the playhead rule or a separate wait.
  • The budget belongs to the reader, not the subscription. The subscription keeps reaching the jitter estimator's 2 s ceiling, so late groups stay observable.

Validation

quest check passes. Documentation-only change.

🤖 Generated with Claude Code

(Written by Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: c52e9bc

  • Base: origin/main at 60dfbbf

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1e85c-c142-74b3-a37a-4ba9250a2440, round 1

  • Score: 10/10, The planning-only change consistently records the settled approach without modifying runtime behavior, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Maintainer decision during /quest-run: the transport decides an audio hole
through an ordered reader whose budget is the ring's size, replacing the
measure-the-playhead plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full diff, two quest docs, with no code touched.

  • Quest rewrite: browser-audio-hole-skip.md now plans browser audio reading through @moq/net's ordered reader, with a ring-sized budget and Gap played as the hole. It also adds a Waiting entry on #8910.
  • Related link: delay-hole-wait.md points at the retitled quest.

The linked quest/m2/unused-api/net.md exists.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI) · c52e9bc8bfada1c90cbb81fdcbeed5840cff877a

Please explicitly preserve pre-skip jitter observations in the plan. The container's frame ingress currently feeds the jitter estimator before gap handling or age filtering (js/hang/src/container/consumer.ts, at #jitter.observe). Once audio reads through a narrow ordered reader, a group may still reach the broad subscription but be skipped before reaching the container. Keeping the two budgets separate on paper is not enough if the estimator sees only ordered output: it can stop learning exactly when arrivals get late. Preserve a pre-skip observation path with original arrival times. A deterministic replay case should prove that a group outside the ring budget still raises the estimate without being played.

The transport owning the hole decision looks reasonable. Static review of the plan; no tests run.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The browser audio proposal now specifies using @moq/net’s ordered reader to report audio holes as Gaps. It describes a reader budget tied to ring-held delay and removes the audio consumer’s separate hole wait and playhead; video retains the playhead. The proposal keeps Chromium quality and Firefox resume checks and identifies the merge that defines the Item and Gap behavior. A related delay quest description now reflects this plan.

Merge Risk: Minimal · up to c52e9

This documentation-only change updates the browser audio hole-handling plan and its related link. It cannot affect runtime behavior, and no remaining merge-blocking issues were found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: browser audio now takes its hole signals from the ordered reader in @moq/net. The raw summary confirms the PR rewrites the browser-audio hole-skip plan to use the orde…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the PR rewrites quest/m2/audio-playout/browser-audio-hole-skip.md so browser audio reads through @moq/net's ordered reader, with the budget set to the ring's held amount and eac…
Full details: Title check

Explanation

The title names the main change: browser audio now takes its hole signals from the ordered reader in @moq/net. The raw summary confirms the PR rewrites the browser-audio hole-skip plan to use the ordered reader's Gap items as holes and removes the audio container consumer's own hole wait and playhead use.

Full details: Description check

Explanation

The description states the PR rewrites quest/m2/audio-playout/browser-audio-hole-skip.md so browser audio reads through @moq/net's ordered reader, with the budget set to the ring's held amount and each Gap played as a hole. It also says the audio container consumer drops its hole wait and playhead use, while video keeps the playhead. It notes the related Related line update in quest/m2/delay-hole-wait.md. This matches the raw summary of changed files, so the description is on topic and specific.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5592202e-ec4e-4695-8214-11d9ca7e00a0
Commits

Reviewing files that changed from the base of the PR and between 60dfbbf and c52e9bc.

Files selected for processing: 2

  • quest/m2/audio-playout/browser-audio-hole-skip.md
  • quest/m2/delay-hole-wait.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 989f3a8 Nov 17, 2026
8 checks passed
@kixelated
kixelated deleted the quest/audio-hole-ordered branch November 17, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant