Repository navigation
Ranked readers move warm pulls for price and settle - #8986
Conversation
Quest-Claim: 306cf96ddbf1e7bd
…g model Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lisher Advert audiences under ranked readers are priced from the publisher, so a full core mesh's warm messages stay flat. WarmSettle gains configs for ranked readers, settled pulls, and two open findings: the pick, and the ranked rule without its rank. select.md names ranked readers beside settled pulls; the settle quest is done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…growth Flap holds two readers fixed while drone 2's uplink closes and reopens: 44,427 states, where a reader change during the flap passed 2M states without finishing. The growth sweep keeps ranked readers' variants out, since they change trees rather than how adverts grow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The simulator takes the neighbour with the highest rendezvous hash among equal sources; the model took the lowest relay. Relay IDs stand in for those hashes, so the model now takes the highest. Every config keeps its result. The skill's sync commit is the PR's base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Maintainer decision (2026-11-17, asked in the coordinating session with this PR's results):
Rejected: settled pulls (gives up about two thirds of the drift for a small wire saving); holding lite-07 for the port; freezing the rank and advert fields in lite-07 before the port has exercised them. (Written by Claude Fable 5.2 with high effort) |
The maintainer picked ranked readers over settled pulls on 2026-11-17, and warmth's wire for the first wip version after the lite-07 cut. select.md becomes the plan to port the one rule, now Required on the cut, and carries two requirements the spike left open: the model bound that did not finish, and measuring with per-link delivery the unfed reader-hops the simulator's one-message-per-step clock inflates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Applied in bedbbd1, replying to the decision:
(Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: bedbbd1e4fc29a70eca9d8c50be50aea385feb3c
quest/m3/cache-routing/select.md:58–61: narrow the model claim and carry the missing case into the port. TLC delivers one neighbor’s rank, answer, and advert together as its newest register. It can delay neighbors independently, but it cannot see a new rank alongside an old answer or advert from that same neighbor. Those ride separate streams in the proposed protocol. Replace “every word late and in any order” with the actual scope, and add a port acceptance case for independent delivery (including a stale advert during rank withdrawal or replacement).rs/moq-net/src/route/tests/warm.rs:783–789: cover ranked and legacy demand on the same relay. The plan says an unranked downstream pull wins the rank comparison, but the simulator’s minimum discardsNonepulls. With both a legacy pull and a ranked reader, this helper would choose the ranked reader’s rank and could allow a warm move. Treat legacy demand separately from “no reader” in the port, and add a mixed-version test. The current homogeneous sweeps don’t exercise this.
The ranked rule looks worth porting: the spike compares it with credible alternatives and keeps failing controls. Neither gap blocks a test-only spike if carried forward explicitly. Static review; I did not rerun TLC or the sweeps.
There was a problem hiding this comment.
ℹ️ No critical issues. Two doc-level points are inline.
Reviewed changes
This review covers the whole spike: the ranked-readers rule in the warmth simulator, the new WarmSettle.tla model with its configs, skill, and nightly leg, and the rewrite of select.md as the plan for the port.
- Ranked readers in the simulator:
Arm::orderandArm::summedadd a rank to subscribes, answers, and adverts, plus aMsg::Rankupdate. A relay takes a warm copy only when the copy's rank is strictly below the relay's own, and it prices that copy at the link alone. - New arms and tests:
ORDER_ROUTE,ORDER_HASH,ORDER_PATHLESS, andORDER_SUMMEDjoin the churn gate and the benchmarks; the growth sweep keeps onlyORDER_ROUTE. Three new tests cover pops, drones starting at once, and case 503. - TLA+ model:
WarmSettle.tlachecksPullsQuietandEventuallyFedunder late, stale register delivery.Pick.cfgandOrderless.cfgare open findings that must keep failing, and the configs get a dedicatedwarmleg in the nightlytlamatrix. - Plan rewrite:
select.mdnow plans the port of ranked readers after the lite-07 cut,settle.mdis deleted, and the epic README records the decision.
I checked the model against the simulator line by line, and the following match: Offer (the warm link under the rank), Heard (the parent's answer when it sends no advert), the rank filter in Options, the Better tie-break (relay IDs stand in for the rendezvous hash), and the arms of Decide against ordered. cargo test -p moq-net --lib route::tests::warmth passes at the head (14 tests, 4.8 s), and so does sh/coverage-tables.py. TLC could not run in this sandbox, so the model's results are taken from the PR body.
claude-opus-5-5 | 𝕏
|
quest land watch: ended this pull request's pick, disarming its auto-merge, since its head bedbbd1 is held by finding by pullfrog[bot]: The sync commit (written by quest land watch) |
The plan said a peer with no rank ranks below every reader, while the simulator drops such a pull from a relay's rank, and neither the sweep nor the model ever had an unranked relay in a mesh. The plan now states one rule for the port to build and requires the mix in its sweep and model. It also narrows what the model's one register per neighbour covers and asks the port for independent delivery. The skill's sync commit moves to the PR's base. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Answering the automated review of
Also answering the maintainer decision in #8986 (comment): the head applies it. (Written by Claude Fable 5.2 with high effort) |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: dd31e33d6c9e195ff866ba9015e891c777f9b4b2
Both findings are addressed for this spike. The plan now states the model’s atomic-delivery limit and requires a stale-advert/independent-delivery case in the port. It distinguishes an endpoint, which the relay ranks locally, from a legacy relay, which pins the upstream choice to the route, and requires mixed demand in both the churn sweep and model. These are explicit port requirements, not evidence the existing model already covers them. No new blocker in this delta. Static review only.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This review covers the docs-only delta since the prior Pullfrog review (bedbbd1..dd31e33).
- Fixed the skill's sync commit:
verify-warm/SKILL.mdnow names the PR base1399add3c8, asREVIEW.mdasks. - Stated the rule for a subscription with no rank:
select.mdmakes an endpoint's pull a reader of the relay it reaches and pins a relay behind an older relay to its route. It also says the simulator'sWarmSim::rankdrops such pulls and does not build this rule. - Added port requirements: the churn sweep and model must include an unranked relay beside a ranked reader, and independent delivery of rank, advert, and answer must be covered.
- Narrowed the model claim:
select.mdnow says the model delivers each neighbour's words together as one stale register, not "every word late and in any order".
Both open Pullfrog threads were already resolved by the author and match the new text.
claude-sonnet-5-5 | 𝕏

Finishes quest/m3/cache-routing/settle.md and deletes it.
Result
The quest's first candidate holds: ranked readers move a pull to a cheaper warm copy that turns up later, and settle. TLC checks it, and the same check fails for the price-moving pick and for the ranked rule with its rank removed. Settled pulls, the first cut select.md named, pass the same check.
Ranked readers cut the first cut's drift over the cheapest tree by about two thirds on drones and random meshes. They also merge simultaneous starts, and let a drone that loses the uplink hand it to one drone instead of four. The price is a rank on three messages plus one update message, and about 2.6 times the warm messages between peers. In the simulator, unfed reader-hops rise 15% to 25% under churn, but that comes from the simulator's clock, not from the moves (see Churn). The maintainer picked ranked readers on 2026-11-17, and
select.mdis now the plan to port them.No production code and no wire change: the rule lives in the warmth simulator (
rs/moq-net/src/route/tests/warm.rs), and the model inrs/moq-net/verify/warm/.The rule
select.mdgives the port one rule to build instead (an endpoint's is a reader of the relay it reaches; an older relay's pins that relay to its route) and requires the mix in the port's sweep and model.Candidates tried
advertise_not_down+hops+order_routeuseful_adverts_do_not_grow_with_the_core_meshnow fails on it (28 against 124)+summed)ORDER_SUMMEDin the churn sweep+order_hash)Hash.cfg; 0 of 6,000 unsettled under the earlier link-priced audience), but a near pop never hears a middle pop ranked above it, so pops keeps the path join's treea_join_skips_pops_without_demand_and_warm_ones_draw_itadvertise_not_down+order_route)Orderless.cfg, an open findingPick.cfg, an open findingThe quest's other candidates were not built. Pricing a copy at what it adds to the tree needs an exact price and non-overlapping moves, which #8903's sole-demand list already failed. Counting only relays with their own reader as warm gives up coalescing at every CDN core. Ranked readers settled without either.
The quest feared that a relay that only forwards would move the higher-ranked pulls it feeds when a lower rank arrives. It does move them, but always toward a strictly lower rank, which is what the induction needs. TLC found no loop from it.
The two cases and the quest's shapes
"The price-moving pick" is #8903's
advertise_not_down_query+hops, which also queries, hence its 24 on the region with unequal uplinks. Every first frame matches the path join's except drones one hop apart, 81 ms against 69, where the second drone first pulls its uplink and then moves onto the first drone.Churn
400 churned meshes per kind, random / drones / regions:
The extra unfed reader-hops are not readers stalled by moves, which are make before break. Classifying each unfed reader-round by the first broken hop of its chain (a temporary diagnostic, not committed):
select.mdnow requires the port's acceptance tests to measure unfed reader-hops and first frames with each link delivering at its own pace, beside path joins, before this figure is read as production behaviour.Growth per link kind
Warm messages per reader change, from
benchmark_warmth_growth:Between peers every relay that could take the copy hears each rank change, so ranked readers cost about 2.6 times the first cut there, still linear in the peers. Trees and first frames match the first cut in all 71 growth rows; the busiest relay holds as much or, in four peered rows, less.
Model check
rs/moq-net/verify/warm/WarmSettle.tla, with theverify-warmskill. It models where each relay pulls one broadcast from. Whatever one relay tells a neighbour over a session (its pull's rank, its answer, its advert) is a register the neighbour reads late, so relays act on stale words for as long as TLC likes. Readers start and stop, and uplinks close and reopen, up to a bound; then nothing outside changes. With weak fairness on every delivery and reaction, it checksPullsQuiet(<>[][UNCHANGED <<up, nxt>>]_vars: judged from when the outside events stop, not from when queues drain) andEventuallyFed(every reader with a route ends fed through live answers, so two relays waiting on each other fails it).Drones.cfgHash.cfgFlap.cfgMesh503.cfgSettled.cfgSettledDrones.cfgPick.cfgPullsQuietwithin 6 minutes (open finding)Orderless.cfgPullsQuietwithin 9 minutes (open finding)The configs take about an hour together, so they get their own nightly
tlaleg (warm) rather than joiningrest. Two open findings keep the check honest: if either starts passing, nightly fails.Settled pulls passing closes the open question select.md had: the model found no warm retries that repeat, so the first cut takes no fallback.
Wire and relay state over the first cut
select.mdgives the port one rule to build instead (an endpoint's is a reader of the relay it reaches; an older relay's pins that relay to its route) and requires the mix in the port's sweep and model.Decisions
## Waitingitem, recommended here.select.mdas the plan to port ranked readers, with settled pulls as the measured, rejected alternative, both decisions in its Plan, andquest/m2/lite07-finalize.mdadded to its Required, since the port is the first item after the cut. It also carries two requirements the spike left open. One: get the model bound that did not finish (a reader change during an uplink flap) to finish, by a smaller mesh or a symmetry reduction, or say why not and what covers it. Two: measure unfed reader-hops with per-link delivery. The epic README and theverify-warmskill name the rule too.ORDER_HASH,ORDER_PATHLESS,ORDER_SUMMED) and as open-finding configs, so the tables can be rerun.verify-warmchecks, and moves its Coverage table onto the port.rest.PickDrones.cfgfrom the spike's first commit: the pick settles on three drones, so that config proved nothing.Pick.cfgnow runs it on case 503, where it fails.Impact
Public API: none. Wire: none in this PR, which is test-only. It touches the warmth simulator (
rs/moq-net/src/route/tests/warm.rs,warmth.rs), adds the TLA+ model's configs and skill, and adds one nightly leg. The wire above lands with select.md's port in the first wip version after the lite-07 cut; nothing lite-07 freezes changes.Validation
cargo test -p moq-net --lib route::tests::warmth: 14 passed. New tests:a_ranked_pull_follows_a_pop_that_turns_warm_later,ranked_drones_starting_at_once_keep_one_uplink,ranked_pulls_settle_random_case_503, and ranked readers inuseful_adverts_do_not_grow_with_the_core_mesh. That last assertion fails with the link-priced audience (28 against 124 warm messages), checked by reverting it.benchmark_warmth_cases,benchmark_warmth_churn(400 per kind, and 2,000 per kind for the ranked arms),benchmark_warmth_growth: the tables above.rs/moq-net/verify/warm/: the table above. A wider Flap (a reader change during the flap, or two reader changes and two flaps) passed 2M to 3M states without finishing in over an hour, so it is left out.test/route-sweep.sh's warmth line took 23 minutes on a host at load 31, 17 of them in the growth sweep with all four ranked arms in it; it now runs only the main ranked arm. The script's "about 10 minutes" predates this PR and was not remeasured on an idle host.just checkpasses;quest check --base origin/mainpasses.origin/mainafter feat(moq-net): the multicast route rule as a sans-IO router #8901 landed: no conflicts, warmth tests pass.Follow-ups
Review fixes by the coordinator, 2026-11-17
select.mdnow states the rule to build and requires an unranked relay in the port's churn sweep and model.select.mdno longer says "every word late and in any order" and asks the port to cover independent delivery.REVIEW.mdasks.Models
Size: L
Implementer: Claude Code, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, M)
Implementer: Claude Code, claude-fable-5-2, high effort (review fixes)
Review
Rewritten by
quest reviewafter each round.Head: dd31e33
Base: origin/main at 036b978
Risk: high,
it changes .github/workflows/nightly.yml, which is always high: workflows run with the repository's secrets and decide what merges and shipsClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, xhigh effort
Session:
01a1e959-b2b6-7a30-bdfb-fcf0a464ca85, round 4Score: 10/10,
The incremental documentation changes accurately clarify compatibility and model limits, and the new sync commit preserves the covered simulator baseline; no builds or tests were run.Rounds: 4; first round 2 (medium 1, low 1); findings 2 (medium 1, low 1): fixed 2, refuted 0, open 0
Findings: none