Repository navigation
test(moq-net): the resume model drops a group its route held only a fetched tail of - #8969
Conversation
…etched tail of A route that gave up a group it held only through a fill aborted the fill and recorded nothing on its live feed, so an ordered reader on that route rightly waited for the group forever while the model owed what followed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed a test-only fix to the resume model's Op::GiveUp handling, plus its regression case.
Op::GiveUpdrops fetched-only groups from the live feed: every held part's writer is still aborted.drop_groupsis now also called whenever no live (from == 0) part exists, so a route that held only a fill's tail tells its ordered cursor that the group is gone. Before this change, the ordered reader waited for that group forever. This matcheswrite(), which counts only afrom == 0part as the live feed's group, andfill(), which records fetched tails withfrom > 0.- New
regressions()case: replays the shrunk counterexample from Nightly seed762648400.
claude-opus-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 329c010da389bf2147df601d215266d4e0e16606. The regression fixture is useful, but P2: frame zero is not proof a part came from the live feed (resume_model.rs:406). fill() stores the request's frame_start directly; a fetch can start at 0 and still hold only an incomplete group. An on-demand FETCH with no live slot is inserted as invisible to the live feed, regardless of its start. If GiveUp aborts that copy, the new predicate still suppresses the live-feed drop and an ordered reader can stay parked. Track live-vs-fetch provenance explicitly on Part, and add a case that gives up an incomplete fetch from frame 0 with the next group already owed. Static review only; I did not rerun the model.

Problem
Nightly's
Tests (test resume-model)fails (job,MOQ_RESUME_SEED=762648400): an ordered reader is handed groups 0–4 and then never 6–11.The model was wrong, not resume. Reader 1 read group 5's first frame from the replaced route (slot 0). Its recovery then fetched the rest (from frame 1) on the serving route (slot 1), so slot 1's cache held a fetched tail of group 5. When slot 1 then gave up group 5,
Op::GiveUpsaw a held group and only aborted that fetch. Slot 1's live feed never carried group 5 and never reported it dropped. A fetch-only copy that fails "holds nothing open, since the feed never promised it" (Slot::is_settled), so the ordered cursor on slot 1 rightly waited for a live group 5. With the Hour budget, it would wait for good. Meanwhile the model owed everything after it.Approach
Op::GiveUpaborts every held copy of the group, as before. It now also drops the group from the route's live feed unless a live (from == 0) copy exists. The shrunk counterexample joinsregressions.The JS model (
js/net/src/resume.model.test.ts) needs no change: itsfillcreates the whole group on the route's own track, so it has no fetch-only tail.The other model failure from yesterday's Nightly (
MOQ_RESUME_SEED=1648062584, reader 3 with range(3, 4)never ending) was already fixed by moq-dev/moq#8859 and is inregressions. Theroute-sweepfailure in the same Nightly (sweep_scoped_meshes_show_what_the_rule_says) was fixed by moq-dev/moq#8860.Impact
None: test-only.
Validation
i1 s1 5..6, accepted from frame 1) and thenGiveUphitting the held branch.readers_match_the_logical_trackpasses at both Nightly seeds (762648400, 1648062584) and eight fresh seeds (4096 cases each).just check: everything passes exceptmoq-relaybitrate_caps::uring::session_is_held_to_its_caps("io_uring worker setup failed"), which is a host limitation unrelated to this change.mainatMOQ_ROUTE_SCENARIOS=20000.Caused by
GiveUptreated a fetched tail as the live group, so it never dropped the group from the live feed (found by check).Models
Size: S
Implementer: Claude, claude-opus-5-5, unknown effort
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 329c010
Base: origin/main at 13e593c
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e569-ee03-7822-b48d-f0a5941dc240, round 1Score: 9/10,
The change correctly reports a live-feed drop when only fetched tails exist and adds a focused regression case; source review found no actionable defects, though tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none