Skip to content

chore(deny): ignore zbus 5's unmaintained crates and drop the stale rsa ignore - #8966

Merged
kixelated merged 1 commit into
mainfrom
fix/cargo-deny-advisories
Nov 16, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/cargo-deny-advisories

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the Nightly Audit job (run 43909101837, job 133445815782): cargo-deny reported 3 unmaintained errors and 1 stale-ignore warning.

  • RUSTSEC-2026-0370/0371/0372: zvariant, zbus_names, and zvariant_derive are now unmaintained because zbus 6 absorbed them. The only path in is moq-video's pipewire feature → ashpd 0.13 → zbus 5.
  • RUSTSEC-2023-0071 (rsa) no longer matches any crate, so its ignore is gone.

Why ignore instead of upgrading

ashpd 0.14 moves to zbus 6, and the upgrade itself is easy (5 small API renames, and it drops 13 crates). But moq-video pins ashpd 0.13 on purpose. zbus 6 sends its whole D-Bus handshake in one write. Inside a Flatpak, xdg-dbus-proxy before 0.1.6 drops a connection whose BEGIN arrives before its earlier answers have gone back. That breaks every portal call on Ubuntu 24.04 LTS, which ships 0.1.5 (noble 0.1.5-1ubuntu0.2 on Launchpad).

zbus 6.3.0 (2026-11-13) still does this, and has no opt-out: connection/handshake/client.rs send_commands. I tried the upgrade, and the guard test portal_handshake_waits_for_each_answer fails on it. So the ignores stay until the project drops 24.04 Flatpak support. The ashpd comment in rs/moq-video/Cargo.toml now says to remove them with the bump.

Validation

  • just audit (the recipe the Nightly job runs) on this branch: advisories ok: 0 errors, 0 warnings, exit 0.
  • Tried the ashpd 0.14 / zbus 6.3 upgrade: clippy passed, but cargo nextest run -p moq-video --features pipewire portal_handshake failed portal_handshake_waits_for_each_answer. Reverted.
  • rsa has no entry in Cargo.lock.

Caused by

Upstream RustSec advisories published after zbus 6.0, not #8891: ashpd 0.13 / zbus 5 has been in the tree since #2238. The rsa ignore went stale when #8250 removed rsa from the lockfile.

Public API / wire impact

None. Only the deny config and a comment change.

Models

  • Size: S
  • Implementer: Claude, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 0d13464

  • Base: origin/main at 13e593c

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e556-444d-7b13-88b8-4afa5a838478, round 1

  • Score: 10/10, The advisory exceptions match the retained zbus 5 dependency chain, rsa is absent from the lockfile, and no behavioral changes or actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

…sa ignore

RUSTSEC-2026-0370/0371/0372 mark zvariant, zbus_names, and zvariant_derive
unmaintained now that zbus 6 absorbed them. ashpd 0.14 moves to zbus 6, but
zbus 6 pipelines its handshake, which breaks portal calls inside a Flatpak on
xdg-dbus-proxy 0.1.5 (Ubuntu 24.04 LTS), so moq-video stays on ashpd 0.13.

rsa left the lockfile, so RUSTSEC-2023-0071 no longer matches anything.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 17:10
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0cae0f74-047d-40e8-bc22-9f112f7a1427
Commits

Reviewing files that changed from the base of the PR and between 13e593c and 0d13464.

Files selected for processing: 2

  • deny.toml
  • rs/moq-video/Cargo.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full diff (config and comment only).

  • deny.toml: adds ignores for RUSTSEC-2026-0370/0371/0372 (zbus 5's zvariant, zbus_names, zvariant_derive), with the reason and the removal condition documented. Drops the stale RUSTSEC-2023-0071 (rsa) ignore.
  • rs/moq-video/Cargo.toml: the ashpd comment now says that bumping ashpd also removes the zbus 5 ignores.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed 0d13464d891074be79644d02cbe1c25640d04d5e. No blocker. The three exceptions are specific unmaintained-crate advisories, not a blanket audit bypass. The failing Nightly job lists those three IDs and the stale RSA exception, and this patch leaves the dependency graph unchanged. Keeping the Flatpak handshake regression test as the upgrade gate is the right tradeoff. I checked the prior log and diff, but did not rerun just audit.

@kixelated
kixelated added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 38a1082 Nov 16, 2026
6 checks passed
@kixelated
kixelated deleted the fix/cargo-deny-advisories branch November 16, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant