Repository navigation
chore(deny): ignore zbus 5's unmaintained crates and drop the stale rsa ignore - #8966
Conversation
…sa ignore RUSTSEC-2026-0370/0371/0372 mark zvariant, zbus_names, and zvariant_derive unmaintained now that zbus 6 absorbed them. ashpd 0.14 moves to zbus 6, but zbus 6 pipelines its handshake, which breaks portal calls inside a Flatpak on xdg-dbus-proxy 0.1.5 (Ubuntu 24.04 LTS), so moq-video stays on ashpd 0.13. rsa left the lockfile, so RUSTSEC-2023-0071 no longer matches anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the full diff (config and comment only).
deny.toml: adds ignores forRUSTSEC-2026-0370/0371/0372(zbus 5'szvariant,zbus_names,zvariant_derive), with the reason and the removal condition documented. Drops the staleRUSTSEC-2023-0071(rsa) ignore.rs/moq-video/Cargo.toml: the ashpd comment now says that bumping ashpd also removes the zbus 5 ignores.
claude-sonnet-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 0d13464d891074be79644d02cbe1c25640d04d5e. No blocker. The three exceptions are specific unmaintained-crate advisories, not a blanket audit bypass. The failing Nightly job lists those three IDs and the stale RSA exception, and this patch leaves the dependency graph unchanged. Keeping the Flatpak handshake regression test as the upgrade gate is the right tradeoff. I checked the prior log and diff, but did not rerun just audit.

Fixes the Nightly
Auditjob (run 43909101837, job 133445815782): cargo-deny reported 3unmaintainederrors and 1 stale-ignore warning.zvariant,zbus_names, andzvariant_deriveare now unmaintained because zbus 6 absorbed them. The only path in is moq-video'spipewirefeature → ashpd 0.13 → zbus 5.Why ignore instead of upgrading
ashpd 0.14 moves to zbus 6, and the upgrade itself is easy (5 small API renames, and it drops 13 crates). But moq-video pins ashpd 0.13 on purpose. zbus 6 sends its whole D-Bus handshake in one write. Inside a Flatpak, xdg-dbus-proxy before 0.1.6 drops a connection whose
BEGINarrives before its earlier answers have gone back. That breaks every portal call on Ubuntu 24.04 LTS, which ships 0.1.5 (noble 0.1.5-1ubuntu0.2on Launchpad).zbus 6.3.0 (2026-11-13) still does this, and has no opt-out:
connection/handshake/client.rssend_commands. I tried the upgrade, and the guard testportal_handshake_waits_for_each_answerfails on it. So the ignores stay until the project drops 24.04 Flatpak support. The ashpd comment inrs/moq-video/Cargo.tomlnow says to remove them with the bump.Validation
just audit(the recipe the Nightly job runs) on this branch:advisories ok: 0 errors, 0 warnings, exit 0.cargo nextest run -p moq-video --features pipewire portal_handshakefailedportal_handshake_waits_for_each_answer. Reverted.rsahas no entry inCargo.lock.Caused by
Upstream RustSec advisories published after zbus 6.0, not #8891: ashpd 0.13 / zbus 5 has been in the tree since #2238. The rsa ignore went stale when #8250 removed rsa from the lockfile.
Public API / wire impact
None. Only the deny config and a comment change.
Models
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 0d13464
Base: origin/main at 13e593c
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e556-444d-7b13-88b8-4afa5a838478, round 1Score: 10/10,
The advisory exceptions match the retained zbus 5 dependency chain, rsa is absent from the lockfile, and no behavioral changes or actionable defects were found.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none