Skip to content

feat(video)!: moq-video configs pick a device and a cursor mode with one typed field each - #8940

Merged
moq-bot[bot] merged 3 commits into
mainfrom
quest/m2/native-media-config
Nov 17, 2026
Merged

moq-bot[bot] merged 3 commits into
mainfrom
quest/m2/native-media-config

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m2/native-media-config.md, deleting it.

Problem

moq-video's configs named hardware through backend-named paths (vaapi, v4l2) that existed only under cfg(all(target_os = "linux", feature = ...)), so every caller repeated moq-video's feature gates, and NVIDIA had no selector at all: NVDEC opened CUDA device 0, and NVENC device 0 unless an external Vulkan input picked one. A transcode host with more than one GPU could not place NVIDIA work. capture::Config::cursor was a bool, which cannot grow the planned third mode (the cursor apart from the frame).

Approach

  • New moq_video::Device, a #[non_exhaustive] enum present on every platform and feature set: Auto (default), Render(PathBuf) (a DRM render node), Video(PathBuf) (a V4L2 codec node). It replaces the gated paths on encode::Config, decode::Config, resize::Config, and encode::Capture as one device field.
  • Each backend candidate declares what it drives (Drives::Own, Render, Nvidia, Video). Selection passes over a Linux hardware backend that drives another kind of device without opening it, so a named node also steers Kind::Auto to its backend. Software and platform APIs that pick their own device (VideoToolbox, Media Foundation, MediaCodec) ignore it. On decode, a backend passed over is neither a refusal nor a fault, so UnsupportedCodec still means the named device refused the stream.
  • NVIDIA: a render node counts as NVIDIA when sysfs says the nvidia driver runs it. NVENC and NVDEC map it to its CUDA ordinal by PCI address (sysfs PCI_SLOT_NAME against each CUDA device's PCI domain, bus, and device). NVENC refuses a render node that is not the device behind Config::input.
  • moq_transcode::Config takes decoder_device and encoder_device (one per direction, since moq-transcode named a V4L2 decoder and encoder node separately).
  • capture::Config::cursor is capture::Cursor { Drawn, Hidden } (#[non_exhaustive]). Each backend reads it through one exhaustive Cursor::drawn match, so a third variant has to be decided per backend. capture::Mode is #[non_exhaustive] too.
  • CLI: --vaapi-device, --v4l2-encoder, --v4l2-decoder, and --no-cursor keep their names and lose their cfg gates; --vaapi-device now also picks the NVIDIA GPU.

Impact

  • moq-video (breaking): encode::Config::{vaapi, v4l2}, decode::Config::{vaapi, v4l2}, resize::Config::vaapi, and encode::Capture::{vaapi, v4l2} are one device: moq_video::Device. Migrate config.vaapi = Some(path) to config.device = Device::Render(path), config.v4l2 = Some(path) to config.device = Device::Video(path), and drop the #[cfg(..., feature = "vaapi" | "v4l2")] around them. A render node an NVIDIA driver runs now also places NVENC and NVDEC on that GPU instead of device 0.
  • moq-video (breaking): capture::Config::cursor: bool is capture::Cursor. Migrate cursor = true to Cursor::Drawn and cursor = false to Cursor::Hidden. capture::Mode is #[non_exhaustive]; it was only ever built inside the crate.
  • moq-transcode (breaking): Config::{vaapi, v4l2_decoder, v4l2_encoder} are decoder_device and encoder_device: moq_video::Device. Migrate vaapi to both set to Device::Render(path), v4l2_decoder to decoder_device = Device::Video(path), and v4l2_encoder to encoder_device = Device::Video(path).
  • Behavior: with a named node, Kind::Auto no longer opens hardware that drives another kind of device (before, VA-API came ahead of a named V4L2 node). A named render node whose NVIDIA driver check cannot read it (missing, not a device) passes over NVENC/NVDEC with that reason and goes on to VA-API and, under Auto, software, the same with or without nvidia compiled in.
  • CLI: flag names unchanged. --vaapi-device now conflicts with --v4l2-encoder / --v4l2-decoder in the same command, since one selector names one device; the flags exist on every platform and do nothing off Linux.
  • moq-ffi and bindings: none. No binding exposed the old paths or the cursor.
  • Wire: none.

Decisions

Taken without the maintainer (away); each is reviewable:

  1. Device steers Auto, and software stays orthogonal. A named device passes over hardware that drives another kind of device; whether software may take over when the named hardware fails is still Kind's call (Auto falls back as it did with a named VA-API node; Hardware errors). Alternative: a named device disables software fallback. Recommend keeping it orthogonal: Kind::Hardware already says "no software".
  2. Variant names Render and Video, after the kernel node classes (/dev/dri/renderD*, /dev/video*), so no public type names a backend, as the crate doc promises.
  3. NVIDIA mapping by PCI address from sysfs, not through a Vulkan instance (VK_EXT_physical_device_drm): no Vulkan load on the NVIDIA open path, and the same uevent read gives the driver check.
  4. CLI flags conflict rather than coexist, and stay visible off Linux, documented "Linux only" (hiding them needs a cfg_attr the usage derive was not verified to merge).
  5. No moq-ffi or binding change. The brief asked to update moq-ffi and every binding to match, but no binding exposed the gated paths or the cursor, and the bindings have no consumer for a device selector yet (the reference user is the transcode host, which runs moq transcode). Adding one later is additive. So just test interop --all did not run.
  6. No MIGRATE.md entry: the quest asked for one, but #8024 stopped per-PR entries, and AGENTS.md puts the note in Impact for the release cut.

Validation

  • Built a throwaway example (not committed) that opens encoders and decoders for each selector on this host (AMD iGPU on renderD128, no NVIDIA, no V4L2 M2M, libva not loadable from the dev shell):
    • Render("/dev/dri/renderD128") + Hardware: nvenc: does not open render node /dev/dri/renderD128 (sysfs reported DRIVER=amdgpu), VA-API tried that node, V4L2 passed over.
    • Video("/dev/video11") + Hardware: NVENC/NVDEC and VA-API passed over, V4L2 tried the node.
    • Render("/dev/dri/renderD199") (absent) and Render("/proc/self/status") (not a device): errors naming the path. Since review, a failed driver check counts against NVIDIA alone, so Auto goes on to VA-API and software (unit-tested on both sides).
    • Auto unchanged: every hardware backend tried, then openh264.
  • Built moq with capture,transcode: moq transcode --vaapi-device ... --v4l2-encoder ... and moq import capture with both flags fail with clap's conflict error; --help shows the flags.
  • Unit tests: selection steering on both sides (a passed-over backend is never opened; with none left the error names the device; the named device's own refusal stays UnsupportedCodec), the uevent parser, and the render node to CUDA ordinal mapping fed two fake PCI identities. NVIDIA on real hardware is untested: no host here has one.
  • just check passes.

Follow-ups

None.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, medium effort (arm A)
Implementer: Claude Code, claude-opus-5-5, low effort (iterate, S, arm A)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with medium effort)

Review

Rewritten by quest review after each round.

  • Head: 217aa57

  • Base: origin/main at fc38289

  • Risk: high, The branch replaces public configuration fields in moq-video and moq-transcode, which breaks downstream callers until they migrate or the change is reverted.

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1e4e4-ca51-7512-854c-305b49b00dfa, round 2

  • Score: 8/10, No actionable defects were found in the incremental changes, but builds, tests, and multi-GPU runtime behavior remain unvalidated.

  • Raised the risk to high: The branch replaces public configuration fields in moq-video and moq-transcode, which breaks downstream callers until they migrate or the change is reverted.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 16, 2026 06:20
encode::Config, decode::Config, resize::Config, encode::Capture, and
moq_transcode::Config pick hardware with a moq_video::Device present on every
platform and feature set, in place of cfg-gated VA-API and V4L2 paths. A
render node also places NVENC and NVDEC on the NVIDIA GPU behind it, matched
by PCI address. capture::Config::cursor is a non-exhaustive Cursor enum, and
capture::Mode is non-exhaustive.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title moq-video configs pick a device and a cursor mode with one typed field each feat(video)!: moq-video configs pick a device and a cursor mode with one typed field each Nov 16, 2026
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 15:09
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e525e160-8995-41a0-ba64-5f4eb0406ed8
Commits

Reviewing files that changed from the base of the PR and between 6488ce6 and 217aa57.

Files selected for processing: 38

  • doc/lib/rs/moq-video.md
  • quest/m2/README.md
  • quest/m2/native-media-config.md
  • quest/m2/video-producer.md
  • quest/m3/vaapi-render-tests.md
  • quest/m4/capture-cursor.md
  • quest/m5/vaapi-vulkan-import.md
  • rs/moq-cli/src/main.rs
  • rs/moq-cli/src/play/args.rs
  • rs/moq-cli/src/play/headless.rs
  • rs/moq-cli/src/play/media.rs
  • rs/moq-cli/src/play/video.rs
  • rs/moq-cli/src/publish.rs
  • rs/moq-cli/src/transcode.rs
  • rs/moq-transcode/CHANGELOG.md
  • rs/moq-transcode/src/config.rs
  • rs/moq-video/CHANGELOG.md
  • rs/moq-video/src/capture/mod.rs
  • rs/moq-video/src/capture/pipewire.rs
  • rs/moq-video/src/capture/screencapture.rs
  • rs/moq-video/src/capture/wgc/native.rs
  • rs/moq-video/src/capture/x11.rs
  • rs/moq-video/src/decode/backend/mod.rs
  • rs/moq-video/src/decode/backend/nvdec.rs
  • rs/moq-video/src/decode/backend/v4l2.rs
  • rs/moq-video/src/decode/backend/vaapi.rs
  • rs/moq-video/src/decode/decoder.rs
  • rs/moq-video/src/device.rs
  • rs/moq-video/src/encode/backend/mod.rs
  • rs/moq-video/src/encode/backend/nvenc.rs
  • rs/moq-video/src/encode/backend/v4l2.rs
  • rs/moq-video/src/encode/backend/vaapi.rs
  • rs/moq-video/src/encode/encoder.rs
  • rs/moq-video/src/encode/producer.rs
  • rs/moq-video/src/frame.rs
  • rs/moq-video/src/frame/cuda.rs
  • rs/moq-video/src/lib.rs
  • rs/moq-video/src/resize.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No blocking issues. One point on how selection fails, plus two stale doc references.

Reviewed changes

I reviewed the whole diff: the new moq_video::Device selector, how it steers encode and decode backend selection, the NVIDIA render node → CUDA ordinal mapping, the matching moq-transcode and moq-cli changes, and the new capture::Cursor enum.

  • Device replaces gated paths: encode::Config, decode::Config, resize::Config, and encode::Capture each take one device: Device field, on every platform and feature set.
  • Selection steering: each Candidate declares drives: Drives. select passes over a backend that drives another kind of device without opening it. On the decode side, passed-over backends stay out of the refusal-or-fault verdict.
  • NVIDIA placement: a render node counts as NVIDIA when its sysfs uevent says DRIVER=nvidia. It maps to a CUDA ordinal by PCI domain, bus and device. NVDEC and NVENC open that ordinal, and NVENC refuses a node that is not the external Vulkan input device.
  • moq-transcode / moq-cli: decoder_device and encoder_device replace the three backend-named paths. The CLI flags lose their cfg gates and now conflict with each other. usage-rs counts a value from an environment variable as given, so having both MOQ_VAAPI_DEVICE and MOQ_V4L2_* set now also fails startup.
  • Cursor: capture::Config::cursor is Cursor { Drawn, Hidden }, and each backend reads it through an exhaustive Cursor::drawn(). capture::Mode is now #[non_exhaustive].

ℹ️ Two module docs still point at the removed Config::vaapi

The VA-API backend module docs still say "Config::vaapi can name it". That field no longer exists, so they should point at Config::device (Device::Render). Both lines are outside the diff hunks:

  • rs/moq-video/src/encode/backend/vaapi.rs:14
  • rs/moq-video/src/decode/backend/vaapi.rs:19

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread rs/moq-video/src/device.rs Resolved

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed 4a1edaaaef6ac67a5e0445bfef8ba1a364694c37. No blocker in the library change. The typed selector keeps backend features out of callers, and the NVENC check avoids silently taking an explicit node that disagrees with the Vulkan input.

Two rollout checks: update downstream consumers of the removed moq_transcode::Config::vaapi field at the dependency bump, and exercise a nonzero NVIDIA GPU with reordered CUDA_VISIBLE_DEVICES to confirm both NVDEC and NVENC open the selected device. The fake PCI tests check the matching logic, not the driver’s reported addresses. Static review only; I did not build or run hardware tests.

An unreadable or missing render node counted against every backend: the
driver check's error left select through `?` before VA-API or software
was tried. It now counts against the NVIDIA candidate alone, as a failed
open would, and its reason still reaches NoEncoder/NoDecoder.

Also points the VA-API module docs at Config::device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. The prior feedback is addressed cleanly.

Reviewed changes

I reviewed the one commit since the last Pullfrog review, which fixes how backend selection handles a failed NVIDIA driver check.

  • Driver check failure no longer aborts selection: in both select loops, an Err from Device::takes now counts against that candidate the same way a failed open does. On decode it goes into tried and skipped, and faulted is set; on encode it goes into tried and refused. Selection then moves on, so VA-API and, under Kind::Auto, software are still tried. Because faulted is set, a decode with no candidates left ends as NoDecoder rather than UnsupportedCodec, and the error still names the path.
  • Tests: added a_failed_driver_check_moves_on on both sides, covering fallthrough to a render-node candidate and the final error naming the absent node.
  • Docs: pointed the encode and decode VA-API module docs at Config::device instead of the removed Config::vaapi.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Head: 217aa5774e3aaae356fd608c87b38abb83fbc587

No new blocker. An NVIDIA driver lookup failure is now scoped to that candidate, so a usable next decoder or encoder can still open; when none does, the failing node remains in the diagnostic. The new tests cover both outcomes without depending on a CUDA installation. The real nonzero-device check from the previous review still matters for rollout. Static review; I did not rerun the tests.

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 17, 2026
@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at 217aa57 because its merge_group build failed (failed_checks).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

Queue / Queue (job) failure at step Check:

…178  check js
    15      16  test js
    21      10  check markdown (cancelled)
    48      22  check carla_bridge
     0       0  check drill
     3       3  check quest
    20      19  check shell
     0       0  check large_files
     0       0  check text
     2       1  check coverage_tables
     0       0  check toml
     3       3  check nix
     0       0  check justfile
   148     733  whole run
error: recipe `ci` failed on line 120 with exit code 100
moq-doc test: (pass) audio jitter corpus > idle > reports every target as a change [0.01ms]
moq-doc test: (pass) audio jitter corpus > silence > matches the checked-in file [0.10ms]
moq-doc test: (pass) audio jitter corpus > silence > is a trace of equal-length clocks
moq-doc test: (pass) audio jitter corpus > silence > arrives in a monotonic order [0.47ms]
moq-doc test: (pass) audio jitter corpus > silence > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > silence > reports every target as a change
moq-doc test: (pass) audio jitter corpus > tunein > matches the checked-in file [0.10ms]
moq-doc test: (pass) audio jitter corpus > tunein > is a trace of equal-length clocks
moq-doc test: (pass) audio jitter corpus > tunein > arrives in a monotonic order [0.68ms]
moq-doc test: (pass) audio jitter corpus > tunein > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > tunein > reports every target as a change
moq-doc test: (pass) audio jitter corpus > spike > matches the checked-in file [0.17ms]
moq-doc test: (pass) audio jitter corpus > spike > is a trace of equal-length clocks
moq-doc test: (pass) audio jitter corpus > spike > arrives in a monotonic order [0.85ms]
moq-doc test: (pass) audio jitter corpus > spike > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > spike > reports every target as a change [0.02ms]
moq-doc test: (pass) audio jitter corpus > outage > matches the checked-in file [0.32ms]
moq-doc test: (pass) audio jitter corpus > outage > is a trace of equal-length clocks [0.01ms]
moq-doc test: (pass) audio jitter corpus > outage > arrives in a monotonic order [1.50ms]
moq-doc test: (pass) audio jitter corpus > outage > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > outage > reports every target as a change [0.05ms]
moq-doc test: (pass) audio jitter corpus > batches > matches the checked-in file [0.28ms]
moq-doc test: (pass) audio jitter corpus > batches > is a trace of equal-length clocks
moq-doc test: (pass) audio jitter corpus > batches > arrives in a monotonic order [0.84ms]
moq-doc test: (pass) audio jitter corpus > batches > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > batches > reports every target as a change [0.02ms]
moq-doc test: (pass) audio jitter corpus > straggler > matches the checked-in file [0.09ms]
moq-doc test: (pass) audio jitter corpus > straggler > is a trace of equal-length clocks [0.01ms]
moq-doc test: (pass) audio jitter corpus > straggler > arrives in a monotonic order [0.89ms]
moq-doc test: (pass) audio jitter corpus > straggler > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > straggler > reports every target as a change [0.01ms]
moq-doc test: (pass) audio jitter corpus > fixed > matches the checked-in file [0.05ms]
moq-doc test: (pass) audio jitter corpus > fixed > is a trace of equal-length clocks
moq-doc test: (pass) audio jitter corpus > fixed > arrives in a monotonic order [0.18ms]
moq-doc test: (pass) audio jitter corpus > fixed > names a target for the first frame
moq-doc test: (pass) audio jitter corpus > fixed > reports every target as a change
moq-doc test: 
moq-doc test: ::endgroup::
moq-doc test: 
moq-doc test: ::group::concept/audio-jitter/stretch/corpus.test.ts:
moq-doc test: (pass) audio stretch corpus > the decisions match the checked-in file [0.13ms]
moq-doc test: (pass) audio stretch corpus > the cases match the checked-in file [0.05ms]
moq-doc test: (pass) audio stretch corpus > hold > matches the checked-in case [0.03ms]
moq-doc test: (pass) audio stretch corpus > hold > decides every hop it plays [0.02ms]
moq-doc test: (pass) audio stretch corpus > hold > moves the output by exactly the shifts it took [0.05ms]
moq-doc test: (pass) audio stretch corpus > speed-up-voiced > matches the checked-in case [0.08ms]
moq-doc test: (pass) audio stretch corpus > speed-up-voiced > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > speed-up-voiced > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > slow-down-voiced > matches the checked-in case [0.09ms]
moq-doc test: (pass) audio stretch corpus > slow-down-voiced > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > slow-down-voiced > moves the output by exactly the shifts it took [0.01ms]
moq-doc test: (pass) audio stretch corpus > bridge > matches the checked-in case [0.06ms]
moq-doc test: (pass) audio stretch corpus > bridge > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > bridge > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > turns-around > matches the checked-in case [0.11ms]
moq-doc test: (pass) audio stretch corpus > turns-around > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > turns-around > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > narrow-range > matches the checked-in case [0.07ms]
moq-doc test: (pass) audio stretch corpus > narrow-range > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > narrow-range > moves the output by exactly the shifts it took [0.01ms]
moq-doc test: (pass) audio stretch corpus > music > matches the checked-in case [0.08ms]
moq-doc test: (pass) audio stretch corpus > music > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > music > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > noise > matches the checked-in case [0.09ms]
moq-doc test: (pass) audio stretch corpus > noise > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > noise > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > silence > matches the checked-in case [0.08ms]
moq-doc test: (pass) audio stretch corpus > silence > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > silence > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > stereo-linked > matches the checked-in case [0.12ms]
moq-doc test: (pass) audio stretch corpus > stereo-linked > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > stereo-linked > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > stereo-opposite > matches the checked-in case [0.12ms]
moq-doc test: (pass) audio stretch corpus > stereo-opposite > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > stereo-opposite > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > bridge-44100 > matches the checked-in case [0.09ms]
moq-doc test: (pass) audio stretch corpus > bridge-44100 > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > bridge-44100 > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > bridge-48000 > matches the checked-in case [0.10ms]
moq-doc test: (pass) audio stretch corpus > bridge-48000 > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > bridge-48000 > moves the output by exactly the shifts it took
moq-doc test: (pass) audio stretch corpus > speed-up-16000 > matches the checked-in case [0.13ms]
moq-doc test: (pass) audio stretch corpus > speed-up-16000 > decides every hop it plays
moq-doc test: (pass) audio stretch corpus > speed-up-16000 > moves the output by exactly the shifts it took
moq-doc test: 
moq-doc test: ::endgroup::
moq-doc test: 
moq-doc test:  187 pass
moq-doc test:  0 fail
moq-doc test:  26684 expect() calls
moq-doc test: Ran 187 tests across 5 files. [3.31s]
moq-doc test: Exited with code 0
js: test finished in 15.15s
##[endgroup]
##[group]check markdown
##[endgroup]
##[error]ci: test rs failed
##[error]Process completed with exit code 100.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: cargo-timings
  path: target/cargo-timings/cargo-timing-*.html
  if-no-files-found: ignore
  retention-days: 14
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  BASE: b063faa45bbbf683402d56e0e9da56d999eff42d
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
With the provided path, there will be 7 files uploaded
Artifact name is valid!
Root directory input is valid!
Uploading artifact: cargo-timings.zip
Beginning upload of artifact content to blob storage
Uploaded bytes 381548
Finished uploading artifact content to blob storage!
SHA256 digest of uploaded artifact is 3247b45b5a204d9a67479b01e880c68c525911ed5ed407e79315b1eb4dbb4001
Finalizing artifact upload
Artifact cargo-timings successfully finalized. Artifact ID 14311102680
Artifact cargo-timings has been successfully uploaded! Final size is 381548 bytes. Artifact ID is 14311102680
Artifact download URL: https://github.com/moq-dev/moq/actions/runs/44045332909/artifacts/14311102680
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__0154b877-cd9d-4f34-9174-302d31757f91.mbx]
##[end-action id=__0154b877-cd9d-4f34-9174-302d31757f91.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/335ea511-a05e-4780-97d2-b8539c48d7f3' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 50 objects and 0 action results (601.8 MiB logical); 50.0 GiB logical remain
evicted 0 objects and 0 action results (0 B logical); 50.0 GiB logical remain
Cleaning up orphan processes

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 17, 2026
@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

codex, gpt-6.1-sol, medium effort land fixer note:

The queue failed in moq-c test::server_accepts_a_session: moq_session_close(client) returned -21 (session not found) instead of 0 (failure log lines 1281–1284). The PR leaves this test and session code unchanged. On a scratch merge with base, the isolated test passed and the complete Nix dev-shell gate (just ci base) passed, including 1,680 Rust tests. The PR branch remains at its pinned head.

A separate skip-only commit was tried and removed: just ci base rejected it with ignore moq-c::test::server_accepts_a_session has no CI caller (rs/moq-c/src/test.rs:8311). The inventory allowance requires an existing quest document, but the listed follow-up document is absent. Creating quest content is forbidden here, and adding a CI caller would require a protected workflow edit, so this uses the allowed fallback of requeueing without a disable commit.

(written by codex, gpt-6.1-sol, medium effort)

@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: re-enqueued this pull request at 217aa57, at the back of the merge queue, unchanged, since the land fixer judged the failure flaky: moq-c test::server_accepts_a_session.

(written by quest land watch)

Merged via the queue into main with commit 48cb06b Nov 17, 2026
5 checks passed
@moq-bot
moq-bot Bot deleted the quest/m2/native-media-config branch November 17, 2026 08:29
kixelated added a commit that referenced this pull request Nov 17, 2026
Adopts #8946's Finished (Publisher::finish consumes and wraps
moq_mux::container::Finished), ports #8940's Capture::device and #8977's
sync.clock into the split capture.rs, and drops quests main or this PR finished.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant