Skip to content

quest: JS learns the verdict on its connection credential - #8876

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/js-credential-answer
Nov 15, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/js-credential-answer

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

kixel.ai's mesh Device must stop dialing once kixel.ai removes or revokes a device whose session was live. After a healthy session, @moq/net retries every refusal by design (moq-dev/moq#8618) and leaves the app to judge from the peer's verdict on its credential. Rust gives the app that verdict through Tokens::poll_answered. JS doesn't. moq-dev/moq#8817 ends only a first session refused before it is healthy, so it doesn't cover a refusal after a healthy session. Found while kixel.ai bumped its pin (kixel-ai/kixel.ai#118), which skipped its removed-device and revoked-device tests until this lands.

Approach

Adds quest/m1/js-tokens-answered.md (S, m1): a reconnecting JS Connection exposes the peer's verdict on the tokens it last set, a refusing close included, rule for rule as Tokens::poll_answered gives it. It goes in m1 beside first-dial-refusal.md, the same reconnect-refusal line.

Decisions

Validation

quest check passes (491 documents). No behavior to exercise: this PR only adds a quest.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

(Written by Opus 5.5 with high)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 0737dda

  • Base: origin/main at 952c55d

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e11b-df89-7fa1-9a16-48004d18aa8d, round 1

  • Score: 10/10, The change adds only a quest plan, with no runtime or API changes and no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1e11b-df89-7ec0-94e7-83db74db5222, round 1

  • Score: 10/10, The change adds only a quest plan, changes no runtime code or tests, and has no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 21:28
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 522653c7-7b20-4447-878b-c3a26a7832db
Commits

Reviewing files that changed from the base of the PR and between 952c55d and 0737dda.

Files selected for processing: 1

  • quest/m1/js-tokens-answered.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 15, 2026 21:28

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the single added quest document.

  • quest/m1/js-tokens-answered.md: adds an S quest for JS parity with Rust's Tokens::poll_answered. I checked that the referenced files all exist: first-dial-refusal.md, rs/moq-net/src/auth/tokens.rs (with poll_answered), and js/net/src/connection/{tokens,reload}.test.ts.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 5b4c01b Nov 15, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/js-credential-answer branch November 15, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant