Repository navigation
quest: JS learns the verdict on its connection credential - #8876
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 15, 2026 21:28
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 15, 2026 21:28
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the single added quest document.
quest/m1/js-tokens-answered.md: adds an S quest for JS parity with Rust'sTokens::poll_answered. I checked that the referenced files all exist:first-dial-refusal.md,rs/moq-net/src/auth/tokens.rs(withpoll_answered), andjs/net/src/connection/{tokens,reload}.test.ts.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
kixel.ai's mesh
Devicemust stop dialing once kixel.ai removes or revokes a device whose session was live. After a healthy session,@moq/netretries every refusal by design (moq-dev/moq#8618) and leaves the app to judge from the peer's verdict on its credential. Rust gives the app that verdict throughTokens::poll_answered. JS doesn't. moq-dev/moq#8817 ends only a first session refused before it is healthy, so it doesn't cover a refusal after a healthy session. Found while kixel.ai bumped its pin (kixel-ai/kixel.ai#118), which skipped its removed-device and revoked-device tests until this lands.Approach
Adds
quest/m1/js-tokens-answered.md(S, m1): a reconnecting JSConnectionexposes the peer's verdict on the tokens it last set, a refusing close included, rule for rule asTokens::poll_answeredgives it. It goes in m1 besidefirst-dial-refusal.md, the same reconnect-refusal line.Decisions
Tokensverdict (rejected: no moq quest, relying on fix(reconnect): a first session refused before it is healthy fails fast #8817 alone, which leaves a removed live device redialing forever; changing the retry policy, which reverses feat(reconnect)!: the reconnect loop stops judging errors by kind #8618).Validation
quest checkpasses (491 documents). No behavior to exercise: this PR only adds a quest.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
(Written by Opus 5.5 with high)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 0737dda
Base: origin/main at 952c55d
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e11b-df89-7fa1-9a16-48004d18aa8d, round 1Score: 10/10,
The change adds only a quest plan, with no runtime or API changes and no actionable defects.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1e11b-df89-7ec0-94e7-83db74db5222, round 1Score: 10/10,
The change adds only a quest plan, changes no runtime code or tests, and has no actionable defects.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none