Repository navigation
quest: plan cache-aware multicast routing - #8873
Conversation
Replaces lite-07's route layer before the cut: routes to forwarding nodes, evidence instead of holds and doubt, claims crossing trust boundaries by a chain, a measured pick of how warm copies are found, a mechanized convergence proof, and the metadata-only secondary in m3. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the quest-file-only diff, with the new epic README read in full and the rest skimmed.
- New
m2/multicastepic: requirements, audit, settled decisions and child quests (bakeoff, warmth, proof, router, switch, requests, accept). m3/route-healthrestored andm3/cache-routingrewritten for the new rule.- Superseded quests deleted or moved:
transient-cycles,route-keep-next-hop,route-split-horizonandroute-trace-validationare deleted.request-loopis moved tom2/multicast/requests. - Existing m2 cluster-routes quests are marked as waiting on the bake-off or reopened.
claude-sonnet-5-5 | 𝕏
|
quest land watch: the merge queue removed this pull request at 5226196 because its The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.
…\/git\-credentials\-35fdca68\-bf74\-48f8\-bd0f\-4a28e8d57778\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git.path
/github/runner_temp/git-credentials-35fdca68-bf74-48f8-bd0f-4a28e8d57778.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git.path \/github\/runner_temp\/git\-credentials\-35fdca68\-bf74\-48f8\-bd0f\-4a28e8d57778\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git/worktrees/*.path
/github/runner_temp/git-credentials-35fdca68-bf74-48f8-bd0f-4a28e8d57778.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git/worktrees/*.path \/github\/runner_temp\/git\-credentials\-35fdca68\-bf74\-48f8\-bd0f\-4a28e8d57778\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Removing credentials config '/var/cache/github-runner-work/_temp/git-credentials-35fdca68-bf74-48f8-bd0f-4a28e8d57778.config'
##[endgroup]
Prepare all required actions
Getting action download info
Download action repository 'taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39' (SHA:cfdb7ed4ccc7c7dce37759eae89dc5674b469b39)
##[group]Run ./.github/actions/just
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Use the NixOS runner toolchain;id=__self.__run]
##[group]Run just --version
�[36;1mjust --version�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
just 1.59.0
##[end-action id=__self.__run;outcome=success;conclusion=success;duration_ms=12]
##[start-action display=Run taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39;id=__self.__taiki-e_install-action]
##[end-action id=__self.__taiki-e_install-action;outcome=skipped;conclusion=skipped;duration_ms=0]
Prepare all required actions
Getting action download info
Download action repository 'jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de' (SHA:88acf2bb50552c7c508cbac13e5f8c576b95b1de)
##[group]Run ./.github/actions/rust-cache
with:
write: true
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Require main's merge queue on self-hosted runners;id=__self_2.__run]
##[end-action id=__self_2.__run;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cache credentials;id=__self_2.__run_2]
##[end-action id=__self_2.__run_2;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__self_2.mbx]
##[group]Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de
with:
version: 1.30.0
backend: local
remote-url: s3://mbx-moq-dev
namespace: Linux-X64
github-token: ***
cache-generation: v1
github-cache-mode: target
isolate-objects-cache: false
clean-target-before-export: false
save-on-workflow-dispatch: false
save-on-pull-request: false
save-on-protected-branch: false
working-directory: .
cache-links: auto
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
Set up mbx 1.30.0
##[end-action id=__self_2.mbx;outcome=success;conclusion=success;duration_ms=507]
##[start-action display=Drop another mbx version's private state;id=__self_2.__run_3]
##[group]Run : "${VERSION:?the mbx action reported no version}"
�[36;1m: "${VERSION:?the mbx action reported no version}"�[0m
�[36;1mstamp="$HOME/.cache/moq-mbx-versions$RUNNER_WORKSPACE"�[0m
�[36;1mif [ "$(cat "$stamp" 2>/dev/null)" != "$VERSION" ]; then�[0m
�[36;1m mbx clean --under "$RUNNER_WORKSPACE"�[0m
�[36;1m mkdir -p "${stamp%/*}"�[0m
�[36;1m printf '%s\n' "$VERSION" > "$stamp"�[0m
�[36;1mfi�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
VERSION: 1.30.0
##[endgroup]
##[end-action id=__self_2.__run_3;outcome=success;conclusion=success;duration_ms=9]
##[start-action display=Sweep the cache before building;id=__self_2.__run_4]
##[group]Run auto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)
�[36;1mauto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)�[0m
�[36;1mif [ "$auto" != "false" ]; then�[0m
�[36;1m echo "::error::the runner's global mbx config must set gc.auto = false, but it reads '$auto' without MBX_* variables"�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mmbx gc�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
##[end-action id=__self_2.__run_4;outcome=success;conclusion=success;duration_ms=1005]
##[start-action display=Check the cache;id=__self_2.__run_5]
##[end-action id=__self_2.__run_5;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cargo shim;id=__self_2.__run_6]
##[group]Run mbx setup --yes
�[36;1mmbx setup --yes�[0m
�[36;1mshim=$(mbx setup --status 2>/dev/null | sed -n '1s/.*: //p' || true)�[0m
�[36;1mif [ ! -e "$shim" ]; then�[0m
�[36;1m echo "::error::mbx setup installed no Cargo shim: $(mbx setup --status 2>&1)"�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mecho "${shim%[/\\]*}" >> "$GITHUB_PATH"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
refreshed the Cargo shim at /var/cache/github-runner-home/.local/share/mbx/bin/cargo
##[end-action id=__self_2.__run_6;outcome=success;conclusion=success;duration_ms=30]
##[group]Run rm -rf target/cargo-timings
�[36;1mrm -rf target/cargo-timings�[0m
�[36;1mnix develop --command just ci "$BASE"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash -e {0}
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'fallback'.
Pass '--accept-flake-config' to trust it
CI_STRICT=1 NEXTEST_PROFILE=ci sh/dispatch.sh ci "$BASE"
changed: base 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
ci: check biome started
ci: check quest started
ci: check shell started
ci: check quest failed in 1s
##[group]check quest
Dev-shell quest: /nix/store/dikb149z4p234xfgdz5p4shwgq8llv5y-quest-e454f29/bin/quest
quest: quest/m2/multicast/requests.md:72: link does not resolve: /quest/m4/resume-redesign.md
quest: quest/m2/multicast/requests.md:82: link does not resolve: /quest/m4/resume-redesign.md
##[endgroup]
ci: check shell cancelled in 1s
##[group]check shell
##[endgroup]
ci: check biome cancelled in 1s
##[group]check biome
uv run --no-project python sh/js/install.py frozen
[0.04ms] ".env"
bun install v1.4.4 (38afee6c8)
Resolving dependencies
Resolved, downloaded and extracted [1]
$ bun run --cwd js/libav build
$ bun build.ts
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'fallback'.
Pass '--accept-flake-config' to trust it
shutting down�[Kerror: interrupted by the user
error: recipe `biome` failed on line 143 with exit code 143
##[endgroup]
##[error]ci: check quest failed
ci: wall and CPU seconds per module
1 0 check biome (cancelled)
1 2 check quest (failed)
1 0 check shell (cancelled)
1 3 whole run
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
name: cargo-timings
path: target/cargo-timings/cargo-timing-*.html
if-no-files-found: ignore
retention-days: 14
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
BASE: 5b4c01b749c5457a5fc82b3a992d351c89cdb62f
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
No files were found with the provided path: target/cargo-timings/cargo-timing-*.html. No artifacts will be uploaded.
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__71d8865e-ea95-41cc-8847-336d0172a357.mbx]
##[end-action id=__71d8865e-ea95-41cc-8847-336d0172a357.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/5fd6f5f3-d97f-475d-b030-a42167715e97' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
Cleaning up orphan processes
(written by quest land watch) |
|
codex, gpt-6.1-sol, medium effort land fixer note:
(written by codex, gpt-6.1-sol, medium effort) |
|
codex, gpt-6.1-sol, medium effort land fixer: quest: quest/m2/multicast/requests.md:72: link does not resolve: /quest/m4/resume-redesign.md quest: quest/m2/multicast/requests.md:82: link does not resolve: /quest/m4/resume-redesign.md (written by codex, gpt-6.1-sol, medium effort) |
…st, and standbys Warm means demand, with pop skipping and one uplink per group of drones as the two cases requirement 8 must deliver. A moq-transport session is an endpoint. Redundant ingest is one Instance from synchronized encoders. The metadata secondary is opt in. Also follows main's deletion of the resume redesign quest, which the requests quest linked to. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior pullfrog review: the commit recording the maintainer's 2026-11-15 answers, plus a merge of main.
- Warm means demand: the epic, warmth, and cache-routing quests now define a warm node by downstream demand and name pop skipping and one uplink per group of drones as the two cases that must work.
- moq-transport is an endpoint: the epic and requests quests add decision 10 and a fixture pinning bounded work when a peer announces a name back.
- Redundant ingest: decision 11 makes it one Instance from synchronized encoders, and the accept quest adds the two-Instance case.
- Opt-in metadata secondary: the route-health epic and failover quests make the standby off by default, with the opt-in as a config field and a client option.
- Resume redesign link: the requests quest drops the dead link and names the per-reader path that stays.
claude-sonnet-5-5 | 𝕏

Problem
The lite-07 route layer does not meet the maintainer's requirements for routing, stated 2026-11-15. An audit of the code found:
a_payload_stall_with_live_sessions_is_never_recovered).Approach
A new epic,
quest/m2/multicast, replaces the route layer on lite-07-wip before the cut. Its README records the requirements, the audit's verdict, the settled decisions, and the lessons from about thirty earlier attempts.path::Routeron CDN tiers, meshes, and joined meshes; the maintainer picks from the numbersjs/netrun it; holds, doubt, the Route Key, and qualified Node IDs goMilestones: the route layer changes lite-07-wip bytes, so it joins m2 and lite07-finalize now requires the epic. The warmth measurement is in m2 because its pick may change bytes lite-07 would freeze; its implementation and the metadata secondary are additive and join m3.
Existing quests:
doubt-holds,doubt-keepalive(its maintainer decision is answered by the redesign and moves into its Plan),held-after-close, androute-fanout. The switch deletes them if the new rule goes ahead.m2/multicast/requests.m3/cache-routing/transient-cycles,m3/route-keep-next-hop,m3/route-split-horizon, andm3/route-trace-validation; the router quest carries what stands of the last three.m2/cluster-routes(Plan item 31),m2/cluster-routes/acceptance,m3/cluster-routing, andm3/cluster-routing/federation.Decisions
Recorded with their rejected options in the epic's Plan:
upstreamworks (rejected: a strict originate-only mark; both switches)From the deleted quests, so their Plans are not lost:
transient-cycles: 2026-11-14 (maintainer, on feat(net)!: prove cache-aware routing settles under fresh seeds #8732), merge the cache-aware rule and plan a quest to lower its 3.3% pull-cycle rate, with a fix that adds no join latency. The rule it tuned is replaced.route-keep-next-hop: 2026-11-11 (maintainer), a relay stays on its next hop among equal routes, in m3. Now a requirement of the router quest.route-split-horizon: 2026-11-06 (maintainer), a relay never advertises a route back over the session it learned it on, in m3. Now a requirement of the router quest.route-trace-validation: 2026-11-14 (maintainer, on quest: first pass of the pre-cut feature review, and its follow-ups #8764), keep the exhaustive search over the compiled router and deleteRouteHandoff.tla. The router quest moves the search; the switch deletes the model.Answered 2026-11-15 (maintainer, on this PR), after the plan's review flagged which requirements cost the most:
Alternatives
Link-state among relays, a shared control-plane database, and an elected ingest all violate "no global view" or "no single point of failure". Per-broadcast gossip trees (Plumtree, GossipSub) are broadcast rather than multicast and do not fit millions of broadcasts; their stall detection by comparison is what the route-health epic copies.
Validation
quest check: 497 documents ok, after mergingmain, which deletedquest/m4/resume-redesign.md; the requests quest linked to it and now names the per-reader path that stays. No behavior to exercise: quest files only.Impact
None: quest files only.
Follow-ups
For other repositories' quest trees, to plan there:
Models
Size: L
Implementer: Claude Code, claude-fable-5-2, unknown effort
🤖 Generated with Claude Code
(Written by Claude Fable 5.2)
Review
Rewritten by
quest reviewafter each round.Head: cd0e348
Base: origin/main at 2c3eb75
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, xhigh effort
Session:
01a1e11d-6b6c-70e1-8e05-7bbe7dd86602, round 2Score: 9/10,
The incremental changes clarify planning requirements without actionable defects, while implementation remains gated on measurement, proof, and acceptance work.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none