Skip to content

quest: drop the finished time-addressing model quest - #8863

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-complete/time-addressing-model
Nov 15, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-complete/time-addressing-model

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

#8638 (address groups by their start) merged on 2026-11-15 and implements quest/m2/time-addressing/model.md, but it updated that quest's Plan instead of deleting it. The finished quest kept about 245 quests blocked, including lite07.md, js.md, bindings.md and everything after them.

Approach

  • quest rm quest/m2/time-addressing/model.md removes it and every Required link to it.
  • The prose links that cite its decisions now point at its final version (commit 7d1bee7) instead of the deleted path. That way the decision record stays one click away.

Decisions

Impact

None. Quest text only.

Validation

  • quest check: 491 documents ok.

Models

Size: XS

Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: c5d8959

  • Base: origin/main at 7f19961

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e070-44c6-7d52-b78b-564385eaf75e, round 1

  • Score: 10/10, The documentation cleanup preserves valid historical references and has no identified blocking issues.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

#8638 implemented quest/m2/time-addressing/model.md but kept the file, so
about 245 quests stayed blocked on finished work. Links to its decisions
now point at its final version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 18:20
@kixelated
kixelated enabled auto-merge November 15, 2026 18:21

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the full diff: deletion of the finished model quest and the link rewrites that referenced it.

  • Delete quest/m2/time-addressing/model.md: removes the completed quest.
  • Drop Required links: removes the now-dangling entries from catalog-at-timestamp.md, group-drops.md, bindings.md, lite07.md, layered-runs.md, time-addressing-consumers.md and ietf-time-addressing.md.
  • Permalink prose links: points the remaining citations at the final file at 7d1bee79c. A grep confirms no relative time-addressing/model.md links remain.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The documentation updates replace local time-addressing model links with GitHub URLs, including commit-pinned URLs. They also remove the model document and several related Required sections. The changes do not modify protocol implementation.

Merge Risk: Minimal · up to c5d89

This change only edits quest documentation. It removes a completed quest and the blocking links that depended on it, and no protocol or runtime behavior changes. It looks safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "quest: drop the finished time-addressing model quest" matches the main change: removing the completed quest/m2/time-addressing/model.md and its Required links, and redirecting prose links. …
Description check Passed The description explains the problem (PR #8638 implemented the model but left the quest in place, blocking about 245 quests), the approach (quest rm of the model quest and its Required links, with pro…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "quest: drop the finished time-addressing model quest" matches the main change: removing the completed quest/m2/time-addressing/model.md and its Required links, and redirecting prose links. It is specific and concise.

Full details: Description check

Explanation

The description explains the problem (PR #8638 implemented the model but left the quest in place, blocking about 245 quests), the approach (quest rm of the model quest and its Required links, with prose links pointed at the pinned commit), and the impact (quest text only). It directly describes the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1189577a-59af-48c5-b45c-22a235815e08
Commits

Reviewing files that changed from the base of the PR and between 7f19961 and c5d8959.

Files selected for processing: 12

  • quest/m2/catalog-at-timestamp.md
  • quest/m2/group-drops.md
  • quest/m2/lite07-finalize.md
  • quest/m2/time-addressing/bindings.md
  • quest/m2/time-addressing/js.md
  • quest/m2/time-addressing/lite07.md
  • quest/m2/time-addressing/model.md
  • quest/m3/layered-runs.md
  • quest/m3/time-addressing-consumers.md
  • quest/m3/time-addressing-guide.md
  • quest/m4/ietf-time-addressing.md
  • quest/m5/e2ee/README.md
Files with no reviewable changes: 1

  • quest/m2/time-addressing/model.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Merged via the queue into main with commit d23ec79 Nov 15, 2026
9 checks passed
@moq-bot
moq-bot Bot deleted the quest-complete/time-addressing-model branch November 15, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant