Skip to content

feat(congestion)!: BBR ships through the selector, candidates compile behind moq-congestion's lab feature - #8850

Merged
kixelated merged 6 commits into
mainfrom
quest/m2/congestion-candidates
Nov 15, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m2/congestion-candidates

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-congestion 0.1.0 has never been published, yet its public API carried three candidates no session can select: GCC (gcc, about 16k vendored WebRTC lines under BSD), SCReAMv2 (scream), and BBR3's delay bound (bbr3::Config::delay_bound). The maintainer's pick on moq-dev/moq#8764: ship BBR through one selector, keep the candidates off the published API until tested, and make new algorithms additive. moq-ffi's MoqCongestionControl was a closed enum, so a new algorithm would break every Swift, Kotlin, and Dart caller that switches over it.

Completes quest/m2/congestion-candidates.md.

Approach

  • GCC (src/gcc/) and SCReAMv2 (src/scream.rs) stay modules of moq-congestion, compiled only with its documented lab test-support feature, the way sim and fuzz work elsewhere. lab also gates BBR3's delay-bound setter. Without it, neither module, nor a packet's GCC probe-cluster field, nor tracing (now optional, only GCC logs) is compiled. The pacer stays crate-private.
  • moq-quic's sim comparisons and moq-tokio's real-socket SCReAM tests enable lab through their moq-congestion dev-dependency, which cargo publish drops, so their code is unchanged from main. The large-MTU window test covers GCC and SCReAM again when lab is on, and the nightly rust-test group names moq-congestion/lab explicitly, so the GCC per-packet benchmark keeps its original series.
  • The vendored WebRTC files keep LICENSE, PATENTS, and AUTHORS beside them and still ship in the published package, so moq-congestion's license stays (MIT OR Apache-2.0) AND BSD-3-Clause, as on main.
  • The selector stays moq_tokio::quic::CongestionControl (#[non_exhaustive], relay/CLI congestion_control). Its docs now say plainly that delay is BBR v3 and the default, and that a new algorithm is added as a variant named after it.
  • MoqCongestionControl becomes an immutable uniffi object with loss(), delay(), and none() constructors, following the MoqAudioCodec precedent, with Eq/Hash/Debug exported. A new algorithm is a new constructor, which breaks no binding. Wrappers, tests, and docs are updated in Swift, Kotlin, Dart (bindings regenerated), Python, Go, C++ (OBS plugin), and moq-ffi.
  • quic-realtime's stale "add Realtime" naming item is aligned with the newer decision to name each winner after its algorithm, and it records the feature decision below.

Impact

  • moq-congestion (unpublished): gcc, scream, and bbr3::Config::delay_bound now require the new lab feature (test support, meant for dev-dependencies). tracing becomes an optional dependency that lab enables. License unchanged.
  • moq-tokio: quic::CongestionControl also derives Hash (additive). Docs only otherwise.
  • moq-ffi (breaking): MoqCongestionControl is an object instead of an enum. MoqQuicConfig.congestion_control is Option<Arc<MoqCongestionControl>>. Migration:
    • Swift: .delay / .loss / .none -> CongestionControl.delay() / .loss() / .none()
    • Kotlin: CongestionControl.DELAY -> CongestionControl.delay()
    • Dart: CongestionControl.delay -> CongestionControl.delay()
    • Python: CongestionControl.DELAY -> CongestionControl.delay()
    • Go: the CongestionControlLoss/Delay/None constants are gone; use moq.LossCongestionControl(), moq.DelayCongestionControl(), moq.NoneCongestionControl(), assigned directly (no ptr(...))
    • C++: moq::CongestionControl::kDelay -> moq::CongestionControl::delay(); compare with eq()
    • C API: unchanged (it already takes the loss/delay/none string)
  • Relay/CLI config: unchanged (delay, loss, none).
  • Wire: none.

Decisions

  • Decided 2026-11-15 (maintainer, /quest-complete, comment), in the maintainer's words: "wait why a new crate? put them behind a feature then definitely not a new crate". ✅ GCC and SCReAMv2 stay modules of moq-congestion behind the existing lab feature, one feature for all three candidates (rejected: the workspace-only moq-congestion-lab crate). This supersedes the quest's recorded rejection of "ship them behind an unstable feature", which paraphrased the quest: first pass of the pre-cut feature review, and its follow-ups #8764 pick. The quest file is deleted by this PR, so the record lives in quest/m4/quic-realtime.md, the bake-off that owns the candidates.
  • Kept the name lab: it already names "candidates under test" in this PR, and a second feature (say, candidates beside lab) would split one test-support switch in two.
  • A documented lab feature, not #[doc(hidden)] (banned by sh/text.sh), the same rule moq-dev/moq#8392 set for sim/fuzz.
  • MoqCongestionControl as an object (the MoqAudioCodec shape) rather than wrapper-only types in Swift/Kotlin/Dart, so every binding grows the same way and the API names match across languages.

Validation

  • just check (changed scope): every module passes except check quest, which fails only because this host's dev shell carries a stale quest (62d6b5e) older than the flake's pin; the pinned v0.15.0 (nix run github:moq-dev/quest/3122d76 -- check --base origin/main --branch quest/m2/congestion-candidates) reports 485 documents ok. Its test rs ran 13818 tests, all passing, including 251 gcc:: and 9 scream:: tests in moq-congestion (enabled through moq-quic's dev-dependency).
  • moq-congestion alone, without lab: clippy --all-targets -D warnings and cargo doc -D warnings pass with no dead-code warnings; nextest runs 125 tests (no candidates compiled).
  • moq-congestion alone, with --features lab: clippy and doc pass; nextest runs 385 tests, including the large-MTU window check over GCC and SCReAM.
  • Nightly benchmark: just rs test --release -p moq-congestion --features lab -E 'test(benchmark_per_packet)' --run-ignored only runs moq-congestion gcc::bench::benchmark_per_packet, the series name main already records.
  • moq-tokio's real-socket SCReAM measurement: just rs test -p moq-tokio --test integration -E 'test(scream::near_zero)' --run-ignored only passes.
  • cargo package --list -p moq-congestion: ships src/gcc/ with LICENSE, PATENTS, AUTHORS, and src/scream.rs, under (MIT OR Apache-2.0) AND BSD-3-Clause.
  • Earlier rounds (unchanged by this rework): just py test (128 passed), just go check, just kt check, just dart check, and the OBS settings test on the new constructors; moq-ffi's client_connects_with_every_knob_set and rung tests. Swift isn't run on Linux; CI's macOS lane covers it.

Alternatives

  • A workspace-only moq-congestion-lab crate (this PR's first approach): rejected by the maintainer; it split one crate's tests, benchmark history, and license notice across two for no published-surface gain over a feature.
  • Delete GCC/SCReAM and restore them for the bake-off, or publish them as they are: rejected by the maintainer's pick on quest: first pass of the pre-cut feature review, and its follow-ups #8764.
  • A separate selector variant for the delay bound: it runs inside BBR's state machine, so it stays a BBR option.

Follow-ups

None.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, M, arm A)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with medium)

Review

Rewritten by quest review after each round.

  • Head: 2f2095a

  • Base: origin/main at f3f4cc5

  • Risk: high, The branch changes public controller and binding APIs that downstream applications may compile against, so consumers may need migration even though reverting restores the previous API.

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1dfcc-cfd7-75e1-8793-d48ad864e19e, round 2

  • Score: 9/10, The incremental refactor preserves controller behavior and updates feature wiring and callers consistently, with no actionable defects found in source review; builds and tests were not run as instructed.

  • Raised the risk to high: The branch changes public controller and binding APIs that downstream applications may compile against, so consumers may need migration even though reverting restores the previous API.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 4 commits November 15, 2026 06:39
…moq-congestion-lab

GCC and SCReAMv2 move to the workspace-only moq-congestion-lab crate, BBR3's
delay bound gets a hidden setter, and moq-ffi's MoqCongestionControl becomes
an object with constructors so a new algorithm is additive in every binding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ort feature

doc(hidden) is banned, so the pacer, a packet's GCC probe cluster, and
BBR3's delay bound sit behind moq-congestion's documented lab feature, as
test support does elsewhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w the move

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The congestion selector ships BBR, and new algorithms join it additively feat(congestion)!: BBR ships through the selector, candidates move to moq-congestion-lab Nov 15, 2026
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 15:22

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No blocking issues. One small doc gap is noted below.

Reviewed changes

I reviewed all four commits: the candidates move into a workspace-only crate, the lab test-support feature, and the conversion of the FFI congestion selector from an enum to an object in every binding.

  • moq-congestion-lab crate: GCC and SCReAMv2 move over unchanged except for imports and the probe_cluster accessors. The crate is publish = false, and moq-quic and moq-tokio take it only as a path dev-dependency. It has its own large-MTU window test.
  • lab feature on moq-congestion: this feature gates pub mod pacer, the Packet probe-cluster field and its accessors, and the bbr3::Config::delay_bound setter. The license drops BSD-3-Clause, and the unused tracing dependency is removed.
  • MoqCongestionControl as a uniffi object: it has loss(), delay() and none() constructors and exports Debug/Eq/Hash. MoqQuicConfig.congestion_control becomes Option<Arc<_>>. Dart is regenerated. Go gets builder functions and a generic optional[T]. Kotlin, Python, Swift, OBS C++ and the tests switch to the constructors.
  • Selector docs: moq_tokio::quic::CongestionControl now derives Hash. The docs in the relay config, the C API and the bindings say delay is BBR v3 and the default.
  • Nightly and quests: the rust-test group adds -p moq-congestion-lab, so the GCC benchmark_per_packet still runs and still matches its filter. The completed quest is removed, and the vendor-sync and quic-realtime quests point at the new paths.

I checked locally: cargo check --all-targets passes with no warnings for moq-congestion without lab, moq-congestion with --features lab, and moq-congestion-lab. A grep finds the old enum spellings (CongestionControl.DELAY, kLoss, CongestionControlLoss, and so on) only in historical MIGRATE.md entries.

ℹ️ doc/setup/repository.md doesn't list moq-congestion-lab

AGENTS.md sends contributors and agents to doc/setup/repository.md to find where a feature lives. Its "Congestion controllers and controller tests" row still lists only rs/moq-congestion. After this PR, someone looking for GCC or SCReAMv2 there will look in the wrong crate.

Technical details
# repository.md omits the new lab crate

## Affected sites
- doc/setup/repository.md:21 — the "Congestion controllers and controller tests" row links only `rs/moq-congestion`

## Required outcome
- The row also points to `rs/moq-congestion-lab` as the home of the candidate controllers under test (GCC, SCReAMv2)

Pullfrog  | Fix it ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c08cb90c-4567-495f-8ef3-af4d0967ef7f
Commits

Reviewing files that changed from the base of the PR and between 7678090 and 2f2095a.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 34

  • cpp/obs/src/moq-settings.cpp
  • cpp/obs/test/moq-settings-test.cpp
  • dart/moq/lib/src/aliases.dart
  • dart/moq/test/moq_test.dart
  • dart/moq_ffi/lib/src/moq.dart
  • doc/bin/relay/config.md
  • go/wrapper/client.go
  • go/wrapper/origin.go
  • go/wrapper/reconnect_test.go
  • go/wrapper/types.go
  • kt/moq/src/jvmAndAndroidMain/kotlin/dev/moq/Aliases.kt
  • kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt
  • nix/Cargo.nix
  • py/moq-rs/README.md
  • py/moq-rs/tests/test_server.py
  • quest/m2/congestion-candidates.md
  • quest/m4/quic-realtime.md
  • rs/moq-c/src/api.rs
  • rs/moq-congestion/Cargo.toml
  • rs/moq-congestion/README.md
  • rs/moq-congestion/src/bbr3/mod.rs
  • rs/moq-congestion/src/gcc/mod.rs
  • rs/moq-congestion/src/lib.rs
  • rs/moq-congestion/src/rate.rs
  • rs/moq-congestion/src/scream.rs
  • rs/moq-ffi/src/session.rs
  • rs/moq-ffi/src/test.rs
  • rs/moq-ffi/src/test/rung.rs
  • rs/moq-quic/Cargo.toml
  • rs/moq-tokio/Cargo.toml
  • rs/moq-tokio/src/quic.rs
  • rs/workspace-hack/Cargo.toml
  • sh/gh/nightly.sh
  • swift/Sources/Moq/Aliases.swift

No actionable comments were generated in the recent review.

Walkthrough

The changes add moq-congestion-lab for GCC and SCReAMv2 candidates and restrict related support in moq-congestion with the lab feature. The Rust FFI replaces its congestion-control enum with a native-backed object, and the Dart bindings add corresponding native handle operations. Callers and documentation across several language bindings are updated to use congestion-control constructors or builders. Rust test dependencies and candidate-controller references are updated.

Merge Risk: Minimal · previous review 76780

This change moves experimental GCC and SCReAM controllers into an unpublished lab crate and makes the FFI congestion-control setting an object with loss(), delay() and none() constructors. The binding callers and documentation are updated to match. The BBR-based delay selection, the relay configuration and the wire format are unchanged. No concrete merge-blocking defect was found; the API change is an intentional breaking change, and CI is the remaining check for the generated Go and Swift bindings.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the main change: BBR ships through the congestion-control selector, while GCC and SCReAMv2 candidates compile only behind moq-congestion's lab feature. The raw summary describes a diff…
Description check Passed The description states the goal of the PR: it moves GCC and SCReAMv2 behind a documented lab feature in moq-congestion, makes BBR the shipped selector, converts moq-ffi's MoqCongestionControl enum i…
Full details: Title check

Explanation

The title names the main change: BBR ships through the congestion-control selector, while GCC and SCReAMv2 candidates compile only behind moq-congestion's lab feature. The raw summary describes a different approach (a new moq-congestion-lab crate), but the title matches the PR description and objectives, which describe the lab feature approach and the BBR selector. The title is specific and conventional.

Full details: Description check

Explanation

The description states the goal of the PR: it moves GCC and SCReAMv2 behind a documented lab feature in moq-congestion, makes BBR the shipped selector, converts moq-ffi's MoqCongestionControl enum into an object with constructors, and lists per-language migration steps. Those points match the changeset summaries, which show the Cargo, Rust, FFI, and binding edits. The description is specific and not off-topic.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 09ff23ab-7ec8-455d-a868-2db3cf9faa0c
Commits

Reviewing files that changed from the base of the PR and between ca88fc1 and 7678090.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 86

  • Cargo.toml
  • cpp/obs/src/moq-settings.cpp
  • cpp/obs/test/moq-settings-test.cpp
  • dart/moq/lib/src/aliases.dart
  • dart/moq/test/moq_test.dart
  • dart/moq_ffi/lib/src/moq.dart
  • doc/bin/relay/config.md
  • go/wrapper/client.go
  • go/wrapper/origin.go
  • go/wrapper/reconnect_test.go
  • go/wrapper/types.go
  • kt/moq/src/jvmAndAndroidMain/kotlin/dev/moq/Aliases.kt
  • kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt
  • nix/Cargo.nix
  • py/moq-rs/README.md
  • py/moq-rs/tests/test_server.py
  • quest/m2/congestion-candidates.md
  • quest/m3/vendor-sync/scream.md
  • quest/m3/vendor-sync/webrtc.md
  • quest/m3/webrtc/README.md
  • quest/m4/quic-realtime.md
  • rs/moq-c/src/api.rs
  • rs/moq-congestion-lab/.rustfmt.toml
  • rs/moq-congestion-lab/Cargo.toml
  • rs/moq-congestion-lab/LICENSE-APACHE
  • rs/moq-congestion-lab/LICENSE-MIT
  • rs/moq-congestion-lab/README.md
  • rs/moq-congestion-lab/src/gcc/AUTHORS
  • rs/moq-congestion-lab/src/gcc/LICENSE
  • rs/moq-congestion-lab/src/gcc/PATENTS
  • rs/moq-congestion-lab/src/gcc/alr_detector.rs
  • rs/moq-congestion-lab/src/gcc/api/mod.rs
  • rs/moq-congestion-lab/src/gcc/api/transport/bandwidth_usage.rs
  • rs/moq-congestion-lab/src/gcc/api/transport/mod.rs
  • rs/moq-congestion-lab/src/gcc/api/transport/network_types.rs
  • rs/moq-congestion-lab/src/gcc/api/units/data_rate.rs
  • rs/moq-congestion-lab/src/gcc/api/units/data_size.rs
  • rs/moq-congestion-lab/src/gcc/api/units/frequency.rs
  • rs/moq-congestion-lab/src/gcc/api/units/mod.rs
  • rs/moq-congestion-lab/src/gcc/api/units/time_delta.rs
  • rs/moq-congestion-lab/src/gcc/api/units/timestamp.rs
  • rs/moq-congestion-lab/src/gcc/api/units/unit_base.rs
  • rs/moq-congestion-lab/src/gcc/bench.rs
  • rs/moq-congestion-lab/src/gcc/congestion_window_pushback_controller.rs
  • rs/moq-congestion-lab/src/gcc/delay_based_bwe.rs
  • rs/moq-congestion-lab/src/gcc/delay_increase_detector_interface.rs
  • rs/moq-congestion-lab/src/gcc/experiments/field_trials.rs
  • rs/moq-congestion-lab/src/gcc/experiments/mod.rs
  • rs/moq-congestion-lab/src/gcc/experiments/rate_control.rs
  • rs/moq-congestion-lab/src/gcc/goog_cc_network_control.rs
  • rs/moq-congestion-lab/src/gcc/inter_arrival_delta.rs
  • rs/moq-congestion-lab/src/gcc/link_capacity_estimator.rs
  • rs/moq-congestion-lab/src/gcc/loss_based_bwe_v2.rs
  • rs/moq-congestion-lab/src/gcc/mod.rs
  • rs/moq-congestion-lab/src/gcc/pacing/bitrate_prober.rs
  • rs/moq-congestion-lab/src/gcc/pacing/interval_budget.rs
  • rs/moq-congestion-lab/src/gcc/pacing/mod.rs
  • rs/moq-congestion-lab/src/gcc/probe_bitrate_estimator.rs
  • rs/moq-congestion-lab/src/gcc/probe_controller.rs
  • rs/moq-congestion-lab/src/gcc/remote_bitrate_estimator/aimd_rate_control.rs
  • rs/moq-congestion-lab/src/gcc/remote_bitrate_estimator/bwe_defines.rs
  • rs/moq-congestion-lab/src/gcc/remote_bitrate_estimator/mod.rs
  • rs/moq-congestion-lab/src/gcc/robust_throughput_estimator.rs
  • rs/moq-congestion-lab/src/gcc/send_side_bandwidth_estimation.rs
  • rs/moq-congestion-lab/src/gcc/tests.rs
  • rs/moq-congestion-lab/src/gcc/trendline_estimator.rs
  • rs/moq-congestion-lab/src/lib.rs
  • rs/moq-congestion-lab/src/scream.rs
  • rs/moq-congestion/Cargo.toml
  • rs/moq-congestion/README.md
  • rs/moq-congestion/src/bbr3/mod.rs
  • rs/moq-congestion/src/lib.rs
  • rs/moq-congestion/src/pacer.rs
  • rs/moq-congestion/src/rate.rs
  • rs/moq-ffi/src/session.rs
  • rs/moq-ffi/src/test.rs
  • rs/moq-ffi/src/test/rung.rs
  • rs/moq-quic/Cargo.toml
  • rs/moq-quic/src/tests/probe.rs
  • rs/moq-quic/src/tests/scream.rs
  • rs/moq-tokio/Cargo.toml
  • rs/moq-tokio/src/quic.rs
  • rs/moq-tokio/tests/integration/scream.rs
  • rs/workspace-hack/Cargo.toml
  • sh/gh/nightly.sh
  • swift/Sources/Moq/Aliases.swift
Files with no reviewable changes: 1

  • quest/m2/congestion-candidates.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision (2026-11-15, /quest-complete): no new crate. GCC and SCReAMv2 stay in moq-congestion as modules compiled only behind a feature (✅ the existing documented lab feature, rejected: the workspace-only moq-congestion-lab crate). This supersedes the quest's recorded rejection of "ship them behind an unstable feature", which paraphrased the #8764 pick; the pick itself only asked that GCC and SCReAM not be selectable until tested and that new algorithms join additively.

(Written by Opus 5.5)

kixelated and others added 2 commits November 15, 2026 11:50
…the lab feature

The maintainer rejected a separate crate: the candidates are modules of
moq-congestion again, compiled only with its `lab` test-support feature, which
also gates BBR3's delay-bound setter. The pacer and a packet's probe cluster
return to crate-private, the vendored WebRTC files keep their LICENSE and
PATENTS beside them, and the license expression covers BSD-3-Clause again.
moq-quic's and moq-tokio's comparisons enable `lab` as a dev-dependency, and
the nightly GCC benchmark keeps its original series.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title feat(congestion)!: BBR ships through the selector, candidates move to moq-congestion-lab feat(congestion)!: BBR ships through the selector, candidates compile behind moq-congestion's lab feature Nov 15, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Applied the maintainer decision in 2f2095a: rs/moq-congestion-lab is gone. GCC (src/gcc/) and SCReAMv2 (src/scream.rs) are moq-congestion modules again, compiled only with the existing lab feature, which also gates BBR3's delay-bound setter. The vendored WebRTC LICENSE/PATENTS/AUTHORS stay beside the files, the license is back to (MIT OR Apache-2.0) AND BSD-3-Clause, moq-quic's and moq-tokio's tests and the nightly GCC benchmark series are back where main had them, and the decision is recorded in quest/m4/quic-realtime.md (the PR deletes quest/m2/congestion-candidates.md, which it completes).

This also answers Pullfrog's note about doc/setup/repository.md: with no lab crate, its rs/moq-congestion row is accurate again.

(Written by Claude Opus 5.5 with medium)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Since the last review, the branch merged main and dropped the workspace-only moq-congestion-lab crate. GCC and SCReAMv2 are modules of moq-congestion again, compiled only with its lab feature.

  • Candidates behind lab: gcc and scream are #[cfg(feature = "lab")] modules again. pacer stays crate-private because BBR3 and Cubic also use it. Packet's probe_cluster field is pub(crate) and compiled only with lab, so the accessor pair from the previous round is no longer needed.
  • Optional tracing: lab = ["dep:tracing"], and only GCC logs. Hakari added tracing to workspace-hack to match.
  • License and vendored notices: these are unchanged from main. The license is (MIT OR Apache-2.0) AND BSD-3-Clause, and src/gcc/{LICENSE,PATENTS,AUTHORS} ship with the crate.
  • Dev-dependency wiring: moq-quic and moq-tokio enable lab through their moq-congestion dev-dependency. Their test code matches main again.
  • Large-MTU test: the large-MTU window test uses a Vec of factories, and the GCC and SCReAM entries are gated by cfg.
  • Nightly: rust-test adds moq-congestion/lab to --features, so benchmark_per_packet keeps its original series name.
  • README and quests: the moq-congestion README describes the feature. The quic-realtime quest records the maintainer's decision, and the vendor-sync quests no longer change.

I ran cargo check --all-targets -p moq-congestion locally, with and without --features lab. Both pass with no warnings. No references to moq-congestion-lab or moq_congestion_lab remain. The previous review's note about doc/setup/repository.md no longer applies now that the lab crate is gone.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 9016f61 Nov 15, 2026
6 checks passed
@kixelated
kixelated deleted the quest/m2/congestion-candidates branch November 15, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant