Repository navigation
Replay the publisher's largest group at tune-in - #8844
Conversation
Quest-Claim: e7d40cab5bebcd6c
…rgest group Each trace carries the publisher's largest group as the subscription began (version 4), and the replay answers it from the subscriber's largest() as a wire subscriber does, so the consumer reports the join's skipped backlog. relay-mic-rtt40's target p95 falls from 320 to 120 ms and its row is re-budgeted. The recorder and the capture observer record the field; the checked-in traces derive it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed the full diff: the replay's tune-in largest, the trace schema bump, the recorder and capture plumbing, the re-derived traces and the re-budgeted relay-mic-rtt40 row.
answeringproxy (js/watch/src/audio/replay.ts) — The firstlargest()call returns the trace's value. Later calls return only groups newer than it. Everything else passes through to the local subscriber, with methods bound to the target so private fields still resolve. This matches howjs/hang'sContainer.Consumerreadslargest(): once, afterinfo()or the first group andstart().joined()(capture.ts) — Mirrors the consumer's join read and is shared byrecorder.ts(written into the trace, andrecord.tsrefuses a trace without it) and the--captureobserver (Capture.largest()→environment.largest).- Trace schema v4 — Adds a required
largest, andreplay.tsnow accepts only version 4. I re-ran the stated derivation on every checked-in trace: the newest group whose earliest frame timestamp plus the trace's minimumat - timestamplands at or before the first arrival. It reproduces each value:bursty-aac37665,local-aac42,relay-bbb10065,relay-mic-rtt408994,relay-micandrelay-mic-stall32142. - Budgets — Only
relay-mic-rtt40moves, and the note records the before and after values. Replay rows are graded exactly, so CI's replay lane checks these numbers.
claude-opus-5-5 | 𝕏
|
quest land watch: the merge queue removed this pull request at fd9641d because its The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.
…th \/var\/cache\/github\-runner\-work\/_temp\/git\-credentials\-87a46f19\-de7e\-4002\-a812\-c468cee1ca63\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/var/cache/github-runner-work/moq/moq/.git/worktrees/*.path
/var/cache/github-runner-work/_temp/git-credentials-87a46f19-de7e-4002-a812-c468cee1ca63.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/var/cache/github-runner-work/moq/moq/.git/worktrees/*.path \/var\/cache\/github\-runner\-work\/_temp\/git\-credentials\-87a46f19\-de7e\-4002\-a812\-c468cee1ca63\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git.path
/github/runner_temp/git-credentials-87a46f19-de7e-4002-a812-c468cee1ca63.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git.path \/github\/runner_temp\/git\-credentials\-87a46f19\-de7e\-4002\-a812\-c468cee1ca63\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git/worktrees/*.path
/github/runner_temp/git-credentials-87a46f19-de7e-4002-a812-c468cee1ca63.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git/worktrees/*.path \/github\/runner_temp\/git\-credentials\-87a46f19\-de7e\-4002\-a812\-c468cee1ca63\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Removing credentials config '/var/cache/github-runner-work/_temp/git-credentials-87a46f19-de7e-4002-a812-c468cee1ca63.config'
##[endgroup]
Prepare all required actions
Getting action download info
Download action repository 'taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39' (SHA:cfdb7ed4ccc7c7dce37759eae89dc5674b469b39)
##[group]Run ./.github/actions/just
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Use the NixOS runner toolchain;id=__self.__run]
##[group]Run just --version
�[36;1mjust --version�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
just 1.59.0
##[end-action id=__self.__run;outcome=success;conclusion=success;duration_ms=9]
##[start-action display=Run taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39;id=__self.__taiki-e_install-action]
##[end-action id=__self.__taiki-e_install-action;outcome=skipped;conclusion=skipped;duration_ms=0]
Prepare all required actions
Getting action download info
Download action repository 'jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de' (SHA:88acf2bb50552c7c508cbac13e5f8c576b95b1de)
##[group]Run ./.github/actions/rust-cache
with:
write: true
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Require main's merge queue on self-hosted runners;id=__self_2.__run]
##[end-action id=__self_2.__run;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cache credentials;id=__self_2.__run_2]
##[end-action id=__self_2.__run_2;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__self_2.mbx]
##[group]Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de
with:
version: 1.30.0
backend: local
remote-url: s3://mbx-moq-dev
namespace: Linux-X64
github-token: ***
cache-generation: v1
github-cache-mode: target
isolate-objects-cache: false
clean-target-before-export: false
save-on-workflow-dispatch: false
save-on-pull-request: false
save-on-protected-branch: false
working-directory: .
cache-links: auto
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
##[endgroup]
Set up mbx 1.30.0
##[end-action id=__self_2.mbx;outcome=success;conclusion=success;duration_ms=483]
##[start-action display=Drop another mbx version's private state;id=__self_2.__run_3]
##[group]Run : "${VERSION:?the mbx action reported no version}"
�[36;1m: "${VERSION:?the mbx action reported no version}"�[0m
�[36;1mstamp="$HOME/.cache/moq-mbx-versions$RUNNER_WORKSPACE"�[0m
�[36;1mif [ "$(cat "$stamp" 2>/dev/null)" != "$VERSION" ]; then�[0m
�[36;1m mbx clean --under "$RUNNER_WORKSPACE"�[0m
�[36;1m mkdir -p "${stamp%/*}"�[0m
�[36;1m printf '%s\n' "$VERSION" > "$stamp"�[0m
�[36;1mfi�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
VERSION: 1.30.0
##[endgroup]
##[end-action id=__self_2.__run_3;outcome=success;conclusion=success;duration_ms=8]
##[start-action display=Sweep the cache before building;id=__self_2.__run_4]
##[group]Run auto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)
�[36;1mauto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)�[0m
�[36;1mif [ "$auto" != "false" ]; then�[0m
�[36;1m echo "::error::the runner's global mbx config must set gc.auto = false, but it reads '$auto' without MBX_* variables"�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mmbx gc�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
##[end-action id=__self_2.__run_4;outcome=success;conclusion=success;duration_ms=663]
##[start-action display=Check the cache;id=__self_2.__run_5]
##[end-action id=__self_2.__run_5;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cargo shim;id=__self_2.__run_6]
##[group]Run mbx setup --yes
�[36;1mmbx setup --yes�[0m
�[36;1mshim=$(mbx setup --status 2>/dev/null | sed -n '1s/.*: //p' || true)�[0m
�[36;1mif [ ! -e "$shim" ]; then�[0m
�[36;1m echo "::error::mbx setup installed no Cargo shim: $(mbx setup --status 2>&1)"�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mecho "${shim%[/\\]*}" >> "$GITHUB_PATH"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
refreshed the Cargo shim at /var/cache/github-runner-home/.local/share/mbx/bin/cargo
##[end-action id=__self_2.__run_6;outcome=success;conclusion=success;duration_ms=132]
##[group]Run rm -rf target/cargo-timings
�[36;1mrm -rf target/cargo-timings�[0m
�[36;1mnix develop --command just ci "$BASE"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash -e {0}
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'fallback'.
Pass '--accept-flake-config' to trust it
CI_STRICT=1 NEXTEST_PROFILE=ci sh/dispatch.sh ci "$BASE"
changed: base 9db74b63a96d8e906708ad40e9ce721b3e95f573
ci: check biome started
ci: check quest started
ci: check shell started
ci: check quest failed in 2s
##[group]check quest
Dev-shell quest: /nix/store/m5h6c4dxfm4djgbmgva7hcvrrf0nk203-quest-3122d76/bin/quest
quest: quest/m0/interop-green/replacement-audio.md:32: link does not resolve: /quest/m2/audio-playout/replay-largest.md
##[endgroup]
ci: check shell cancelled in 2s
ci: check biome cancelled in 2s
##[group]check shell
##[endgroup]
##[group]check biome
uv run --no-project python sh/js/install.py frozen
[0.04ms] ".env"
bun install v1.4.4 (38afee6c8)
Resolving dependencies
Resolved, downloaded and extracted [1]
error: recipe `biome` failed on line 143 with exit code 143
##[endgroup]
##[error]ci: check quest failed
ci: wall and CPU seconds per module
2 0 check biome (cancelled)
2 2 check quest (failed)
2 0 check shell (cancelled)
2 3 whole run
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
name: cargo-timings
path: target/cargo-timings/cargo-timing-*.html
if-no-files-found: ignore
retention-days: 14
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
BASE: 9db74b63a96d8e906708ad40e9ce721b3e95f573
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
No files were found with the provided path: target/cargo-timings/cargo-timing-*.html. No artifacts will be uploaded.
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__0bbebf50-7826-41b4-9fd5-cf5549e38ff1.mbx]
##[end-action id=__0bbebf50-7826-41b4-9fd5-cf5549e38ff1.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/d9c6b131-a961-478a-bb8c-313754fd9566' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
Cleaning up orphan processes
(written by quest land watch) |
|
codex, gpt-6.1-sol, medium effort land fixer note:
(written by codex, gpt-6.1-sol, medium effort) |
|
codex, gpt-6.1-sol, medium effort land fixer: ci: check quest failed in 2s ##[group]check quest Dev-shell quest: /nix/store/m5h6c4dxfm4djgbmgva7hcvrrf0nk203-quest-3122d76/bin/quest quest: quest/m0/interop-green/replacement-audio.md:32: link does not resolve: /quest/m2/audio-playout/replay-largest.md (written by codex, gpt-6.1-sol, medium effort) |
Maintainer decision (2026-11-15, /quest-complete): reword the link to the replay-largest quest this PR deletes, so quest check passes on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the last review at fd9641d, the branch merged main and added one docs commit. The PR's own code and traces are unchanged.
- Updated the quest cross-reference —
quest/m0/interop-green/replacement-audio.mdnow cites #8844 instead of linking toquest/m2/audio-playout/replay-largest.md, which this PR deletes. That keeps the link from breaking.
claude-opus-5-5 | 𝕏

Finishes quest/m2/audio-playout/replay-largest.md (file deleted here).
Summary
The audio-quality replay now measures a join's backlog the way a live player does. Since moq-dev/moq#8761 both consumers report a group they skip unread as join backlog when it is at or below the publisher's largest group at subscribe time, but the replay's local track only learned its largest from the first group to land (
relay-mic-rtt40's stale tune-in frame, 7499), so nothing was reported.Tracegains a requiredlargestand goes to version 4. Every checked-in trace carries one, derived: the newest group whose first frame's media timestamp plus the trace's lowest lag falls at or before the first arrival (relay-mic-rtt40: 8994;bursty-aac37665,local-aac42,relay-bbb10065,relay-micandrelay-mic-stall32142). Eachsourcenames the derivation; no arrival row changed.capture.tsjoined()reads the subscription'slargest()the wayjs/hang's consumer does (after the info or first group shows it established andstart()resolved).recorder.tsandrecord.tswrite it into the trace; the--captureobserver exposes it asCapture.largest()and the probe reports it asenvironment.largest, so the diagnosing-live-rows recipe has it.js/watch/src/audio/replay.ts:Options.largestwraps the local subscriber solargest()answers the trace's value first, then each newer group as it lands, and delegates everything else.test/audio-quality/clients/js/replay.tspasses the trace's.budgets.json: onlyrelay-mic-rtt40moved, and is re-budgeted; the note drops the sentence about the stale tune-in frame.test/audio-quality/README.mddocuments the field, the capture and the derivation.relay-mic-rtt40The other five replay rows are unchanged to the digit.
Public API
No public API or wire change.
@moq/netand the container consumer are untouched. Internal test support only:Options.largestandansweringinjs/watch/src/audio/replay.ts(@internal), the trace schema, and the harness's recorder.Decisions
Choices a review can undo, taken on the maintainer's behalf (AFK):
replay()'sOptions.largestis optional (omitted keeps the track's own largest), whileTrace.largestis required. Synthetic unit-test traces have no tune-in to model; the checked-in traces always pass it. Alternative: require it inOptionstoo and give every synthetic test a value.answeringis exported and unit-tested directly rather than through an end-to-end join scenario: the join's effect needs the cursor to skip ahead of late backlog (the shape ofrelay-mic-rtt40's first seconds), and the harness row already grades that and fails on a regression.Proxywraps the local subscriber (aSubscriberhas private fields, so prototype delegation breaks); methods are bound to the target.Environment.largestthroughprobe.ts, so a--capturerow carries the join for the conversion recipe;Capturekeeps the first subscription's value across a rerun.record.tsthrows if the subscription never reports a largest, rather than writing a trace without one;replay.tsaccepts only version 4.relay-mic-rtt40row (target p95 120).Validation
just test audio-quality --replays --enforce: within budget; the six rows' table matches the quest's local measurement.bun test js/watch/src/audio/replay.test.ts(newansweringtest) andtest/audio-quality/clients/js/src/capture.test.ts(new join test: a later live group does not moveCapture.largest());just checkandjust fixpass.relay-mic-rtt40withlargest9047 instead of 8994 replays to the same 120 ms target.just test audio-quality-record(needs the public relay and a person at the microphone), sorecorder.ts'sjoined()is covered by the capture test only.Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (arm B)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: fd9641d
Base: origin/main at ca88fc1
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1dfa8-52ed-7973-a26e-5d856c4df8d1, round 1Score: 9/10,
No actionable defects were found in the replay and recording changes, but validation was source-only with no builds or tests run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none