Skip to content

The release line returns QMux receive credit - #8802

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/release-qmux-credit
Nov 16, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/release-qmux-credit

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/release-qmux-credit.md. The work itself is the release backport moq-dev/moq#8808 (qmux 0.5.4, @moq/qmux ^0.3.5, @moq/net 0.4.8); this PR is the main-side checkpoint, as in moq-dev/moq#7596. The quest is finished: #8808 and release-plz #8866 merged, and the publications are out.

Summary

Decisions

The maintainer accepted both recorded decisions:

Impact

Quest documents only. No public API or wire change here; #8808 reports its own (none).

Validation

Registries confirmed: crates.io has moq-relay 0.17.17 (depends on qmux ^0.5.4 and moq-tokio ^0.19.37), moq-tokio 0.19.37, and qmux 0.5.4; npm has @moq/qmux 0.3.5 and @moq/net 0.4.8. nix develop --command bash sh/quest.sh check: 537 documents ok. Behavior is exercised on #8808: the publisher direction fails on 0.5.3 after 7 to 9 mid-group cancels and passes 120 on 0.5.4.

Review

Rewritten by quest review after each round.

  • Head: e500d0e

  • Base: origin/main at aa6388c

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e3f9-aa1e-71d1-bed0-1d5883143249, round 1

  • Score: 10/10, This documentation-only cleanup removes a completed quest and updates all remaining references to its recording PR, with no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Models

Size: S
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, S, arm B)

🤖 Generated with Claude Code

(Written by Claude Sonnet 5.5)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 10:49

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the full diff (3 quest documents, no code).

  • Quest deleted: removes quest/m0/release-qmux-credit.md, now that #8808 carries the record.
  • Links repointed: quest/m3/release/cut.md and quest/m3/send-credit-stalls.md now link to #8808, and cut.md says @moq/qmux 0.3.5 is published. A repo-wide grep finds no remaining references to the deleted file.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release plan for the QMux credit fix was deleted. The publication note for @moq/qmux 0.3.5 now attributes the version to the release-line credit fix and links to PR 8808. The related receive-credit fix reference also links to PR 8808.

Merge Risk: Minimal · up to e500d

This documentation-only change removes a completed release plan and updates references to point to the release backport. It has no runtime impact and is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: the release line now returns QMux receive credit. The changeset deletes the completed release-qmux-credit quest document and repoints references to PR 8808, which is …
Description check Passed The description is related to the changeset. It states that the PR finishes the release-qmux-credit quest, deletes that document, repoints inbound links in two quest files to #8808, and updates the cu…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the release line now returns QMux receive credit. The changeset deletes the completed release-qmux-credit quest document and repoints references to PR 8808, which is the release backport that carries the credit fix. The title does not name the document cleanup, but it describes the work the quest tracked and is related to the changeset.

Full details: Description check

Explanation

The description is related to the changeset. It states that the PR finishes the release-qmux-credit quest, deletes that document, repoints inbound links in two quest files to #8808, and updates the cut.md publication wording. It also lists validation and registry checks, which match the objectives.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1788f203-7220-478b-b8bb-dc79c6d1ad9d
Commits

Reviewing files that changed from the base of the PR and between aa6388c and e500d0e.

Files selected for processing: 3

  • quest/m0/release-qmux-credit.md
  • quest/m3/release/cut.md
  • quest/m3/send-credit-stalls.md
Files with no reviewable changes: 1

  • quest/m0/release-qmux-credit.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 8f8eec3 Nov 16, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/release-qmux-credit branch November 16, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant