Skip to content

quest(mbx-r2-verify): record the first full-history and mbx 1.30.0 Nightlies - #8713

Merged
kixelated merged 2 commits into
mainfrom
quest-complete/mbx-r2-verify
Nov 14, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-complete/mbx-r2-verify

Conversation

@kixelated

@kixelated kixelated commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Two waits in mbx-r2-verify have cleared. One asked whether Windows still misses most looked-up keys on mbx 1.30.0. The other asked whether full history (#8342) changed each Linux Rust-cache job's hits against its depth-1 baseline.

Approach

This PR records the numbers in the quest's Plan, with run links. The source is each Rust-cache job's mbx[cache]: object cache lines in five scheduled Nightlies:

  • the three depth-1 baselines: 42659882487, 42842827718 and 43041909115

  • 43250182795, on 11-12

  • 43447849289, on 11-13

  • Windows still misses most looked-up keys. On 11-13 the workspace build had 92 hits, 1,062 misses and 13 not looked up. mbx analyze files every miss under "no earlier recording", so it names no cause. The download budget is the leading suspect. The one good night, 846 hits on 11-05, downloaded 8.7 GiB with no refusals. Every night since 11-08 hit the 10 GiB cap and got 92 to 163 hits. #8631 lifted the cap to 20 GiB after this run.

  • Linux: no job regressed because of full history, but hits didn't rise either. Not looked up fell to near 0, but every job still spends its 5 GiB budget on prefetch. On 11-12 the summed hits were 10,990, inside the depth-1 range of 9,748 to 11,065. Ten jobs were above their own range, 16 inside it and 3 below it.

  • 11-13 is an expiry wave. NoSuchKey prefetch failures went from 20 to 5,270 across 38 jobs. That includes 2,837 on macOS, which never reaches its budget. The 7-day rule expired a week of uploads at once, so 11-13 cannot isolate full history or mbx 1.30.0.

The quest also changes in four ways:

  • It drops both cleared waits and keeps the 2026-11-26 R2 size and request-count wait.
  • It drafts a fallback Windows issue for jdx/mr-boxington under the Plan. The draft follows upstream's CONTRIBUTING.md and AGENTS.md: real use only, logs rather than source, and their AI-disclosure line.
  • It records the maintainer's 2026-11-13 decision (/quest-complete): after the first scheduled Nightly past ci(rust-cache): lift mbx's download budget so restores stop re-uploading #8631, add the Windows numbers to jdx/mr-boxington#950 only if they add something, and file the drafted issue only if Windows still misses most keys with no download-budget refusals. Rejected: filing now; posting nothing upstream. A GitHub Actions: wait on that Nightly says what to do in each case.
  • It lists what the first nights after ci(rust-cache): lift mbx's download budget so restores stop re-uploading #8631 must show. If Linux full history still doesn't beat depth 1 once restores stop failing, the next step is a quest that returns those jobs to fetch-depth: 1.

Choices made without asking

Validation

No code changes. The figures were extracted by script from every job log of the five runs, plus the 11-05 and 11-08 Windows jobs. The extracted baselines match those the quest had already recorded: doctest 124 / 502 / 150, Media 58 / 84, and Audio quality 74, 77, 0 and so on. quest check and quest check --base origin/main pass.

Impact

Public API: none. Wire: none.

Alternatives

File the Windows issue now on the 11-13 evidence, or post nothing upstream. The maintainer rejected both.

Follow-ups

None new. The depth-1 revert is a conditional step in the quest's Plan.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Skipped on head 0b421f8d558c3af2752f9dd09ed733361113b1a1: since the reviewed head 06fe71ca2367 the change only edits the quest. It records the maintainer's 2026-11-13 upstream-report decision and swaps the filing-approval Waiting item for a GitHub Actions wait. quest check passes.

Previous round, on 06fe71ca2367: Codex, gpt-6.1-sol, medium effort, session 01a1d82f-07f5-7f83-a720-a6b193033ea6, round 1, score 9/10, no findings.

…ghtlies

Windows still misses most looked-up keys, with the download budget the
leading suspect; Linux full history removed "not looked up" without
changing hits while the 5 GiB budget binds. Drops the two cleared waits
and asks the maintainer to approve filing the drafted upstream issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 14, 2026 03:52
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67d126e3-1834-45b0-88ce-e38e1f1d9463
Commits

Reviewing files that changed from the base of the PR and between 6f2f3ff and 0b421f8.

Files selected for processing: 1

  • quest/m0/ci/mbx-r2-verify.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 14, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the single docs-only change to quest/m0/ci/mbx-r2-verify.md.

  • Evidence recorded: the 11-12 and 11-13 Nightly findings (Windows misses, Linux full-history comparison, 11-13 expiry wave) with run links and a per-job hits table.
  • Waits updated: both cleared waits are dropped. A Maintainer: approval wait for filing the upstream issue is added.
  • Plan additions: a draft upstream issue and the checks the first nights after #8631 must make.

I read the diff only and did not re-derive the figures from the run logs. The text is internally consistent, and the links and the conditional follow-up are coherent.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated removed this pull request from the merge queue due to a manual request Nov 14, 2026
@moq-bot

moq-bot Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at 06fe71c because kixelated removed it (manual).

Its head has moved to 0b421f8 since, and a push by anyone but the land fixer ends the pick: the watcher leaves this pull request alone until a maintainer enqueues it again.

(written by quest land watch)

@kixelated
kixelated enabled auto-merge November 14, 2026 03:59

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the delta since the prior pullfrog review (06fe71c), which touches only quest/m0/ci/mbx-r2-verify.md.

  • Recorded the upstream decision: added the maintainer's 2026-11-13 call on when to post to jdx/mr-boxington#950 and when to file the drafted issue.
  • Replaced the approval wait: the Maintainer: item became a GitHub Actions: wait on the first Nightly after #8631, with a branch for each outcome.
  • Reworded the draft and checklist: the draft issue is now the fallback, and the Windows checklist item points at that wait.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 4fd4392 Nov 14, 2026
11 checks passed
@kixelated
kixelated deleted the quest-complete/mbx-r2-verify branch November 14, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant