Skip to content

quest: plan the uring error and live-history demand follow-ups - #8658

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/net-followups
Nov 13, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/net-followups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#8642 and #8643 each left follow-ups that no quest owned.

Approach

Two new m1 quests:

  • quest/m1/uring-io-error.md [XS]: moq_uring::Error::Io prints its cause twice under {:#}.
  • quest/m1/live-history-demand.md [S]: check whether a JS live reader with no ranges, combined with a history reader, loses the history floor ([{}] demand). It requires lite07-fetch, which rewrites that range code.

Decisions

Follow-ups

None.

Review

Skipped on head 20b8778: quest-only plan the maintainer settled in this session.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 13, 2026 18:53
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a5930242-eb42-4bde-b04b-7602c2a49a95
Commits

Reviewing files that changed from the base of the PR and between 4486b7a and 20b8778.

Files selected for processing: 2

  • quest/m1/live-history-demand.md
  • quest/m1/uring-io-error.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 13, 2026 18:53

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: two new m1 quest files; the diff has no code.

  • live-history-demand.md: plans a test of whether a JS live reader with no ranges, paired with a history reader, keeps the history floor. The quest links to lite07-fetch.md, which exists.
  • uring-io-error.md: plans removing the duplicated {0} from Error::Io's message. rs/moq-uring/src/error.rs:13 has the #[from] variant the plan describes.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit c62db6c Nov 13, 2026
5 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/net-followups branch November 13, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant