Repository navigation
feat(moq-relay): restart beside the draining relay without dropping sessions #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8da8349
chore(quest): claim quest/m3/relay-restart.md
kixelated 17e711a
feat(moq-sock): a reuseport group can hold a successor's generation
kixelated 5ba834e
feat(moq-net): a waited restart redials once to find a replacement
kixelated 251de15
feat(moq-tokio): serve a caller's reuseport group and stream sockets
kixelated b74213b
feat(moq-sock): steer a group's generation from a handle the relay keeps
kixelated dd8264a
feat(moq-relay): hand every socket to the relay that replaces it
kixelated d9bc628
docs(moq-relay): upgrade a relay in place under systemd and NixOS
kixelated 0173325
fix(moq-relay): build the handoff's worker group off Linux too
kixelated 9ade0c5
test(moq-net): model a waited restart's single redial
kixelated f60afe9
test(moq-net): move the reconnect model's sync commit to this branch'…
kixelated d769776
test(moq-relay): the old relay outlives a new one that dies mid-handoff
kixelated bfc8c01
fix(moq-relay): refuse a handoff that cannot hand on the cluster's di…
kixelated 34e7130
fix(moq-relay): a handoff stand-in passes SIGUSR1 to its relay
kixelated dc0a0c8
Merge origin/main into quest/m3/relay-restart
kixelated 69ef3b3
feat(moq-net): Restart::Handoff redials once off a healthy session; W…
kixelated 62a64d3
chore(nix): regenerate Cargo.nix after merging main
kixelated 2db695f
fix(moq-sock,moq-quic): reset a gone generation's connections after a…
kixelated 6bfd5e2
fix(moq-quic): use is_multiple_of
kixelated ddb13e1
Merge remote-tracking branch 'origin/main' into t3/relay-restart-hand…
kixelated 21d4277
fix(moq-relay): a relay no successor takes over from drains; review f…
kixelated 8a33fb7
Merge origin/main into quest/m3/relay-restart
kixelated e9238c7
chore(verify): move the reconnect model's sync commit to the base
kixelated b3a49b0
quest: record the maintainer's picks for relay-handoff-routes
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Upgrade in place: `systemctl restart moq-relay` starts the new relay beside | ||
| # the old one, which hands over its sockets and drains. Needs `[runtime] workers` | ||
| # in relay.toml. Install as /etc/systemd/system/moq-relay.service.d/handoff.conf, | ||
| # then run `systemctl daemon-reload`. See https://doc.moq.dev/setup/prod#upgrades. | ||
| [Service] | ||
| ExecStart= | ||
| ExecStart=/usr/bin/moq-relay --handoff-supervise /etc/moq-relay/relay.toml | ||
| Environment=MOQ_HANDOFF_SOCKET=/run/moq-relay/handoff.sock | ||
| # Only the stand-in main process is signaled: on a restart it exits and leaves | ||
| # its relay draining, and on a stop it passes SIGTERM to the relay. A relay no | ||
| # successor takes over from drains once drain_timeout passes. | ||
| KillMode=process | ||
|
kixelated marked this conversation as resolved.
Resolved
|
||
| RestartKillSignal=SIGUSR2 | ||
| # The handoff socket lives here and must outlive the restart. | ||
| RuntimeDirectoryPreserve=restart | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.