Skip to content

test(max-age): the JS subscriber expects lite-07 to carry the publisher's max age - #8572

Merged
kixelated merged 1 commit into
mainfrom
fix/max-age-lite-js
Nov 12, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/max-age-lite-js

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Scheduled Interop run 43260674067 failed "Optional publisher retention" (just test max-age) deterministically:

AssertionError: moq-lite-07-wip track 1
0 !== undefined
  at test/max-age/client.ts:53:11

moq-dev/moq#8443 put moq-lite-07-wip back into max_age_relay_javascript once js/net spoke the lite-07 route layer. The JS subscriber still asserted that every track arrives with no max age, which was true only while the test ran moq-transport alone: lite carries the publisher's max age, and the Rust subscriber in the same test already expects it.

Approach

The JS subscriber expects the published age on lite (null, 0, 30 s) and none on moq-transport, matching the Rust side and test/max-age/README.md.

Impact

  • Public API: none. Wire: none.

Caused by

  • moq-dev/moq#8443 - re-enabled lite-07 in the JS max-age test without updating the JS subscriber's moq-transport-only expectation.

Validation

  • just test max-age: 2 passed (max_age_relay_rust, max_age_relay_javascript), covering lite-07, draft 18, and draft 22 with JS publishing and subscribing. The scheduled run above is the failing baseline on main's content.
  • biome check test/max-age/client.ts: clean.

Models

  • Size: XS
  • Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: c932425

  • Base: origin/main at bec81e4

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d108-b85b-7111-b2f5-2ddafd858254, round 1

  • Score: 10/10, The narrowly scoped assertion correction matches lite's max-age propagation, preserves the IETF expectation, and is consistent with the Rust sibling test; no tests were run, as instructed.

  • Findings: none

…er's max age

#8443 returned moq-lite-07-wip to max_age_relay_javascript, but the JS
subscriber still asserted every track arrives without a max age, true only
of moq-transport. Expect the published age on lite, as the Rust side does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 18:34

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the single-file change to the JS subscriber in test/max-age/client.ts.

  • Lite-aware max age assertion: the subscriber now compares each track's maxAge against the published age (null, 0, 30 s) when the protocol starts with moq-lite-, and still expects none on moq-transport. null maps to undefined through age?.asMillis(), which matches the passing track 0 in the reported failure.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The max-age test now checks each configured age for each subscription. For moq-lite-* protocols, it expects the configured age in milliseconds. For other protocols, it expects undefined. The comment now states that moq-transport does not send MAX_CACHE_DURATION.

Merge Risk: Minimal · up to c9324

This is a test-only change that aligns the JavaScript max-age expectation with the Rust test and the README. It does not affect production behavior, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the test change: the JS subscriber's max-age expectation for lite-07 is updated to expect the publisher's max age. The raw summary confirms the change in test/max-age/client.ts for moq…
Description check Passed The description explains the failing scheduled Interop run and the cause: the JS subscriber asserted no max age for every track after lite-07 was re-enabled. It describes the fix, which expects the pu…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the test change: the JS subscriber's max-age expectation for lite-07 is updated to expect the publisher's max age. The raw summary confirms the change in test/max-age/client.ts for moq-lite-* protocols, with moq-transport still expected to report none. The title is specific and matches the main change. It is slightly long at 81 characters.

Full details: Description check

Explanation

The description explains the failing scheduled Interop run and the cause: the JS subscriber asserted no max age for every track after lite-07 was re-enabled. It describes the fix, which expects the published age on lite and none on moq-transport. It also lists validation steps. This is directly related to the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 27612016-484b-44af-85c4-f6a5ac9e2f53
Commits

Reviewing files that changed from the base of the PR and between bec81e4 and c932425.

Files selected for processing: 1

  • test/max-age/client.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit e29804c Nov 12, 2026
7 checks passed
@kixelated
kixelated deleted the fix/max-age-lite-js branch November 12, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant