Repository navigation
test(max-age): the JS subscriber expects lite-07 to carry the publisher's max age - #8572
Conversation
…er's max age #8443 returned moq-lite-07-wip to max_age_relay_javascript, but the JS subscriber still asserted every track arrives without a max age, true only of moq-transport. Expect the published age on lite, as the Rust side does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the single-file change to the JS subscriber in test/max-age/client.ts.
- Lite-aware max age assertion: the subscriber now compares each track's
maxAgeagainst the published age (null, 0, 30 s) when the protocol starts withmoq-lite-, and still expects none on moq-transport.nullmaps toundefinedthroughage?.asMillis(), which matches the passing track 0 in the reported failure.
claude-sonnet-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe max-age test now checks each configured age for each subscription. For Merge Risk:
|

Problem
Scheduled Interop run 43260674067 failed "Optional publisher retention" (
just test max-age) deterministically:moq-dev/moq#8443 put
moq-lite-07-wipback intomax_age_relay_javascriptonce js/net spoke the lite-07 route layer. The JS subscriber still asserted that every track arrives with no max age, which was true only while the test ran moq-transport alone: lite carries the publisher's max age, and the Rust subscriber in the same test already expects it.Approach
The JS subscriber expects the published age on lite (
null, 0, 30 s) and none on moq-transport, matching the Rust side andtest/max-age/README.md.Impact
Caused by
Validation
just test max-age: 2 passed (max_age_relay_rust,max_age_relay_javascript), covering lite-07, draft 18, and draft 22 with JS publishing and subscribing. The scheduled run above is the failing baseline on main's content.biome check test/max-age/client.ts: clean.Models
🤖 Generated with Claude Code
(Written by Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: c932425
Base: origin/main at bec81e4
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d108-b85b-7111-b2f5-2ddafd858254, round 1Score: 10/10,
The narrowly scoped assertion correction matches lite's max-age propagation, preserves the IETF expectation, and is consistent with the Rust sibling test; no tests were run, as instructed.Findings: none