Skip to content

quest: drop runs are already pruned in place - #8547

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/drop-runs-prune
Nov 12, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/drop-runs-prune

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes quest/m1/drop-runs-prune.md. Its work has already landed:

  • #8294 bills a track's drop set to the pool. It sheds the lowest runs under eviction debt and expires them after the pool's window, in Rust (TrackState::shed_drops, expire_drops) and in JS (#shedDrops, #expireDrops). JS keeps the set in Runs (js/net/src/drops.ts), which changes in place for the runs it touches plus a binary search.
  • #8476 bills each reader's disposition record. resume.ts filters its #drops against what has already been delivered.

So the record stays bounded, and inserting no longer costs time quadratic in the number of runs. The one link to this quest, in quest/m3/lite-finished-across-updates.md, is also removed.

Public API / wire impact: none.

🤖 Generated with Claude Code

Review

Skipped: this PR only deletes a finished quest file and one link to it, at head ff67c56. quest check passes.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits November 12, 2026 01:23
#8294 and #8476 bill, shed, and expire a track's drop runs in Rust and JS,
and JS keeps them in an in-place Runs set, so this quest is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Track drop runs are forgotten below the floor quest: drop runs are already pruned in place Nov 12, 2026
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 09:24
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The PR deletes the document describing the drop-run pruning plan. It also edits another plan by removing a sentence that links the bound to drop runs pruned below the floor. The statement that the model passes all four rules remains.

Merge Risk: Minimal · up to ff67c

This change only removes a completed planning document and one reference to it. It has no runtime, API, or wire impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states that drop runs are already pruned in place, which matches the PR's core change: deleting the quest file that describes pruning drop runs and inserting JavaScript drops in place, becau…
Description check Passed The description explains that the quest file is deleted because its work already landed in #8294 and #8476, and it names the affected functions and files. It also notes the removed link in quest/m3/li…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states that drop runs are already pruned in place, which matches the PR's core change: deleting the quest file that describes pruning drop runs and inserting JavaScript drops in place, because that work already landed in #8294 and #8476. The title is specific and accurate, though it describes the rationale more than the file deletion itself.

Full details: Description check

Explanation

The description explains that the quest file is deleted because its work already landed in #8294 and #8476, and it names the affected functions and files. It also notes the removed link in quest/m3/lite-finished-across-updates.md and states there is no public API or wire impact. It is clearly related to the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8ee17b18-c5db-4de9-a283-cb9c06daac21
Commits

Reviewing files that changed from the base of the PR and between 4265dc5 and ff67c56.

Files selected for processing: 2

  • quest/m1/drop-runs-prune.md
  • quest/m3/lite-finished-across-updates.md
Files with no reviewable changes: 1

  • quest/m1/drop-runs-prune.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted quest/m1/drop-runs-prune.md — the quest asked that a track's record of dropped groups stay proportional to the window readers can still ask for, in Rust and JS, where insertDrop and #drop were quadratic or unbounded.
  • Unlinked it from quest/m3/lite-finished-across-updates.md — drops the sentence "The bound ties to [drop runs pruned below the floor]" and leaves the surrounding decision-log paragraph intact.

Verified the closure is justified rather than premature: #8294 (merged 2026-11-10) added TrackState::shed_drops / expire_drops / kept_drops / rearm_drops in rs/moq-net/src/model/track.rs, and #shedDrops / #expireDrops backed by Runs (in-place edits plus a binary search) in js/net/src/drops.ts and js/net/src/track.ts; #8476 (merged 2026-11-12) bills each reader's disposition record. A repo-wide search for drop-runs-prune finds no remaining references, so nothing dangles, and deleting the file matches how recent quests closed (a14505b deleted quest/m1/lite06-requests-end.md, bfd2af2 deleted quest/m0/macos-check.md). I could not run quest check here — the quest binary comes from the moq-dev/quest flake input and is not on this sandbox's PATH — so that claim rests on the PR body.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 3632a39 Nov 12, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m1/drop-runs-prune branch November 12, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant