Repository navigation
quest: drop runs are already pruned in place - #8547
Conversation
Quest-Claim: 46e2bc804f719bf7
|
No actionable comments were generated in the recent review. WalkthroughThe PR deletes the document describing the drop-run pruning plan. It also edits another plan by removing a sentence that links the bound to drop runs pruned below the floor. The statement that the model passes all four rules remains. Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Deleted
quest/m1/drop-runs-prune.md— the quest asked that a track's record of dropped groups stay proportional to the window readers can still ask for, in Rust and JS, whereinsertDropand#dropwere quadratic or unbounded. - Unlinked it from
quest/m3/lite-finished-across-updates.md— drops the sentence "The bound ties to [drop runs pruned below the floor]" and leaves the surrounding decision-log paragraph intact.
Verified the closure is justified rather than premature: #8294 (merged 2026-11-10) added TrackState::shed_drops / expire_drops / kept_drops / rearm_drops in rs/moq-net/src/model/track.rs, and #shedDrops / #expireDrops backed by Runs (in-place edits plus a binary search) in js/net/src/drops.ts and js/net/src/track.ts; #8476 (merged 2026-11-12) bills each reader's disposition record. A repo-wide search for drop-runs-prune finds no remaining references, so nothing dangles, and deleting the file matches how recent quests closed (a14505b deleted quest/m1/lite06-requests-end.md, bfd2af2 deleted quest/m0/macos-check.md). I could not run quest check here — the quest binary comes from the moq-dev/quest flake input and is not on this sandbox's PATH — so that claim rests on the PR body.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Deletes
quest/m1/drop-runs-prune.md. Its work has already landed:TrackState::shed_drops,expire_drops) and in JS (#shedDrops,#expireDrops). JS keeps the set inRuns(js/net/src/drops.ts), which changes in place for the runs it touches plus a binary search.resume.tsfilters its#dropsagainst what has already been delivered.So the record stays bounded, and inserting no longer costs time quadratic in the number of runs. The one link to this quest, in
quest/m3/lite-finished-across-updates.md, is also removed.Public API / wire impact: none.
🤖 Generated with Claude Code
Review
Skipped: this PR only deletes a finished quest file and one link to it, at head ff67c56.
quest checkpasses.(Written by Claude Opus 5.5)