Skip to content

fix(challenge): recitfiy challenge loading through url (@albindavidc) #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albindavidc wants to merge 4 commits into
base: master
Choose a base branch
from
+15 −18
Open

fix(challenge): recitfiy challenge loading through url (@albindavidc) #7723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9c1d9
fix(challenge): recitfiy challenge loading through url
albindavidc Mar 26, 2026
35d9136
fix(challenge): remove unnecessary code and add await
albindavidc Mar 26, 2026
684c277
fix(challenge): move load data await to the top
albindavidc Mar 26, 2026
c82ccfd
Merge branch 'master' into fix/loading-challenge-url
albindavidc Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/ts/controllers/challenge-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,9 @@ export async function setup(challengeName: string): Promise<boolean> {
qs(".page.pageTest")?.show();

if (notitext === undefined) {
showNoticeNotification(`Challenge '${challenge.display}' loaded.`);
showSuccessNotification(`Challenge '${challenge.display}' loaded.`);
} else {
showNoticeNotification("Challenge loaded. " + notitext);
showSuccessNotification("Challenge loaded. " + notitext);
}
setLoadedChallenge(challenge);
challengeLoading = false;
Expand Down
29 changes: 13 additions & 16 deletions frontend/src/ts/controllers/url-handler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,35 +309,32 @@ export function loadTestSettingsFromUrl(getOverride?: string): void {
}
}

export function loadChallengeFromUrl(getOverride?: string): void {
export async function loadChallengeFromUrl(
getOverride?: string,
): Promise<void> {
const getValue = (
Misc.findGetParameter("challenge", getOverride) ?? ""
).toLowerCase();
if (getValue === "") return;

showNoticeNotification("Loading challenge");
ChallengeController.setup(getValue)
.then((result) => {
if (result) {
showSuccessNotification("Challenge loaded");
restartTest({
nosave: true,
});
}
})
.catch((e: unknown) => {
showErrorNotification("Failed to load challenge");
console.error(e);
const result = await ChallengeController.setup(getValue);
if (result) {
restartTest({
nosave: true,
});
}
}

authEvent.subscribe((event) => {
authEvent.subscribe(async (event) => {
if (event.type === "authStateChanged") {
const search = window.location.search;
const hash = window.location.hash;

await event.data.loadPromise;

loadCustomThemeFromUrl(search);
loadTestSettingsFromUrl(search);
loadChallengeFromUrl(search);
void loadChallengeFromUrl(search);
void linkDiscord(hash);
}
});
Loading