Skip to content

Conversation

@LuckySilver0021
Copy link

Description

• Fixes issues with #7447
• Added mode2 to AllTimeCacheKey type and getKey() method
• Removed timestamp from CacheEntry - now only {data, count} exists
• Deleted TTL constant (15min) and all timestamp expiration checks
• Removed unnessasory try-catch blocks around cache.set() method calls

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added the backend Server stuff label Jan 27, 2026
@LuckySilver0021 LuckySilver0021 force-pushed the feat-alltime-leaderboard-ttl branch from 88d5505 to f2d73ea Compare January 27, 2026 11:25
@fehmer
Copy link
Member

fehmer commented Jan 27, 2026

hi @LuckySilver0021 , please add all changes to #7447 instead. No need to open another PR

@fehmer fehmer marked this pull request as draft January 28, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Server stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants