Skip to content

chore(NODE-7418): skip csot change stream tests on sharded topology#4969

Open
tadjik1 wants to merge 1 commit into
mainfrom
csot-change-stream-sharded-skip
Open

chore(NODE-7418): skip csot change stream tests on sharded topology#4969
tadjik1 wants to merge 1 commit into
mainfrom
csot-change-stream-sharded-skip

Conversation

@tadjik1

@tadjik1 tadjik1 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Summary of Changes

Skips 14 CSOT change stream tests that consistently fail on sharded+SSL topology.

The proper fix is tracked in NODE-7418 and is in progress in #4872.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
  • New TODOs have a related JIRA ticket

On sharded clusters the initial $changeStream aggregate is sent with
maxTimeMS set to the remaining CSOT budget. mongos propagates this value
to each shard as maxAwaitTimeMS on the oplog cursor, causing the server
to block for the full budget when no events are present. This makes all
createChangeStream CSOT tests time out on sharded+SSL hosts.

The legacy-timeout retryability tests (socketTimeoutMS=100) also fail
because SSL connection establishment on the sharded+SSL Evergreen host
exceeds 100ms after a socket timeout invalidates the first connection.

Skip all affected tests on sharded topology until NODE-7418 lands.
@tadjik1 tadjik1 marked this pull request as ready for review June 23, 2026 15:15
@tadjik1 tadjik1 requested a review from a team as a code owner June 23, 2026 15:15
Copilot AI review requested due to automatic review settings June 23, 2026 15:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CSOT unified spec test runner wiring to skip a set of change stream–related CSOT tests when running against sharded topologies, addressing consistent failures/hangs on sharded environments while the underlying fix is tracked in NODE-7418.

Changes:

  • Add a sharded-topology skip filter for a curated list of CSOT createChangeStream test descriptions.
  • Add a second sharded-topology skip for the modified unified CSOT change stream test case (unified-csot-node-specs).

configuration.topologyType === 'Sharded' &&
csotChangeStreamShardedSkips.has(test.description)
) {
return 'TODO(NODE-7418): CSOT createChangeStream tests hang on sharded clusters, fixed by NODE-7418';
configuration.topologyType === 'Sharded' &&
test.description === 'timeoutMS is refreshed for getMore if maxAwaitTimeMS is set'
) {
return 'TODO(NODE-7418): CSOT createChangeStream tests hang on sharded clusters, fixed by NODE-7418';
// TODO(NODE-7418): same root cause as csotChangeStreamShardedSkips above.
if (
configuration.topologyType === 'Sharded' &&
test.description === 'timeoutMS is refreshed for getMore if maxAwaitTimeMS is set'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'timeoutMS is refreshed for getMore if maxAwaitTimeMS is set' is already present above in skippedTests. It may already be skipped entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants