test(NODE-7561): Skip QE "prefixPreview" and "suffixPreview" tests on server 9.0.0+#4934
test(NODE-7561): Skip QE "prefixPreview" and "suffixPreview" tests on server 9.0.0+#4934
Conversation
… server 9.0.0+ Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Updates CSFLE Queryable Encryption (QE) test coverage to avoid running deprecated prefixPreview / suffixPreview scenarios against MongoDB server versions where they’re no longer supported (9.0.0+), keeping CI green while the server/spec behavior diverges.
Changes:
- Add
maxServerVersion: 8.99.99run-on requirements to QE unified spec tests that rely onprefixPreview/suffixPreview. - Fix mislabeled
substringPreviewtest description in unified spec files. - Gate/skip integration test logic and spec-suite execution paths that would fail on MongoDB 9.0.0+.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/client-side-encryption/tests/unified/QE-Text-suffixPreview.yml | Restricts suffixPreview unified test to MongoDB < 9.0.0 |
| test/spec/client-side-encryption/tests/unified/QE-Text-suffixPreview.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-prefixPreview.yml | Restricts prefixPreview unified test to MongoDB < 9.0.0 |
| test/spec/client-side-encryption/tests/unified/QE-Text-prefixPreview.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-compactStructuredEncryptionData.yml | Restricts structured encryption test dependent on removed preview query types |
| test/spec/client-side-encryption/tests/unified/QE-Text-compactStructuredEncryptionData.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-cleanupStructuredEncryptionData.yml | Restricts cleanup structured encryption test dependent on removed preview query types |
| test/spec/client-side-encryption/tests/unified/QE-Text-cleanupStructuredEncryptionData.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-substringPreview.yml | Corrects test description label to substringPreview |
| test/spec/client-side-encryption/tests/unified/QE-Text-substringPreview.json | Same description correction in JSON form |
| test/integration/client-side-encryption/client_side_encryption.prose.27.text_queries.test.ts | Skips prefix/suffix setup and cases on MongoDB 9.0.0+ |
| test/integration/change-streams/change_streams.spec.test.ts | Attempts to version-gate unified spec suite for MongoDB 9.0.0+ |
tadjik1
left a comment
There was a problem hiding this comment.
@PavelSafronov let's discuss the testing approach here as none of the affected tests seem running currently on CI.
tadjik1
left a comment
There was a problem hiding this comment.
Thanks @PavelSafronov!
I left suggestion to remove changes in change streams (we can either merge them in a separate or, if you prefer, as part of this PR but as updated spec tests, please see #4935 for more details).
Also couple of leftovers and clarifications are needed.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript