fix(NODE-7291): update moduleResolution to adhere to TS6 deprecation #4786
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @GalacticHypernova thanks so much for all your work on this PR. We're currently reviewing this and will get back to you soon. |
tadjik1
changed the title
tadjik1
added
tracked-in-jira
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This updates the
moduleResolutionconfig property according to https://www.typescriptlang.org/tsconfig/#moduleResolution, as TS6 deprecated "node"Note that I have not updated the
tsdmoduleResolutuion since I'm unsure whether it is following TS's footsteps on this matter. If it should also be updated, I will update itNotes for Reviewers
What is the motivation for this change?
TS has deprecated the "node" moduleResolution, and now it sends errors in the console, hurting DX:
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript