CLOUDP-383487: Fix cluster update removing replica set properties#84
Open
ashortt-mdb wants to merge 2 commits intomainfrom
Open
CLOUDP-383487: Fix cluster update removing replica set properties#84ashortt-mdb wants to merge 2 commits intomainfrom
ashortt-mdb wants to merge 2 commits intomainfrom
Conversation
…ndtrip Add missing field mappings to the convert package so that clusters describe → clusters update no longer silently drops: - ReplicaSet.Settings (chainingAllowed, heartbeatTimeoutSecs, etc.) - ReplicaSet.WriteConcernMajorityJournalDefault - Net.Compression, Net.MaxIncomingConnections, Net.ServiceExecutor - Member.Horizons, Member.Tags Fixes CLOUDP-383487
- Map Process.CPUAffinity in both directions - Extend keepSettings to preserve Net.Compression, MaxIncomingConnections, ServiceExecutor from old processes - Fix keepSettings to not unconditionally overwrite user-supplied OperationProfiling, BasisTech, ProcessManagement, SNMP - Add missing IPV6 write-back in net() (was read but never written) - Remove duplicate audit log block in replicaSetArgs26 - Update AutomationConfigWithOneReplicaSet fixture to include Settings, WriteConcernMajorityJournalDefault, Compression, Tags - Update all test expected outputs for new fixture fields
ashortt-mdb
force-pushed
the
feature/fix-cluster-update-settings-loss
branch
from
2ef31f2 to
77ecedd
Compare
ashortt-mdb
requested review from
apokhyla-inc and
nakulh
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/convert/that silently drops replica set settings, net compression, member tags/horizons, and CPU affinityReplicaSet.Settings,WriteConcernMajorityJournalDefault,Net.Compression,Net.MaxIncomingConnections,Net.ServiceExecutor,Member.Horizons,Member.Tags, andProcess.CPUAffinitykeepSettings()as defense-in-depth for hand-written config filesOut of scope
numactl.numCores— requires upstream SDK change (go.mongodb.org/ops-managerhas noNumaCtlfield onProcess)Test plan
AutomationConfigWithOneReplicaSetto exercise new fieldsgolangci-lintclean on./internal/convert/...