Repository navigation
Conversation
NoahStapp
marked this pull request as ready for review
October 19, 2026 18:58
NoahStapp
requested review from
sleepyStick
and
a balanced review from Copilot
October 19, 2026 18:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports a behavior-preserving refactor with no blocking issues; tests were not run.
No open issues 🎉
What changed in this PR
Consolidates shared, non-I/O OIDC authentication logic into a base class while keeping I/O in the synchronous and asynchronous implementations.
Changes:
- Moves common state and command-building helpers into
_OIDCAuthenticatorBase. - Updates subclasses to inherit shared behavior and pass token generation IDs to invalidation.
| File | Description |
|---|---|
pymongo/synchronous/auth_oidc.py |
Uses the shared base in the generated synchronous implementation. |
pymongo/auth_oidc_shared.py |
Defines the shared authenticator state and non-I/O helpers. |
pymongo/asynchronous/auth_oidc.py |
Uses the shared base while retaining asynchronous I/O. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6030
Changes in this PR
Consolidate existing sync and async _OIDCAuthenticator non-IO code into a shared base class.
Test Plan
Existing test suite.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer