PYTHON-5796: Reduce insert_one({}) collection-priming calls in test suite#2855
Open
sophiayangDB wants to merge 4 commits into
Open
PYTHON-5796: Reduce insert_one({}) collection-priming calls in test suite#2855sophiayangDB wants to merge 4 commits into
sophiayangDB wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
MacOS test failures are unrelated |
sleepyStick
reviewed
Jun 5, 2026
| async def test_case_1(self): | ||
| """Driver can successfully create and list search indexes.""" | ||
|
|
||
| # Create a collection with the "create" command using a randomly generated name (referred to as ``coll0``). |
Contributor
There was a problem hiding this comment.
hmm i think we need to keep the randomly generated name cuz that's what the spec test says (https://github.com/mongodb/specifications/blob/master/source/index-management/tests/README.md#case-1-driver-can-successfully-create-and-list-search-indexes)
sleepyStick
reviewed
Jun 5, 2026
| await self.client.pymongo_test.create_collection("test") | ||
|
|
||
| async def asyncTearDown(self): | ||
| await self.client.pymongo_test.drop_collection("test") |
Contributor
There was a problem hiding this comment.
nit pick / minor comment: does the drop collection need to be here if its also already done in the asyncSetup?
| self.db.test.find_raw_batches()[0] | ||
|
|
||
| def test_collation(self): | ||
| self.db.test.insert_one({}) |
Contributor
There was a problem hiding this comment.
silly question: should this be a create collection?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5796
Changes in this PR
insert_one({})with explicitcreate_collection()calls where the intent is solely to test against an existing collectionTest Plan
Only modified test files.
Checklist
Checklist for Author
Checklist for Reviewer