PYTHON-3519 Fix race condition in pool _reset() causing flaky test#2848
Open
blink1073 wants to merge 1 commit into
Open
PYTHON-3519 Fix race condition in pool _reset() causing flaky test#2848blink1073 wants to merge 1 commit into
blink1073 wants to merge 1 commit into
Conversation
Publish PoolClearedEvent inside size_cond before notify_all() so that no waiting thread can emit ConnectionCheckOutFailedEvent before it. Remove the PyPy skip from test_pool_paused_error_is_retryable.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
MacOS Arm64 failures are unrelated and tracked by PYTHON-5861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-3519
Changes in this PR
Fixes a race condition in
Pool._reset()that causedtest_pool_paused_error_is_retryableto fail intermittently on PyPy and free-threaded Python. Removes the PyPy skip from the test.Test Plan
Run the standard Evergreen tests.
Checklist
Checklist for Author
Checklist for Reviewer