PYTHON-3011 Fix flaky test_connections_are_only_returned_once on PyPy#2847
Open
blink1073 wants to merge 1 commit into
Open
PYTHON-3011 Fix flaky test_connections_are_only_returned_once on PyPy#2847blink1073 wants to merge 1 commit into
blink1073 wants to merge 1 commit into
Conversation
PyPy's tracing GC does not immediately call __del__ when a cursor goes out of scope, so the pinned connection may not be returned to the pool before the assertion. Add gc.collect() (3 rounds) before each assertEqual, matching the identical pattern already used in _test_no_gc_deadlock and test_session_gc in the same file.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
MacOS Arm64 failures are unrelated and tracked by PYTHON-5861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-3011
Changes in this PR
Removes the PyPy skip from
test_connections_are_only_returned_onceand fixes the underlying flakiness so the test runs on PyPy.Test Plan
Checklist
Checklist for Author
Checklist for Reviewer