PYTHON-5852 Fix inverted polling condition in TestSearchIndexProse test_case_3#2843
Merged
Conversation
…st_case_3 The loop that waits for index deletion used `if indices: break`, which exits when the list is non-empty — the opposite of what the comment describes. Change to `if not indices: break` so the loop correctly exits once listSearchIndexes returns an empty array.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NoahStapp
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5852
Changes in this PR
Fix a bug in the
test_case_3prose test ("Driver can successfully drop search indexes") that caused it to always time out waiting for index deletion.Test Plan
test-search-index-helperspassed successfully.Checklist
Checklist for Author
Checklist for Reviewer