Skip to content

PYTHON-5114 Test suite reduce killAllSessions calls #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShaneHarvey wants to merge 3 commits into
base: master
Choose a base branch
from
+26 −1,262
Open

PYTHON-5114 Test suite reduce killAllSessions calls #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2052a9
PYTHON-5114 Test suite reduce killAllSessions calls
ShaneHarvey Mar 2, 2026
8f23842
PYTHON-5114 Fix comment
ShaneHarvey Mar 5, 2026
c0ac732
PYTHON-5114 Remove unused SpecRunner class
ShaneHarvey Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test/asynchronous/unified_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,11 +1464,6 @@ async def verify_outcome(self, spec):
self.assertListEqual(sorted_expected_documents, actual_documents)

async def run_scenario(self, spec, uri=None):
# Kill all sessions before and after each test to prevent an open
# transaction (from a test failure) from blocking collection/database
# operations during test set up and tear down.
await self.kill_all_sessions()

# Handle flaky tests.
flaky_tests = [
("PYTHON-5170", ".*test_discovery_and_monitoring.*"),
Expand Down Expand Up @@ -1504,6 +1499,15 @@ async def _run_scenario(self, spec, uri=None):
if skip_reason is not None:
raise unittest.SkipTest(f"{skip_reason}")

# Kill all sessions after each test with transactions to prevent an open
# transaction (from a test failure) from blocking collection/database
# operations during test set up and tear down.
for op in spec["operations"]:
name = op["name"]
if name == "startTransaction" or name == "withTransaction":
self.addAsyncCleanup(self.kill_all_sessions)
break

# process createEntities
self._uri = uri
self.entity_map = EntityMapUtil(self)
Expand Down
Loading
Loading