[LG-5285] feat(split-button): export MenuItem and MenuItemProps #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 53211e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +9 B (0%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds re-exports of MenuItem and MenuItemProps from @leafygreen-ui/menu to the @leafygreen-ui/split-button package, allowing consumers to import these components directly from @leafygreen-ui/split-button and eliminating the need for a separate import from @leafygreen-ui/menu.
Key changes:
- Exported
MenuItemandMenuItemPropsfrom the split-button package - Updated documentation to reflect the simplified import pattern
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/split-button/src/index.ts | Added re-exports of MenuItem and MenuItemProps from @leafygreen-ui/menu |
| packages/split-button/README.md | Updated example to show importing MenuItem from split-button instead of menu |
| .changeset/new-points-relate.md | Added changeset documenting the minor version change |
stephl3
force-pushed
the
steph/oc-split-button-export-menu-item
branch
from
f179282 to
7b54d36
Compare
stephl3
force-pushed
the
steph/oc-split-button-export-menu-item
branch
from
7b54d36 to
53211e7
Compare
Contributor
|
Coverage after merging steph/oc-split-button-export-menu-item into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tsck
approved these changes
Nov 24, 2025
TheSonOfThomp
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This change adds re-exports of
MenuItemandMenuItemPropsfrom@leafygreen-ui/menuto the@leafygreen-ui/split-buttonpackage. This resolves cross-dependency issues by allowing consumers to importMenuItemdirectly from@leafygreen-ui/split-buttoninstead of requiring a separate import from@leafygreen-ui/menu.An alternative approach was considered here but hit a limitation with the interaction between compound components and polymorphic: #3330
🎟️ Jira ticket: LG-5285
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
MenuItemfrom@leafygreen-ui/split-buttoninstead of@leafygreen-ui/menuMenuItemandMenuItemPropsare properly exported and accessible