LG-5692 experiment - publishing both non-minified and minified bundles #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e696014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nima-taheri-mongodb
changed the title
nima-taheri-mongodb
changed the title
Contributor
|
Size Change: +2.55 kB (+0.14%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
nima-taheri-mongodb
changed the title
nima-taheri-mongodb
changed the title
nima-taheri-mongodb
force-pushed
the
cloudp-352308-env-specific-bundles-experiment
branch
from
8461d7d to
e98c775
Compare
nima-taheri-mongodb
changed the title
nima-taheri-mongodb
requested review from
shaneeza and
tsck
and removed request for
a team
nima-taheri-mongodb
force-pushed
the
cloudp-352308-fix-tsc-script
branch
from
71f2868 to
82c6e29
Compare
nima-taheri-mongodb
force-pushed
the
cloudp-352308-env-specific-bundles-experiment
branch
from
e98c775 to
b9c5489
Compare
tsck
reviewed
Nov 20, 2025
Collaborator
There was a problem hiding this comment.
I'm wondering if minification should be part of the rollup build step rather than a separate lg-build minify command? Then where we want it generated for now we could just do so in the package rollup (charts/legend/rollup.config.mjs in this case). What are your thoughts on that?
Collaborator
Author
There was a problem hiding this comment.
Hey Terrence, thanks for taking a look. That's definitely possible, but it would require running Rollup twice once with terse plugin and once without it. I was a bit concerned about the overhead of repeating transpilation, polyfilling, and other common steps.
In this approach, I tried to copy Underscore project's build config, which uses Rollup for transpilation and runs Terser as a separate script for minification. I figured that might be a more efficient approach.
Let me know if you like the other approach better or there's a 3rd better option.
https://github.com/jashkenas/underscore/blob/master/package.json
nima-taheri-mongodb
force-pushed
the
cloudp-352308-env-specific-bundles-experiment
branch
from
b9c5489 to
e696014
Compare
Contributor
|
Coverage after merging cloudp-352308-env-specific-bundles-experiment into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main←cloudp-352308-env-specific-bundles-experiment🎫 Ticket
LG-5692
📝 Description
This PR updates the build process so we generate both non-minified and minified versions of our bundles. Change is limited to
@lg-charts/legendpackage for experiment before we feel confident to apply it to all other packages. The default export inpackage.jsonis now the non-minified bundle, with the minified version provided as a production-specific export.Details
tools/build/src/minify.ts, which can be accessed either throughlg-build minifyorlg build-minify, to minify all non-minified JavaScript files located indist.--globargument (default is--glob=dist/**/*.*js --glob=!dist/**/*-min.*js)package.jsonexportsto default to the non-minified bundle, adding the minified bundle as a dedicated production export.Rationale
🧪 Documentation and Testing
@lg-charts/legendpackage, I confirmed locally that both non-minified and minified bundles work on MMS. Also can confirm that the minified bundle gets picked up by MMS's webpack configuration automatically.pnpm changesetand included documentation of changes