INTPYTHON-793: Push conditions into lookup when possible. #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaVEV
force-pushed
the
INTPYTHON-713-Push-conditions-into-lookup
branch
3 times, most recently
from
184d5e6 to
73bfed5
Compare
Jibola
changed the title
timgraham
reviewed
Nov 14, 2025
| combinator_pipeline.append({"$unset": "_id"}) | ||
| return combinator_pipeline | ||
|
|
||
| def _get_pushable_conditions(self): |
Comment on lines
+12
to
+30
| def _normalize_query(obj): | ||
| if isinstance(obj, dict): | ||
| normalized = {} | ||
| for k, v in obj.items(): | ||
| if k in MongoTestCaseMixin.COMMUTATIVE_OPERATORS and isinstance(v, list): | ||
| # Only sort for commutative operators | ||
| normalized[k] = sorted( | ||
| (MongoTestCaseMixin._normalize_query(i) for i in v), key=lambda x: str(x) | ||
| ) | ||
| else: | ||
| normalized[k] = MongoTestCaseMixin._normalize_query(v) | ||
| return normalized | ||
|
|
||
| if isinstance(obj, list): | ||
| # Lists not under commutative ops keep their order | ||
| return [MongoTestCaseMixin._normalize_query(i) for i in obj] | ||
|
|
||
| return obj |
Collaborator
There was a problem hiding this comment.
Needs a docstring. It looks like there's some sorting happening, perhaps because the generated query isn't deterministic?
Collaborator
Author
There was a problem hiding this comment.
The query is deterministic, but if I remove this, I had to change many tests because some commutative operators like OR and AND. Since both queries mean the same, the test should accept them as equal under commutative operations.
WaVEV
force-pushed
the
INTPYTHON-713-Push-conditions-into-lookup
branch
3 times, most recently
from
9f056bf to
694368e
Compare
aclark4life
changed the title
WaVEV
force-pushed
the
INTPYTHON-713-Push-conditions-into-lookup
branch
from
694368e to
3e20747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for extracting “pushable” conditions from a Django
WhereNode. Pushable conditions are simple field predicates that can be applied earlier in the MongoDB pipeline.Changes in this PR
_get_pushable_conditions()to collect pushable predicates per alias.Test Plan
Focus Areas for Reviewer
Checklist for Reviewer @timgraham @Jibola @aclark4life