chore: adds field embeddings validation for quantization "none" and warn when vectorSearch is not configured correctly #717
+194
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 19171504420Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances vector search configuration validation and improves tool metadata clarity. The main purpose is to ensure proper vector search setup and provide better user feedback when configurations are incorrect.
Key changes:
- Adds validation for embeddings when quantization is set to "none"
- Introduces warnings when vector search feature and embeddings provider configurations are mismatched
- Updates warning message formatting for better readability
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/search/vectorSearchEmbeddingsManager.ts | Implements validation logic for "none" quantization to ensure embeddings are proper numeric arrays with correct dimensions |
| src/common/config.ts | Adds configuration validation warnings for vector search/embeddings provider mismatches and updates warning message formatting |
| src/tools/mongodb/create/createIndex.ts | Makes vectorSearch reference conditional in tool description based on feature availability |
| tests/unit/common/search/vectorSearchEmbeddingsManager.test.ts | Extends test coverage to validate "none" quantization handling across multiple scenarios |
| tests/unit/common/config.test.ts | Updates test expectations to match new warning message format |
| tests/integration/tools/mongodb/create/createIndex.test.ts | Adds metadata validation and updates expected description text |
| tests/integration/tools/mongodb/create/insertMany.test.ts | Adds metadata validation test for insert-many tool |
nirinchev
reviewed
Nov 10, 2025
| ({ | ||
| pipeline: z | ||
| .array(vectorSearchEnabled ? z.union([AnyAggregateStage, VectorSearchStage]) : AnyAggregateStage) | ||
| .describe(pipelineDescription), |
Collaborator
There was a problem hiding this comment.
The pipeline description here is static and includes references to vector search - should we modify it so that we don't include them if the feature is disabled?
Collaborator
Author
There was a problem hiding this comment.
That's certainly an option but I think that the description applies in a generic sense to the pipeline and I don't think it would be confusing for the LLMs. Or do you feel otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Proposes the following:
vectorSearchonly when the feature is enabled. Additionally adds additional tests for the metadata - 198b36enone- 5cd2e51Checklist