feat(mongodb-runner): get the SLS tag from the manifest file by default - #876
Draft
Conversation
autarch
changed the title
…he build manifest
autarch
force-pushed
the
08-28-feat_mongodb-runner_default_sls_image_tag_from_build_manifest
branch
from
September 11, 2026 19:27
3a6f69a to
6260d06
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Default manifest-based tag resolution lacks integration coverage, and manifest validation messages need clearer API-accurate wording.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates MongoDB Runner to derive the SLS image tag from the adjacent manifest by default while preserving explicit overrides.
Changes:
- Added manifest parsing and tag resolution.
- Made image-tag overrides optional across APIs and CLI.
- Added fixtures, tests, documentation, and formatting exclusions.
File summaries
| File | Description |
|---|---|
packages/mongodb-runner/test/fixtures/sls/no-key/manifest.json |
Missing-key manifest fixture. |
packages/mongodb-runner/test/fixtures/sls/malformed/manifest.json |
Malformed manifest fixture. |
packages/mongodb-runner/test/fixtures/sls/complete/manifest.json |
Complete manifest fixture. |
packages/mongodb-runner/src/sls.ts |
Manifest lookup and default tag logic. |
packages/mongodb-runner/src/sls.spec.ts |
Manifest parsing and error tests. |
packages/mongodb-runner/src/index.ts |
Exports the manifest reader. |
packages/mongodb-runner/src/cli.ts |
Makes the CLI tag override optional. |
packages/mongodb-runner/docs/disaggregated-storage.md |
Documents default tag resolution. |
packages/mongodb-runner/.prettierignore |
Excludes the malformed fixture. |
.prettierignore |
Excludes the malformed fixture globally. |
Review details
Suppressed comments (1)
packages/mongodb-runner/src/sls.ts:60
- When
pinned_sls_commitis present but empty or non-string, this branch reports that the key is absent, which misstates the manifest problem and makes diagnosis harder. Please describe the invalid or empty value rather than only a missing key.
`The SLS build manifest at ${manifestPath} has no pinned_sls_commit key. ` +
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+172
to
+173
| const imageTag = | ||
| options.imageTag ?? (await readPinnedSlsCommit(path.dirname(composeFile))); |
| } catch (err) { | ||
| throw new Error( | ||
| `Could not read the SLS build manifest at ${manifestPath}: ` + | ||
| `${(err as Error).message}. Pass --slsImageTag explicitly to skip this lookup.`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Open Questions
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬